Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
To:     Arnd Bergmann <arnd@arndb.de>, michel@daenzer.net
Cc:     Alex Deucher <alexdeucher@gmail.com>,
        "David (ChunMing) Zhou" <David1.Zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        amd-gfx@lists.freedesktop.org, Shirish S <shirish.s@amd.com>,
        Jerry.Zuo@amd.com, dri-devel <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Harry Wentland <Harry.Wentland@amd.com>
References: <20180811155554.3382650-1-arnd@arndb.de>
 <593dd8e1-fa23-3216-3550-274401d88bcb@gmail.com>
 <CADnq5_PCyKb72-BjFG3B4p_+bctNKoswAibw8C687_fpystSJA@mail.gmail.com>
 <CAK8P3a1AGC4fFYSSDQn2snkvf5htZVffCwRLV1NBm5YeZgw+CA@mail.gmail.com>
 <632dceb6-27e5-869b-46a9-6b11944204fc@daenzer.net>
 <CAK8P3a3fDOeNWsmtXRHOF5cAMit7AMt7fS_54m7NXN0AjZYbPw@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <4bc1c021-e976-03f7-c442-f7ca9804516a@amd.com>
Date:   Tue, 14 Aug 2018 11:17:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAK8P3a3fDOeNWsmtXRHOF5cAMit7AMt7fS_54m7NXN0AjZYbPw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2018 09:17:35.5012 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ec0c739d-38b0-4082-a2fc-08d601c6c75c
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1722
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 14.08.2018 um 11:15 schrieb Arnd Bergmann:
> On Tue, Aug 14, 2018 at 10:54 AM Michel Dänzer <michel@daenzer.net> wrote:
>> On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
>>> On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>>>> On Sun, Aug 12, 2018 at 3:55 AM Christian König
>>>> <ckoenig.leichtzumerken@gmail.com> wrote:
>>>>> Adding Harry as well.
>>>>> Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
>>>>>> Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
>>>>>> Fixes: 4841203102a3 ("drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86")
>>>> Maybe it would be better to revert 4841203102a3 so we can limit the
>>>> scope of this to DCN support.
>>> That would help, but we would still require the patch at
>>> https://patchwork.kernel.org/patch/10090227/ or something else to avoid
>>> broken randconfig builds.
>> FWIW, please don't revert 4841203102a3 in a way which allows
>> CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
>> is reinstated, it should be strictly derived from other options, not
>> changeable by the user.
> How about making all of AMDGPU depend on
> " !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) || BROKEN"
> then?

Well, certainly not a good idea.

We don't want to disable the whole driver just because one broken component.

Christian.

>
>       Arnd