Received: by 2002:a4a:311b:0:0:0:0:0 with SMTP id k27-v6csp4526914ooa; Tue, 14 Aug 2018 07:10:16 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwLb81XYkRpgMY+KvyTzYOSTlPH4CEo9BA3R0h4XT7nAdpsHNDGuKSEObWP5NQGduCxe29H X-Received: by 2002:a63:f919:: with SMTP id h25-v6mr20595363pgi.401.1534255816147; Tue, 14 Aug 2018 07:10:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534255816; cv=none; d=google.com; s=arc-20160816; b=SDXhXLZR7/hTRLhjj2UoJwEr0/dhUmtbynIOGN1hgXJuaNLkeKvshNvxuHZH+btix+ dliSPeMEDGmgMN7AX0n3QiHy1JKIt5I7vKTxUPWJWi5dufcmcgVW0Cvwlz36t0xAJ9MV JPqHU5WA6rrKvHf3fq/M8jhsR+abi9Wd1F/uJUbw5nKhPDNHC5TlWeGIDNahvBQhYVvw hBwkvPljQ9PTnDiU/xb6joHYhxazb0nxAGBPkUpMbL1m8CTy+F3TRTm/hFkRpyk2tT49 oO2sK/1piDtADMgIFLXsH0KsPk5HmCVpJyzLhO3m9LuelqkDKtO+oylPdq92Q9DXHHpu TWhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=G+8CeSpeua02zygrfLANjAYN+ckULJEzAKOEWqVyybw=; b=dvumceUZbvC5RCMbae3Xc8Y5IiM4fYqkudn53IPuz0MCLeAAIJ+a2khmkn5k34aLs+ nSlQjflW7yAuzyc/K/dHCwAlxIqfJ84YnNdmWuVJoIGQ8R46wtHNTXjwoqLXYuwZbNt8 ahdrNAfSdvrccktRbX4ESHaUxavGnN5szqNS0jHQwb6sere9RekyXB/lW5lb6hDvX8zR ccsQeOF30DOGTPj+hbZB+GetKsvebG8/gv0JDXjbQIccrIXeU5rDNc8Is9w+gXqmOe7e d5iHIVljJzjQszxDndmUW6vl1FOn8Z0lNPpjznw+X4FscIeXzqCy+oi132ae9wEzzFT+ sycQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=iwpG6ApN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10-v6si20154453pgk.203.2018.08.14.07.10.00; Tue, 14 Aug 2018 07:10:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=iwpG6ApN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732350AbeHNQvO (ORCPT + 99 others); Tue, 14 Aug 2018 12:51:14 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34320 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728314AbeHNQvO (ORCPT ); Tue, 14 Aug 2018 12:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G+8CeSpeua02zygrfLANjAYN+ckULJEzAKOEWqVyybw=; b=iwpG6ApNgtKaHMCVbTDhMKut2 DkXQhPEVsslOIH9mJsH+l4cDFk6t3oFSD9Ru9JK9MdWaLGOVSwubGs0tMQIYEH2APkWiRK1O2Uaec Jc789FMKy1zH6ObvXFR4NlxVqG1lM44aixUYhXd/QYbA7a/fqDTBRHwwOr0q8KaEc5/nQ=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1fpZvE-0000rO-Ln; Tue, 14 Aug 2018 14:03:44 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 30C1B1124449; Tue, 14 Aug 2018 15:03:44 +0100 (BST) Date: Tue, 14 Aug 2018 15:03:44 +0100 From: Mark Brown To: Julia Lawall Cc: Wu Zhigang , kbuild-all@01.org, sof-ci-monitor@eclists.intel.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ranjani Sridharan , Rander Wang , Pan Xiuli , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix ifnullfree.cocci warnings Message-ID: <20180814140344.GB5810@sirena.org.uk> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QKdGvSO+nmPlgiQ/" Content-Disposition: inline In-Reply-To: X-Cookie: All true wisdom is found on T-shirts. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QKdGvSO+nmPlgiQ/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 14, 2018 at 12:57:57PM +0200, Julia Lawall wrote: > From: kbuild test robot >=20 > NULL check before some freeing functions is not needed. >=20 > Based on checkpatch warning > "kfree(NULL) is safe this check is probably not required" > and kfreeaddr.cocci by Julia Lawall. >=20 > Generated by: scripts/coccinelle/free/ifnullfree.cocci >=20 > Fixes: 0099cc17a399 ("ASoC:topology:avoid error log and oops during topol= ogy free.") This doesn't apply against current code, please check and resend (the above commit isn't in my tree: $ git show 0099cc17a399 fatal: ambiguous argument '0099cc17a399': unknown revision or path not in t= he working tree. --QKdGvSO+nmPlgiQ/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlty4T8ACgkQJNaLcl1U h9Dwswf/cDzgU0SX6gKs4T7NvRHZi0/VT7Sly/AA3cioGpDgCEkD/ovz/mL8R85v 9ksNIyrGtWig6xZV3X0gcofU1jSTIS1CefTqArEjyu7jBFLJITJFWu2ZDhnp/4Ys shB50aZi6kGTg88ll17eJEGNbk/g6WXrSfyjjyjCsXj9I2aY8oSE5UAgtg7J66Yl YGSWofAT/VV2Ww+6QW1YDLjmYKMgsrsjv+o8/1GTzSILiPOI8pi0pcIpO9di7n/i LMpsUzsi5exuP3IGPLXYTZLCXLRgjXzvPYcRHuBv5gu+zYMY0GPW56JVGnPA2shk t45M1fzOUKC4mMP0k0KbihGrZw/Xrw== =7fXd -----END PGP SIGNATURE----- --QKdGvSO+nmPlgiQ/--