Received: by 2002:a4a:311b:0:0:0:0:0 with SMTP id k27-v6csp4797144ooa; Tue, 14 Aug 2018 10:40:56 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx3J0bw02BWi9xA1xbGovS4iJvsuKP/jzPtMeApL3dUkHWKAOuqEzbbFuFPHLLxh81YWPwo X-Received: by 2002:a17:902:a713:: with SMTP id w19-v6mr21092277plq.271.1534268456103; Tue, 14 Aug 2018 10:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534268456; cv=none; d=google.com; s=arc-20160816; b=GqfINjUYTHY2+e0yvG1LbDG14I6zRH9sHxMV2f8W5YYP2x3NNEaaepFsZ0NL0XPrZm S/5HIScvQNDzoETJC4KvLQX5hLoPQIhrJv/ZDpJVLv9NRHqeZZ87VXI+8gEpUw3V05zH Z1k6Eb0BWn4OHos3vFnrMppbPNMRPYlEInYORfF2WJ6kkpWUfpeC/at9/7oOmfN0zWMA PX8/UhlBJAptjsVYjC6v1Vr4jM31VwfFKIrRLBVnZK50FYu0oUvcN/ZCoac6+nQVKj/Y 8MYxYPoUqyispxBqrmPlNSP7rEjwyIfoLaLlblRsum5r/yqQKk7aJVr6uejhsDfNNGJ7 lvxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=tmyuIzHalHtn1MsJfDBwmL/fJOSI6lTBJ83e8HeLSfY=; b=PfnE9LEa4Qvl2o1nb5nw8LF2jXohORrG7dfYDTVnBTGiaovr49Fzp/BGpEiEvQLHQr jL/MO6yflKv4+rC2bZowtGbcw8DrhDfTOOh+vaD1qE3EXBSLhNjwddLG+4pyA/aaqrAv HZhuZDiN56PcDxx5fuVyNoKmQY1XiARIDyiG1IyPjEaQJdsLz90xVDXL/0gOetVmLb16 KBB8ClMMFi3gpRNNg1FWGqVSAbxv2H9tjbpvi+uFyVJFaUgRaUEsp+t0WCFgYv2HKpA6 rb3KUEOD2NUTRjt+0ZZtcJdwM4E2NVSgjbT2TykZYp9YYGmqJNJiUt0Lomjyql3I3WNa RegQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14-v6si17335802pgv.462.2018.08.14.10.40.41; Tue, 14 Aug 2018 10:40:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389275AbeHNU2F (ORCPT + 99 others); Tue, 14 Aug 2018 16:28:05 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58576 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728516AbeHNU2E (ORCPT ); Tue, 14 Aug 2018 16:28:04 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 5EEF1D65; Tue, 14 Aug 2018 17:39:54 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Fabio Estevam , Boris Brezillon , Amit Pundir Subject: [PATCH 4.9 020/107] mtd: nand: qcom: Add a NULL check for devm_kasprintf() Date: Tue, 14 Aug 2018 19:16:43 +0200 Message-Id: <20180814171521.932770026@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180814171520.883143803@linuxfoundation.org> References: <20180814171520.883143803@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fabio Estevam commit 069f05346d01e7298939f16533953cdf52370be3 upstream. devm_kasprintf() may fail, so we should better add a NULL check and propagate an error on failure. Signed-off-by: Fabio Estevam Signed-off-by: Boris Brezillon Signed-off-by: Amit Pundir Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/qcom_nandc.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/mtd/nand/qcom_nandc.c +++ b/drivers/mtd/nand/qcom_nandc.c @@ -2008,6 +2008,9 @@ static int qcom_nand_host_init(struct qc nand_set_flash_node(chip, dn); mtd->name = devm_kasprintf(dev, GFP_KERNEL, "qcom_nand.%d", host->cs); + if (!mtd->name) + return -ENOMEM; + mtd->owner = THIS_MODULE; mtd->dev.parent = dev;