Received: by 2002:a4a:311b:0:0:0:0:0 with SMTP id k27-v6csp4805047ooa; Tue, 14 Aug 2018 10:47:27 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyGUeIXs+KZpItaWAEiPz4JtgHRTVBN7a9VHMhe5txEZoZcnPCpey+jR9OiJsGd9+/UXOOr X-Received: by 2002:a62:4b48:: with SMTP id y69-v6mr24367829pfa.93.1534268847175; Tue, 14 Aug 2018 10:47:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534268847; cv=none; d=google.com; s=arc-20160816; b=jpgdOvN1mg3h9hm1jhuQgSvxoEkbyqVdNBmjU55w/uoIkT9gChKtUJWXYJZAokk2ui ywYbAt+IXm9pbwQjUKOif484pgYKIkd78g+63NqaDpfxkhLE2atMaBfq4Um4mLGVr9uA sBnUjRiDqWZqwh4RYFG03kUYi8jsXthY1vujjarniDyKP46JVg98tMUy1v9ftjzF+6z5 7hqCZ7yTBht0vOtzjsiGVKeIKACbvuxfu+PyZNM7/k5P4pMrsLpHLZ0nk3u6x5bXcMiY wnIqCm98W80qB3Y9x+9ZeG+5GTyYuXQy56EWrb2OEP6A81wUAEOl9ORhz2pL0jRyasGM 5JCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=7q9955EyiENcQyMuGq+6oHqT4SEG6vUzeEzGmWjPlxE=; b=V+15deWjeSTFoZNik3fE3IQfORUu4s6lcPY3U37p13AAX8ybLzhQC8MZ9eRqo0qUHq uyaDaUXiuAfJ/fnHsCudMVrJQf5OtBKCPsd4xAq2c4vppjBpP5UDiRwA4dxEkB9TKgh9 tNs3eqLiNYPLzHOXqOotLpZ8T/EUyVzjLBGJd3jR2jUJF6DqfoyW+5wmUhxfokQ4xjF3 tIBEbYNlrT8aSospQNm1xlt8bXEWTyBgHMKBkMGyPmFJ0gw7d3REWQ5zJTxqZpa9dixE veoEXWCa272EK0sJr0wgeRTkoZQvvrOvfj+zJvUn2J/aSJum6SV9V8jja+q/5FQFA7CO qcdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7-v6si16716658plp.263.2018.08.14.10.47.12; Tue, 14 Aug 2018 10:47:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390919AbeHNUdn (ORCPT + 99 others); Tue, 14 Aug 2018 16:33:43 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60244 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388101AbeHNUdn (ORCPT ); Tue, 14 Aug 2018 16:33:43 -0400 Received: from localhost (unknown [194.244.16.108]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C9214CBA; Tue, 14 Aug 2018 17:45:30 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Bonzini , Thomas Gleixner , David Woodhouse Subject: [PATCH 4.9 098/107] x86/speculation: Use ARCH_CAPABILITIES to skip L1D flush on vmentry Date: Tue, 14 Aug 2018 19:18:01 +0200 Message-Id: <20180814171526.766649931@linuxfoundation.org> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180814171520.883143803@linuxfoundation.org> References: <20180814171520.883143803@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paolo Bonzini commit 8e0b2b916662e09dd4d09e5271cdf214c6b80e62 upstream Bit 3 of ARCH_CAPABILITIES tells a hypervisor that L1D flush on vmentry is not needed. Add a new value to enum vmx_l1d_flush_state, which is used either if there is no L1TF bug at all, or if bit 3 is set in ARCH_CAPABILITIES. Signed-off-by: Paolo Bonzini Signed-off-by: Thomas Gleixner Signed-off-by: David Woodhouse Signed-off-by: Greg Kroah-Hartman --- arch/x86/include/asm/msr-index.h | 1 + arch/x86/include/asm/vmx.h | 1 + arch/x86/kernel/cpu/bugs.c | 1 + arch/x86/kvm/vmx.c | 10 ++++++++++ 4 files changed, 13 insertions(+) --- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -63,6 +63,7 @@ #define MSR_IA32_ARCH_CAPABILITIES 0x0000010a #define ARCH_CAP_RDCL_NO (1 << 0) /* Not susceptible to Meltdown */ #define ARCH_CAP_IBRS_ALL (1 << 1) /* Enhanced IBRS support */ +#define ARCH_CAP_SKIP_VMENTRY_L1DFLUSH (1 << 3) /* Skip L1D flush on vmentry */ #define ARCH_CAP_SSB_NO (1 << 4) /* * Not susceptible to Speculative Store Bypass * attack, so no Speculative Store Bypass --- a/arch/x86/include/asm/vmx.h +++ b/arch/x86/include/asm/vmx.h @@ -505,6 +505,7 @@ enum vmx_l1d_flush_state { VMENTER_L1D_FLUSH_COND, VMENTER_L1D_FLUSH_ALWAYS, VMENTER_L1D_FLUSH_EPT_DISABLED, + VMENTER_L1D_FLUSH_NOT_REQUIRED, }; extern enum vmx_l1d_flush_state l1tf_vmx_mitigation; --- a/arch/x86/kernel/cpu/bugs.c +++ b/arch/x86/kernel/cpu/bugs.c @@ -730,6 +730,7 @@ static const char *l1tf_vmx_states[] = { [VMENTER_L1D_FLUSH_COND] = "conditional cache flushes", [VMENTER_L1D_FLUSH_ALWAYS] = "cache flushes", [VMENTER_L1D_FLUSH_EPT_DISABLED] = "EPT disabled", + [VMENTER_L1D_FLUSH_NOT_REQUIRED] = "flush not necessary" }; static ssize_t l1tf_show_state(char *buf) --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -219,6 +219,16 @@ static int vmx_setup_l1d_flush(enum vmx_ return 0; } + if (boot_cpu_has(X86_FEATURE_ARCH_CAPABILITIES)) { + u64 msr; + + rdmsrl(MSR_IA32_ARCH_CAPABILITIES, msr); + if (msr & ARCH_CAP_SKIP_VMENTRY_L1DFLUSH) { + l1tf_vmx_mitigation = VMENTER_L1D_FLUSH_NOT_REQUIRED; + return 0; + } + } + /* If set to auto use the default l1tf mitigation method */ if (l1tf == VMENTER_L1D_FLUSH_AUTO) { switch (l1tf_mitigation) {