Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Build failures with gcc 4.5 and older
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rik van Riel <riel@surriel.com>,
        Mike Galbraith <efault@gmx.de>,
        Dave Hansen <dave.hansen@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>
References: <20180814170904.GA12768@roeck-us.net>
 <20180814143655.3acd4bb211d44747f77e74f2@linux-foundation.org>
 <20180814221559.GA15888@roeck-us.net>
 <20180814160208.4f4dd7ca142912f5894ddddd@linux-foundation.org>
 <CA+55aFyU6p-da4j0TWQTEkvYDK_ymFDeTfBa9htYXrdH5gahgQ@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <87ca655c-e73a-286f-e69d-30fed9d00d77@roeck-us.net>
Date:   Tue, 14 Aug 2018 18:02:41 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CA+55aFyU6p-da4j0TWQTEkvYDK_ymFDeTfBa9htYXrdH5gahgQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/14/2018 04:20 PM, Linus Torvalds wrote:
> On Tue, Aug 14, 2018 at 4:02 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>> The m68k build still fails because 0cc3cd21657 ("cpu/hotplug: Boot HT
>> siblings at least once") was evidently never tested on CONFIG_SMP=n.
>> How could that come about - the patch is six weeks old??
> 
> Ehh, meet the joys of embargoes.
> 
> The code was tested (and people even found subtle arm64 problems due
> to that testing), but because it couldn't be made public until today,
> it didn't go through all the usual infrastructure we depend on.
> 
> But:
> 
>> kernel/cpu.c: In function 'boot_cpu_hotplug_init':
>> kernel/cpu.c:2275:2: error: 'struct cpuhp_cpu_state' has no member named 'booted_once'
> 
> it should be fixed now in -git.
> 
>> @@ -490,6 +490,8 @@ struct mm_struct {
>>   #endif
>>          } __randomize_layout;
>>
>> +       int wibble;
>> +
> 
> Can we call this something informative? Like
> 
>          int __gcc_4_4_is_garbage_that_shouldnt_be_used;
> 
> or something?
> 
> That is, if we actually want to really drag out this whole pointless
> pain of allowing ancient compilers?
> 
> Guys, at some point we need to switch to 4.6. The people who feel the
> pain today *will* feel the pain at some point. Just get it over with
> already.
> 

For my part I am all for making gcc 4.6 mandatory.

Guenter