Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] vhost: change the signature of
 __vhost_get_user_slow()
To:     Dongli Zhang <dongli.zhang@oracle.com>, kvm@vger.kernel.org,
        netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, mst@redhat.com,
        virtualization@lists.linux-foundation.org
References: <1534297600-2577-1-git-send-email-dongli.zhang@oracle.com>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <12b14053-b3ef-0616-6057-0406e7fd01bf@redhat.com>
Date:   Wed, 15 Aug 2018 11:22:50 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <1534297600-2577-1-git-send-email-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018年08月15日 09:46, Dongli Zhang wrote:
> Remove 'type' from the signature of __vhost_get_user_slow() as it is not
> used.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>   drivers/vhost/vhost.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index ed31145..f78d3bc 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -807,8 +807,7 @@ static int vhost_copy_from_user(struct vhost_virtqueue *vq, void *to,
>   }
>   
>   static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
> -					  void __user *addr, unsigned int size,
> -					  int type)
> +					  void __user *addr, unsigned int size)
>   {
>   	int ret;
>   
> @@ -846,7 +845,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
>   	if (uaddr)
>   		return uaddr;
>   
> -	return __vhost_get_user_slow(vq, addr, size, type);
> +	return __vhost_get_user_slow(vq, addr, size);
>   }
>   
>   #define vhost_put_user(vq, x, ptr)		\

Please keep this as is.

It will be used by incoming packed virtqueue.

Thanks