Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Michael Ellerman <mpe@ellerman.id.au>
To:     Jiri Olsa <jolsa@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>, namhyung@kernel.org,
        dsahern@gmail.com, alexander.shishkin@linux.intel.com,
        linux-kernel@vger.kernel.org, alexander.kapshuk@gmail.com
Subject: Re: [PATCH 1/2] perf tools: Make check-headers.sh check based on kernel dir
In-Reply-To: <20180814231120.GB3180@krava>
References: <20180811083915.17471-1-alexander.kapshuk@gmail.com> <20180813111504.3568-1-jolsa@kernel.org> <87mutplnwk.fsf@concordia.ellerman.id.au> <20180814072726.GA13931@krava> <20180814180644.GA24338@kernel.org> <20180814231120.GB3180@krava>
Date:   Wed, 15 Aug 2018 20:02:48 +1000
Message-ID: <87wossaqwn.fsf@concordia.ellerman.id.au>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Jiri Olsa <jolsa@redhat.com> writes:
> On Tue, Aug 14, 2018 at 03:06:44PM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Tue, Aug 14, 2018 at 09:27:26AM +0200, Jiri Olsa escreveu:
>> > On Tue, Aug 14, 2018 at 11:47:39AM +1000, Michael Ellerman wrote:
>> > > Jiri Olsa <jolsa@kernel.org> writes:
>> > > > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
>> > > > index ea48aa6f8d19..9d466e853aec 100755
>> > > > --- a/tools/perf/check-headers.sh
>> > > > +++ b/tools/perf/check-headers.sh
>> > > > @@ -88,6 +88,8 @@ check () {
>> > > >  # differences.
>> > > >  test -d ../../include || exit 0
>> > > >  
>> > > > +pushd ../.. > /dev/null
>> > > > +
>> > > >  # simple diff check
>> > > >  for i in $HEADERS; do
>> > > >    check $i -B
>> > > 
>> > > This breaks the build when sh is not bash:
>> > > 
>> > >   ./check-headers.sh: 91: ./check-headers.sh: pushd: not found
>> > >   ./check-headers.sh: 107: ./check-headers.sh: popd: not found
>> > >   Makefile.perf:205: recipe for target 'sub-make' failed
>> > 
>> > sry.. Arnaldo, would you change it for simple cd (attached below)
>> > or should I send the fix?
>> 
>> Nah, I'm folding this in, to keep it bisectable.
>
> any chance one of your docker tests could run build in sh/zsh? ;-)

Just using an Ubuntu image, where /bin/sh == dash should work, that's
how I hit it.

cheers