Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Aug 2018 11:57:29 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Douglas Anderson <dianders@chromium.org>
Cc:     linux-arm-msm@vger.kernel.org, bjorn.andersson@linaro.org,
        collinsd@codeaurora.org, swboyd@chromium.org,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] regulator: core: If consumers don't call
 regulator_set_load() assume max
Message-ID: <20180815105728.GW2414@sirena.org.uk>
References: <20180814170617.100087-1-dianders@chromium.org>
 <20180814170617.100087-2-dianders@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dIV3CY5swYZsO92m"
Content-Disposition: inline
In-Reply-To: <20180814170617.100087-2-dianders@chromium.org>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--dIV3CY5swYZsO92m
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 14, 2018 at 10:06:14AM -0700, Douglas Anderson wrote:
> Not all regulator consumers call regulator_set_load().  On some
> regulators (like on RPMh-regulator) this could be bad since the
> regulator framework will treat this as if consumer needs no load.
> It's much better to assume that a dumb client needs the maximum
> possible load so we get correctness first.

If you take this to its logical conclusion we should never have runtime
mode setting - there may be passive components in the system which don't
appear in DT but do affect the load.  It's why we require the machines
to explicitlly enable any changes that the framework does, if we don't
do this then things aren't safe.  You may also have a situation where
some of the drivers that are registered are included in a fixed load
specified by the machine integration.

Dynamic mode setting is just a very hard feature to use usefully,
there's a reason why few systems do it.

--dIV3CY5swYZsO92m
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlt0BxgACgkQJNaLcl1U
h9ASxwf+Nckyt05E1tPXv5gm3yuIus/OGZ5dZhjf6tdS7aoNL+HUG4iEr8TDBgA/
qUMOJioFdR5YjXZwCla3KlN/TZUKOUr8qajwhvwuh+Y3LiNzUKnb/hp8GrsqK3LU
FbsXqxzqPJXgcsacYGtVA4A7/67+c+R6ScvNorUfXGzy6BRygyvxHHeGdMnhcjOt
ejB71/wH7yoAhtMHSKUYkzfwY95Mh+eS37WAgI69zr+KZ28e8DD+Rv2yphcxfrz2
fHcegYeqlbXbdS7/WEAMQpZ8rmeOJ/Sg4OuA3lR0xkC+oB2NPR2VCYP0JZ7XJKrS
x1p6qRhpznCoqbSwKk9UatVvKhHRKQ==
=nEZj
-----END PGP SIGNATURE-----

--dIV3CY5swYZsO92m--