Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Aug 2018 12:06:10 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Doug Anderson <dianders@chromium.org>
Cc:     David Collins <collinsd@codeaurora.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] regulator: core: If consumers don't call
 regulator_set_load() assume max
Message-ID: <20180815110610.GX2414@sirena.org.uk>
References: <20180814170617.100087-1-dianders@chromium.org>
 <20180814170617.100087-2-dianders@chromium.org>
 <bf70f01d-41ac-dcdc-b503-5e0eb1e70329@codeaurora.org>
 <CAD=FV=VNCOyyq5+xvSudTmtBgPm4-s7gj7GRCvuL5vSmA6yDVA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ulNsWUvGrZAj8PMr"
Content-Disposition: inline
In-Reply-To: <CAD=FV=VNCOyyq5+xvSudTmtBgPm4-s7gj7GRCvuL5vSmA6yDVA@mail.gmail.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ulNsWUvGrZAj8PMr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 14, 2018 at 01:03:07PM -0700, Doug Anderson wrote:

> Specifically I will note that there are boatloads of drivers out there
> that use the regulator framework but don't have a call to
> regulator_set_load() in them.  Are these drivers all broken?  I don't
> think so.  IMO the regulator_set_load() API is an optional call for
> drivers that they can use to optimize power usage, not a required API.

Very few systems dynamically change modes in the first place, if we were
doing this as a matter of course you could claim the drivers were buggy
but really it's unusual for it to even be a useful thing to do - as it
is it's more an accomodation for a small subset of systems.  This does
mean that those systems have to pay attention to making sure that
everything works well which is unfortunate but it's not unreasonable.

Forcing the mode to the highest available would be a step backwards for
most systems.

--ulNsWUvGrZAj8PMr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlt0CSEACgkQJNaLcl1U
h9CWwwf8DyzU0sVGYVNbSZw2aH0SSUeW2Cuy6SmKta24xpoxewOvCTw46iAUMj6X
qD4Et23y79goGt6sunMLGFOSgz08lMzzVHD0ffMLKVLm6oLpGUoNtioV5MEruL68
6C6EU69K464hbdYPXYS5k6eRzmyhTVdvpZlq1ncdKv7egRchons8vtoeVf1RHVRG
DHuDq+B/rNGmQDjoP4LTiow/j3yC5QQ6oqRVOhx6bXg7oj/LBCJSXWo4B6a+40Vd
NiQHLJUJBl2x2GySt4S7puxDlP4dDhlpWYe4rScKTHI1TPLgqzRx0Zn4Fv7yHrEb
9G+2TBSBbGYN6R8nf1o/AtNalTXlfA==
=4lkN
-----END PGP SIGNATURE-----

--ulNsWUvGrZAj8PMr--