Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp783495imm; Wed, 15 Aug 2018 06:11:51 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxW5PTHEVJycIrMaiHD2yWZF8bxMvNeYSKNT+ItlrQcKyCxB4y5u/70RMAH9Varvs3MYkG3 X-Received: by 2002:a63:5fc1:: with SMTP id t184-v6mr24387777pgb.183.1534338711811; Wed, 15 Aug 2018 06:11:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534338711; cv=none; d=google.com; s=arc-20160816; b=Ozk4oCidgiqM4FojB/hBtcvda2Nc2CIba41mPzVVAsO+/ILv4AtixuOcdNSyZ5itXR dtj2V0b5g9/Mgm17bxWadp4lBzRtVUxP3N2TzHvY+vZNzjDCPfA+WBiq/JKnwQgRqTv/ rs4RB1yddW1mXzTgZU6n/VaAIKrk7Zl1SVmlJuwjXP2hWdI42hGpWRrwy7Zlm3GnZ8Kf 4ZfbUcwkcQeEgLWJ/QdT9LcvXesV/jyMdi3kc9JHeQSU5APy6o5unZsddLMNvNE7sjOo srTCJBYA9gtYRh3oWLiasC4mdBecs0ZaIPkjQcCEkzzWe66IsUycES0zx1LMQIFRITy4 VnXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=hUyGY1ZlTLteCmXdv3rYBKaYbFxC2iof7U9r1UhFq48=; b=wifZE3/knGqPpHCBWOACBiNDiRsd3mqG7/vG50NaqEvE6j/l8GIwjvl2scW/l54dg3 RWW9s1hw4eUhcaZuoj+XmgJhSLfjfU3pgnBCQfbRGYF7M+Yu7ZBchTSBdl+6S1yshQTf d3UZMECPMSWvjUAojy3t/hbIMIjabsNYqiC8ARJr4BWMe1EaJpyFJUbTtQ20tQQq2//a VxSJMhkfkG3+pMXDGpJC0kobRbxPkKQwdd2mlYNWE7Z/yYktUgIAwoRQ7ilqlLYD0N0c VL468cZ454VtbXAU31Wmvowu0P9/njIghK1V+WDd50APw/tYVIQ/Z4uDkHpQNIrYXIse YU6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8-v6si18768371plr.136.2018.08.15.06.11.36; Wed, 15 Aug 2018 06:11:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729301AbeHOQCw (ORCPT + 99 others); Wed, 15 Aug 2018 12:02:52 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:43398 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728896AbeHOQCw (ORCPT ); Wed, 15 Aug 2018 12:02:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F3DB34023336; Wed, 15 Aug 2018 13:10:44 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id DCE412026D7E; Wed, 15 Aug 2018 13:10:41 +0000 (UTC) Date: Wed, 15 Aug 2018 15:10:39 +0200 From: Cornelia Huck To: Tony Krowiak Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com, Tony Krowiak Subject: Re: [PATCH v9 14/22] KVM: s390: interfaces to clear CRYCB masks Message-ID: <20180815151039.63d83d5d.cohuck@redhat.com> In-Reply-To: <1534196899-16987-15-git-send-email-akrowiak@linux.vnet.ibm.com> References: <1534196899-16987-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1534196899-16987-15-git-send-email-akrowiak@linux.vnet.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 15 Aug 2018 13:10:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 15 Aug 2018 13:10:45 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Aug 2018 17:48:11 -0400 Tony Krowiak wrote: > From: Tony Krowiak > > Introduces two new KVM interface to clear the APM, AQM and ADM masks in > the guest's CRYCB. The VCPUs are taken out of SIE to ensure the VCPUs do > not get out of sync. > > Signed-off-by: Tony Krowiak > Acked-by: Halil Pasic > Tested-by: Michael Mueller > Tested-by: Farhan Ali > Tested-by: Pierre Morel > Signed-off-by: Christian Borntraeger > --- > arch/s390/include/asm/kvm_host.h | 3 +++ > arch/s390/kvm/kvm-s390.c | 15 +++++++++++++++ > 2 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/arch/s390/include/asm/kvm_host.h b/arch/s390/include/asm/kvm_host.h > index 4a739d4..07e58d8 100644 > --- a/arch/s390/include/asm/kvm_host.h > +++ b/arch/s390/include/asm/kvm_host.h > @@ -258,6 +258,7 @@ struct kvm_s390_sie_block { > __u64 tecmc; /* 0x00e8 */ > __u8 reservedf0[12]; /* 0x00f0 */ > #define CRYCB_FORMAT_MASK 0x00000003 > +#define CRYCB_FORMAT0 0x00000000 This should probably go into a different patch (define is not used here)? > #define CRYCB_FORMAT1 0x00000001 > #define CRYCB_FORMAT2 0x00000003 > __u32 crycbd; /* 0x00fc */ > @@ -861,6 +862,8 @@ void kvm_arch_async_page_not_present(struct kvm_vcpu *vcpu, > void kvm_arch_async_page_present(struct kvm_vcpu *vcpu, > struct kvm_async_pf *work); > > +void kvm_arch_crypto_clear_masks(struct kvm *kvm); > + > extern int sie64a(struct kvm_s390_sie_block *, u64 *); > extern char sie_exit; > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index f7de123..8d8a65a 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -1919,6 +1919,21 @@ static void kvm_s390_set_crycb_format(struct kvm *kvm) > kvm->arch.crypto.crycbd |= CRYCB_FORMAT1; > } > > +void kvm_arch_crypto_clear_masks(struct kvm *kvm) > +{ > + mutex_lock(&kvm->lock); > + kvm_s390_vcpu_block_all(kvm); > + > + memset(&kvm->arch.crypto.crycb->apcb0, 0, > + sizeof(kvm->arch.crypto.crycb->apcb0)); > + memset(&kvm->arch.crypto.crycb->apcb1, 0, > + sizeof(kvm->arch.crypto.crycb->apcb1)); > + > + kvm_s390_vcpu_unblock_all(kvm); > + mutex_unlock(&kvm->lock); > +} > +EXPORT_SYMBOL(kvm_arch_crypto_clear_masks); A quick grep shows that kvm-related exports tend to be EXPORT_SYMBOL_GPL. Should that also be done here? > + > static u64 kvm_s390_get_initial_cpuid(void) > { > struct cpuid cpuid;