Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kdb: kdb_support: mark expected switch fall-throughs
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Jason Wessel <jason.wessel@windriver.com>
Cc:     kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <20180805024844.GA15367@embeddedor.com>
From:   Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <4b9d2140-7e9b-82a1-ebbb-fa66a513087a@linaro.org>
Date:   Wed, 15 Aug 2018 15:34:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180805024844.GA15367@embeddedor.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 05/08/18 03:48, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Notice that in this particular case, I replaced the code comments with
> a proper "fall through" annotation, which is what GCC is expecting
> to find.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


> ---
>   kernel/debug/kdb/kdb_support.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
> index 990b3cc..89ac604 100644
> --- a/kernel/debug/kdb/kdb_support.c
> +++ b/kernel/debug/kdb/kdb_support.c
> @@ -432,7 +432,7 @@ int kdb_getphysword(unsigned long *word, unsigned long addr, size_t size)
>   				*word = w8;
>   			break;
>   		}
> -		/* drop through */
> +		/* fall through */
>   	default:
>   		diag = KDB_BADWIDTH;
>   		kdb_printf("kdb_getphysword: bad width %ld\n", (long) size);
> @@ -481,7 +481,7 @@ int kdb_getword(unsigned long *word, unsigned long addr, size_t size)
>   				*word = w8;
>   			break;
>   		}
> -		/* drop through */
> +		/* fall through */
>   	default:
>   		diag = KDB_BADWIDTH;
>   		kdb_printf("kdb_getword: bad width %ld\n", (long) size);
> @@ -525,7 +525,7 @@ int kdb_putword(unsigned long addr, unsigned long word, size_t size)
>   			diag = kdb_putarea(addr, w8);
>   			break;
>   		}
> -		/* drop through */
> +		/* fall through */
>   	default:
>   		diag = KDB_BADWIDTH;
>   		kdb_printf("kdb_putword: bad width %ld\n", (long) size);
>