Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp964869imm;
        Wed, 15 Aug 2018 09:04:29 -0700 (PDT)
X-Google-Smtp-Source: AA+uWPwluIeMsBpSNKezK7kL6jRxsLl/Kn7NFN0j+JUAnAYC3dUM6Tw2uGd1rua9wUwXK/n9fjCW
X-Received: by 2002:a65:6143:: with SMTP id o3-v6mr26259001pgv.52.1534349068972;
        Wed, 15 Aug 2018 09:04:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1534349068; cv=none;
        d=google.com; s=arc-20160816;
        b=rfaPnAHFe8XC/KYRfdmapVNaaXb5Q+P9JFERTTUVGC3Wtb3puF8WoAT51IL+risWWi
         Fb38RhN5KUszRaK/f6zJNcVn9kP8CC8/TKhI3jan69ITfNLW+KWefWr47X0+NlyNHGAj
         niLygoNe/1JoW2RUO4Zq1KHX/nsRXXHNONbwgZv+Qi+nhrUbWonDw8WUuvvp4GxJcQ61
         o2OqE63JStZL7jkAxsmGJURwDbxNH6LIE9UWS+b1x9o8QH+GuJPAJAUYLyPigQJcq/EB
         O7aLUkldgC6FMt0i564ixJz9kIer7c6yul5qktNzIEJMlCvBSEFD1SbR/nNKV7AiNnRm
         YlRQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=kWxahVSIGRB3AjMf4FwhgykEsOuWZsfMHPKtsvJrsQo=;
        b=raC6SosGSZMNOU30Ag7gfJgOmX28jxXB+hvTxK0A9brKtpubV+BSXm7t5tP94uKitk
         uMI7DyPTe9qkzFhbPaHSWop0UcFRGbUCdM7Xm/sXUaGUacEVJe1pnA8oKSj8MzQeE4oq
         qV5WjbCSfzXYkUdr+HPFHJ+pNPjvGQrNi1D4j+hAfbbzKKpldPb5x1v1XOGZxohKwgNP
         xBM9/jSaT6bBC/KNPH60ADtSUf0WFlJBfXBLjcm2y+WJEP2vkU2HA/0UoH2/HsvwkTWA
         IfQlELjfytM2K1vK/pYvHkICEUEmsL4/sc4YjA01y5MvcQJTHQfKhY00BVS6xMsoIZVT
         Z0zg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q74-v6si27157889pfq.32.2018.08.15.09.04.13;
        Wed, 15 Aug 2018 09:04:28 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729640AbeHOSzZ (ORCPT
        <rfc822;ArcheFireLinuxKernelMain@gmail.com> + 99 others);
        Wed, 15 Aug 2018 14:55:25 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:18672 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729249AbeHOSzZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Aug 2018 14:55:25 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b744e900000>; Wed, 15 Aug 2018 09:02:24 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 15 Aug 2018 09:02:32 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 15 Aug 2018 09:02:32 -0700
Received: from [10.2.166.219] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 15 Aug
 2018 16:02:40 +0000
Subject: Re: [PATCH v2] ASoC: tegra: probe deferral error reporting
To:     Marcel Ziswiler <marcel@ziswiler.com>,
        <alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>
CC:     Stefan Agner <stefan@agner.ch>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>,
        Liam Girdwood <lgirdwood@gmail.com>
References: <20180814140145.12212-1-marcel@ziswiler.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <930b05df-c502-192e-3cb9-9e1874701cce@nvidia.com>
Date:   Wed, 15 Aug 2018 17:02:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180814140145.12212-1-marcel@ziswiler.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 14/08/18 15:01, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Actually report the error codes from of_get_named_gpio() resp.
> devm_gpio_request_one() upon trying to get the codec reset resp. sync
> GPIOs unless it is just a probe deferral.
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
> Changes in v2:
> - Silence probe deferral as suggested by Stefan.
> - Fix line over 80 characters as reported by checkpatch.
> 
>  sound/soc/tegra/tegra20_ac97.c | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c
> index 682ef33afb5f..2ac6b2d73980 100644
> --- a/sound/soc/tegra/tegra20_ac97.c
> +++ b/sound/soc/tegra/tegra20_ac97.c
> @@ -351,18 +351,31 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev)
>  		ret = devm_gpio_request_one(&pdev->dev, ac97->reset_gpio,
>  					    GPIOF_OUT_INIT_HIGH, "codec-reset");
>  		if (ret) {
> -			dev_err(&pdev->dev, "could not get codec-reset GPIO\n");
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(&pdev->dev,
> +					"could not get codec-reset GPIO: %d\n",
> +					ret);
> +
>  			goto err_clk_put;
>  		}
>  	} else {
> -		dev_err(&pdev->dev, "no codec-reset GPIO supplied\n");
> +		ret = ac97->reset_gpio;
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev,
> +				"no codec-reset GPIO supplied: %d\n",
> +				ret);
> +
>  		goto err_clk_put;
>  	}
>  
>  	ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
>  					    "nvidia,codec-sync-gpio", 0);
>  	if (!gpio_is_valid(ac97->sync_gpio)) {
> -		dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
> +		ret = ac97->sync_gpio;
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "no codec-sync GPIO supplied: %d\n",
> +				ret);
> +
>  		goto err_clk_put;
>  	}

Thanks, looks good to me. However, I wonder why we don't request the
'sync_gpio' in the probe like we do for the reset? Otherwise ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic