Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 4.9 000/107] 4.9.120-stable review
To:     Linus Torvalds <torvalds@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     Sven Joachim <svenjoac@gmx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, patches@kernelci.org,
        Ben Hutchings <ben.hutchings@codethink.co.uk>,
        lkft-triage@lists.linaro.org, stable <stable@vger.kernel.org>
References: <20180814171520.883143803@linuxfoundation.org>
 <6272e062-6cfc-0669-bebf-ebb039da051a@dd-wrt.com>
 <87k1orms9i.fsf@turtle.gmx.de>
 <55df6754-ce8c-520a-13f9-c610ac498173@dd-wrt.com>
 <20180815185553.GA18219@roeck-us.net>
 <69700876-f31a-ea0a-bdea-2e82b7a5d308@dd-wrt.com>
 <20180815192630.GA20575@roeck-us.net>
 <CA+55aFzHYYai0ZR3eapEqQzt9KVcg8+bGDSmTmc6CzhpmFVfdw@mail.gmail.com>
From:   Sebastian Gottschall <s.gottschall@dd-wrt.com>
Message-ID: <c05b614d-0d4d-6e6b-1014-d5d16875e096@dd-wrt.com>
Date:   Wed, 15 Aug 2018 22:33:11 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <CA+55aFzHYYai0ZR3eapEqQzt9KVcg8+bGDSmTmc6CzhpmFVfdw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Am 15.08.2018 um 21:42 schrieb Linus Torvalds:
> On Wed, Aug 15, 2018 at 12:26 PM Guenter Roeck <linux@roeck-us.net> wrote:
>> Also seen in mainline. Meaning my non-SMP test builds are broken. Hmm.
> Grr. I think it's due mainly due to commit 447ae3166702 ("x86: Don't
> include linux/irq.h from asm/hardirq.h"), which exposes a number of
> files that had some dodgy include file dependenencies, and just
> randomly happened to get it right because of that odd include that
> caused problems.
correct.
>
> That commit itself is definitely the right thing to do, but yes, we
> clearly had a lot of cases of things getting core header files
> included purely by luck.
>
> And because this was all done under embargo, we didn't get the kind of
> test robot coverage we usually get.
>
> Part of it can also be due to subtle merge issues - even if the
> original branch got good coverage, later changes sometimes ended up
> adding things like that.
>
> For example, my merge of the L1TF code found that in the meantime,
> arch/x86/kernel/kvmclock.c had added a call to kzalloc(), which used
> to work just fine, but with the header cleanup it turned out that
> kvmclock.c had never included <linux/slab.h>, so now it didn't build
> right.
>
> And that was just the one I noticed because of my limited build tests.
>
> And yes, every single developer has CONFIG_SMP in their config, but
> perhaps equally importantly, I suspect CONFIG_SMP ends up getting more
> header files included almost by mistake, so it can _continue_ to hide
> these kinds of incomplete header file includes that just happen to
> work.
>
>> Anyway, care to send a proper patch ? I am sure Linus will be more
>> than happy to apply it.
> I think "happy" is too strong a word for my state of mind with all
> this, but yes, I'll apply it, and you'll get the glory of fixing some
> configuration that clearly didn't get properly tested.
>
> In the meantime, maybe I should just do a "make allmodconfig" and then
> disable SMP and see if that shows anything for me.

if it would be helpfull i can do this quick here using the latest 
vanilla tree

Sebastian

>
>                Linus
>