Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1372793imm; Wed, 15 Aug 2018 16:45:27 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx04XNKyTWABsqogtJvD5HI93fCh5dfdjG+OdJPdjHROJIuIqw/zqkIGqgTdrX1K9SVOZcf X-Received: by 2002:a62:f909:: with SMTP id o9-v6mr30069854pfh.141.1534376727359; Wed, 15 Aug 2018 16:45:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534376727; cv=none; d=google.com; s=arc-20160816; b=RMRIje4tkPzHXaFUX0GkUHPmOZq6Wn1BPNtrl5HXMC3vst+uKVD3cncx/oEZCzwAoN c+D0FRbayrWo+JoTPAz3C2dP0cKYerZIMwaQXAFl3Bk2G/xJVGKs1ksW51V7bTYVlvrF cJU1g0B7JM5987H5r0hU/B1D26xod7uzRqCO7sm82uGNs7gD1WSSlZ2cogc939bRN+bZ Ac++QfAQ/nBn1fIQ5DD3MqGFGLUZ1fEbvgVkM0ublF1mnEPNYL8zrHKeBuCY86GPZ98O ITzhxHUJtA+Yu9HW1eSXJok9p0JZ3P3hc//EY86j5wdp0k/TeOvWp11alg6iUoAjpWit AI7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=kPvLDOhTTmKJESRaZym61xsbsyj3D1JntPEYPycrO74=; b=eg3oqPQXrwwWyzo3B6ydJYeU6q1NJT+lfwe83L43Fj/QuPUYzAZsnGHi7fjwg1wIGu SXTEWAjHNQjt20RyygWo+JKRbZMDFYGcLLSfmMWYlOmLepQKQNp2ZVooTxme++ggrENU jk8jqYV6B5LjzORUO4NKfEHzkCe8heHFSsPuCX5a+K0W6/VxxyN0sQV3FzzDBBn17/YF ts4pVO40Wzs4GMZR336Sg0HW7m+1UqFPdtEBarxv71v6DaxXPtinXX9w8F0bmbIas2nX GUjtXBEpTBOijN36rJdzwvrV9LWa+UYIKmkyeyXgqbdHwhsFvAN04cAM2fdTN0tO4Euy q0aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6-v6si24194242pgj.211.2018.08.15.16.45.12; Wed, 15 Aug 2018 16:45:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbeHPB5B (ORCPT + 99 others); Wed, 15 Aug 2018 21:57:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:16231 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728689AbeHPB5A (ORCPT ); Wed, 15 Aug 2018 21:57:00 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2018 16:02:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,245,1531810800"; d="scan'208";a="82084275" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga001.jf.intel.com with ESMTP; 15 Aug 2018 16:02:35 -0700 Date: Wed, 15 Aug 2018 17:03:22 -0600 From: Keith Busch To: Jon Derrick Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Bjorn Helgaas , Sinan Kaya , Oza Pawandeep , Dongdong Liu Subject: Re: [PATCH 1/2] PCI/DPC: Add 'nodpc' parameter Message-ID: <20180815230321.GA5438@localhost.localdomain> References: <1534368400-2807-1-git-send-email-jonathan.derrick@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1534368400-2807-1-git-send-email-jonathan.derrick@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 03:26:39PM -0600, Jon Derrick wrote: > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -536,4 +536,10 @@ static inline void pci_aer_clear_fatal_status(struct pci_dev *dev) { } > static inline void pci_aer_clear_device_status(struct pci_dev *dev) { } > #endif > > +#ifdef CONFIG_PCIE_DPC > +void pci_no_dpc(void); > +#else > +static inline void pci_no_dpc(void) { } > +#endif > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -1473,6 +1473,12 @@ static inline int pci_irqd_intx_xlate(struct irq_domain *d, > static inline bool pci_aer_available(void) { return false; } > #endif > > +#ifdef CONFIG_PCIE_DPC > +bool pci_dpc_available(void); > +#else > +static inline bool pci_dpc_available(void) { return false; } > +#endif Seems like these two sections belong together. Otherwise, looks fine.