Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 Aug 2018 14:46:02 +0800
From:   kbuild test robot <fengguang.wu@intel.com>
To:     Roy Im <roy.im.opensource@diasemi.com>
Cc:     kbuild-all@01.org, Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Support Opensource <support.opensource@diasemi.com>,
        devicetree@vger.kernel.org, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] Input: fix irqf_oneshot.cocci warnings
Message-ID: <20180816064602.GA95363@cairo>
References: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <662cd241e04a1e033c87d1a94c594740b594b0b6.1534384964.git.Roy.Im@diasemi.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: kbuild test robot <fengguang.wu@intel.com>

drivers/input/misc/da7280.c:1335:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

 Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
 threaded IRQs without a primary handler need to be requested with
 IRQF_ONESHOT, otherwise the request will fail.

 So pass the IRQF_ONESHOT flag in this case.

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Fixes: a067f5d53e35 ("Input: new da7280 haptic driver")
CC: Roy Im <roy.im.opensource@diasemi.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 da7280.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/input/misc/da7280.c
+++ b/drivers/input/misc/da7280.c
@@ -1334,7 +1334,7 @@ static int da7280_probe(struct i2c_clien
 
 	ret = devm_request_threaded_irq(dev, client->irq, NULL,
 					da7280_irq_handler,
-					DA7280_IRQ_FLAGS,
+					DA7280_IRQ_FLAGS | IRQF_ONESHOT,
 					"da7280-haptics", haptics);
 	if (ret != 0) {
 		dev_err(dev,