Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1834287imm; Thu, 16 Aug 2018 03:30:08 -0700 (PDT) X-Google-Smtp-Source: AA+uWPy6UFaTD4eCJcSs6SRrucYldrdYYhgq4nIbRtTiZJeciRxIYbAOPE5ZPJ1EUnzwk4hFk4D8 X-Received: by 2002:a17:902:6b89:: with SMTP id p9-v6mr28315448plk.272.1534415408530; Thu, 16 Aug 2018 03:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534415408; cv=none; d=google.com; s=arc-20160816; b=PhsfUc6WjnD3cmJ4Qk4rrsovlACfZZLSIbPK+WwzWHgdwiYjVLeGuDNWu8bXpvJQZr YbB5XR2YVDjKhXjqJLq8McS8VZhhWUFs2ZglHsG2vbJzLGZ+VCD9hehM81mo3T5TI5GY xR6+sJnomgfClV4SHbb367v9to/CRao+1Vn48CTTct0gXpZ4aJCQPxGkTW+DcbF3078C 2PTmJGpE5DKsn+giSU5tExvrz26g9tcSOWsWvkuxMNl4SWNX0dbcIWx/blr0GIK4fDkR HgYd7TSQ4aWrh+9iJMEw++SZ4nwsGhpWbma7K1Mp3WrLWegB5kOpwgnBUMDoENvdNgQb D10Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=L+mygP+IKuArot9650jmifudk6KYbMg2Dus6itp5Eg4=; b=Y4xWc6XPGDG+udw4cHn8jOWrRRA8BG+Gauna0zZf/7saOvdZO9HWl9EC+/HlLABkpt rEMnQhIpryMJBVgHZyenrQ5pkZhgZTdgPPcs8yClItbTrCkh5T57HVoMvoqAoU1JUlJB mp6RD3eikI/qAi4mqDXDxJNkYRNh8CZO4wNDFtsTdBe7tX60T08OlEYyAND223BXI64J F7xvE5oRLlnU/bAFSdzwhlE2dEAgENP0sTlxwQsj2jw9MrITaz6FNbItISFmlHRw6bDk 4UY0CfDcVmli4EqGIReAMuCB4BCg8MFcQDQycbLNs3QO0ff93v+zjXikC1R00HqCI1wk cn9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k3-v6si22008216pld.296.2018.08.16.03.29.38; Thu, 16 Aug 2018 03:30:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388883AbeHPJMC (ORCPT + 99 others); Thu, 16 Aug 2018 05:12:02 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:51036 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387511AbeHPJMC (ORCPT ); Thu, 16 Aug 2018 05:12:02 -0400 Received: by mail-wm0-f66.google.com with SMTP id s12-v6so3313629wmc.0 for ; Wed, 15 Aug 2018 23:15:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L+mygP+IKuArot9650jmifudk6KYbMg2Dus6itp5Eg4=; b=TFF7XnjdR6Ebg9Jgvc6kXob2gpsgH6YApT6Ft92d3KOi8Xbce+XHD4+tInFyjG12fr qamOO7RnLomN4+3bkz5tQOEbmRsfecjnEJP5giFJQxlqDFP+QCdBKNCAa5RAn+UpgX3Q wBSqWhiQ1VH3F4eIuGAGgwy9kNpiYu22QCw6PTJZn72oNycrG8LDil7e7MaFfR8s8NHO sGujWw5aaOvVjGvghmb08sKdVyypk8uaU3LB61KtCJdFiYxnWy5kdSKEc/eyvjEvj1Or /ayW7J1Ovzy9bMw++qs4f4hI6azdn7cpJMhXpIt/IUViYWQToDLB5saSXEhRMthesaC2 FtzA== X-Gm-Message-State: AOUpUlGvHRI5NVM620VMEUxHJbumhz5rrdPRU+aIVLdvpWqgKDnQnJnX O569oAOLhaae10hz7V5u9J7dWNURtxo= X-Received: by 2002:a1c:e3d5:: with SMTP id a204-v6mr14834252wmh.20.1534400153346; Wed, 15 Aug 2018 23:15:53 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id l72-v6sm1098911wma.17.2018.08.15.23.15.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 23:15:52 -0700 (PDT) Received: by techadventures.net (Postfix, from userid 1000) id 188021248C8; Thu, 16 Aug 2018 08:15:52 +0200 (CEST) Date: Thu, 16 Aug 2018 08:15:52 +0200 From: Oscar Salvador To: Andrew Morton Cc: mhocko@suse.com, vbabka@suse.cz, pavel.tatashin@microsoft.com, Jonathan.Cameron@huawei.com, arbab@linux.vnet.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH v2 3/4] mm/memory_hotplug: Make register_mem_sect_under_node a cb of walk_memory_range Message-ID: <20180816061552.GA15875@techadventures.net> References: <20180622111839.10071-1-osalvador@techadventures.net> <20180622111839.10071-4-osalvador@techadventures.net> <20180815152135.4f755e25c865af2054cfaf02@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180815152135.4f755e25c865af2054cfaf02@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 03:21:35PM -0700, Andrew Morton wrote: > On Fri, 22 Jun 2018 13:18:38 +0200 osalvador@techadventures.net wrote: > > > From: Oscar Salvador > > > > link_mem_sections() and walk_memory_range() share most of the code, > > so we can use convert link_mem_sections() into a dummy function that calls > > walk_memory_range() with a callback to register_mem_sect_under_node(). > > > > This patch converts register_mem_sect_under_node() in order to > > match a walk_memory_range's callback, getting rid of the > > check_nid argument and checking instead if the system is still > > boothing, since we only have to check for the nid if the system > > is in such state. > > > > Signed-off-by: Oscar Salvador > > Suggested-by: Pavel Tatashin > > We have two tested-by's bu no reviewers or ackers? Pavel, would you be so kind to review this patch? It is the only patch from the patchset which did not get a review. Thanks! -- Oscar Salvador SUSE L3