Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2450276imm; Thu, 16 Aug 2018 09:46:17 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxPO3nPXAiFu1rWEGhmpTRGPe/ez38QPMSxKon2vD0lGXOy2USPoj7bXwoNbPs+NsdTkyW+ X-Received: by 2002:a17:902:5a82:: with SMTP id r2-v6mr29498203pli.315.1534437977936; Thu, 16 Aug 2018 09:46:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534437977; cv=none; d=google.com; s=arc-20160816; b=T51M7X5V1JLjkOWQ+hFovtlnsQFjPobsaFmBrWvO0hXM6tUPIjXD7uwsDFJn14NqZM VjZGjo+fxkMf/2A7aZCyNsox/QA09LB/z0kaQUUg6ZmADoUliPYMZanX5/TEX9N3qcet 4tYqEs3/fDs1ThIcqafuR+IF/uMnCw9wlBN9OcUYwbPuXwjCgiRhqJ3ue6sKKDm9HTNB vcLEsYTa7XskHfXyPB+Y0qo/e3QonMeOKsBQgONBYkr+sVZ0c5iwYjDEUSgn0D9q6NJc tRmtM5H8enhiOQkasyVRY/5AFvQGXkB/ACgLjJN49agAwaHVDH0JlMPHt5Bp1oUr+D2H uB6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=x8OPKDTF0lKS1Jp6qTBZe7HRst7nQiOjqXxDoEquoGQ=; b=fPGBwZBssSez+NP/N4+pNTkFcY8Pf0JWgy/6OpKngxMB8DwVaZw/GM5CSBRu35e0Gf Vi0uL0wwMNK+RVB44VnxkQyP6d+WhSPfNI7gJUF8rVlj9QnV12q+XRQ98gAZZ7rZJ7vr Rn67ma5LaAKSuAGuwmuM9j4tf3HJYjhalBSEwsi+RW//R0Uw9Xqb3BamVnadQNAE8jLw X+eSopTzT4lcgovxhpOtem8GRarQpTOZbtSML8jeZnxQebvciLg8w/fVfbszeiP3gqtf P6+Tsqvm+PeGMzS8wldLwwf2+RQgYSuERe5x0/q2KU+tuyzTX0a9dqj38k6NMURpbiHG k5/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q13-v6si21133920pll.72.2018.08.16.09.46.02; Thu, 16 Aug 2018 09:46:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390211AbeHPLmr (ORCPT + 99 others); Thu, 16 Aug 2018 07:42:47 -0400 Received: from mail.bootlin.com ([62.4.15.54]:51621 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390198AbeHPLmp (ORCPT ); Thu, 16 Aug 2018 07:42:45 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 4950820DB0; Thu, 16 Aug 2018 10:45:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [78.250.249.73]) by mail.bootlin.com (Postfix) with ESMTPSA id 31630208CC; Thu, 16 Aug 2018 10:45:30 +0200 (CEST) From: Alexandre Belloni To: Wolfram Sang , Jarkko Nikula , James Hogan Cc: Paul Burton , Andy Shevchenko , Mika Westerberg , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Thomas Petazzoni , Allan Nielsen , Alexandre Belloni Subject: [PATCH v4 5/7] i2c: designware: add MSCC Ocelot support Date: Thu, 16 Aug 2018 10:45:19 +0200 Message-Id: <20180816084521.16289-6-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180816084521.16289-1-alexandre.belloni@bootlin.com> References: <20180816084521.16289-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Microsemi Ocelot I2C controller is a designware IP. It also has a second set of registers to allow tweaking SDA hold time and spike filtering. Reviewed-by: Andy Shevchenko Signed-off-by: Alexandre Belloni --- drivers/i2c/busses/i2c-designware-core.h | 3 ++ drivers/i2c/busses/i2c-designware-platdrv.c | 40 +++++++++++++++++++++ 2 files changed, 43 insertions(+) diff --git a/drivers/i2c/busses/i2c-designware-core.h b/drivers/i2c/busses/i2c-designware-core.h index ad4e9619d365..f7883224e1af 100644 --- a/drivers/i2c/busses/i2c-designware-core.h +++ b/drivers/i2c/busses/i2c-designware-core.h @@ -238,6 +238,7 @@ struct dw_i2c_dev { struct device *dev; void __iomem *base; + void __iomem *ext; struct completion cmd_complete; struct clk *clk; struct reset_control *rst; @@ -292,6 +293,8 @@ struct dw_i2c_dev { #define ACCESS_INTR_MASK 0x00000004 #define MODEL_CHERRYTRAIL 0x00000100 +#define MODEL_MSCC_OCELOT 0x00000200 +#define MODEL_MASK 0x00000f00 u32 dw_readl(struct dw_i2c_dev *dev, int offset); void dw_writel(struct dw_i2c_dev *dev, u32 b, int offset); diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c index 776d4354f366..0d9bfa45550d 100644 --- a/drivers/i2c/busses/i2c-designware-platdrv.c +++ b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -170,11 +170,48 @@ static inline int dw_i2c_acpi_configure(struct platform_device *pdev) #endif #ifdef CONFIG_OF +#define MSCC_ICPU_CFG_TWI_DELAY 0x0 +#define MSCC_ICPU_CFG_TWI_DELAY_ENABLE BIT(0) +#define MSCC_ICPU_CFG_TWI_SPIKE_FILTER 0x4 + +static int mscc_twi_set_sda_hold_time(struct dw_i2c_dev *dev) +{ + writel((dev->sda_hold_time << 1) | MSCC_ICPU_CFG_TWI_DELAY_ENABLE, + dev->ext + MSCC_ICPU_CFG_TWI_DELAY); + + return 0; +} + +int dw_i2c_of_configure(struct platform_device *pdev) +{ + struct dw_i2c_dev *dev = platform_get_drvdata(pdev); + struct resource *mem; + + switch (dev->flags & MODEL_MASK) { + case MODEL_MSCC_OCELOT: + mem = platform_get_resource(pdev, IORESOURCE_MEM, 1); + dev->ext = devm_ioremap_resource(&pdev->dev, mem); + if (!IS_ERR(dev->ext)) + dev->set_sda_hold_time = mscc_twi_set_sda_hold_time; + break; + default: + break; + } + + return 0; +} + static const struct of_device_id dw_i2c_of_match[] = { { .compatible = "snps,designware-i2c", }, + { .compatible = "mscc,ocelot-i2c", .data = (void *)MODEL_MSCC_OCELOT }, {}, }; MODULE_DEVICE_TABLE(of, dw_i2c_of_match); +#else +static inline int dw_i2c_of_configure(struct platform_device *pdev) +{ + return -ENODEV; +} #endif static void i2c_dw_configure_master(struct dw_i2c_dev *dev) @@ -309,6 +346,9 @@ static int dw_i2c_plat_probe(struct platform_device *pdev) dev->flags |= (uintptr_t)device_get_match_data(&pdev->dev); + if (pdev->dev.of_node) + dw_i2c_of_configure(pdev); + if (has_acpi_companion(&pdev->dev)) dw_i2c_acpi_configure(pdev); -- 2.18.0