Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2523528imm; Thu, 16 Aug 2018 10:52:07 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxiNO1Q3OxQMxdZdCW4LAh587snUa/1uhgmAEAvrDtod7oWzAe/XU4YzFDwZTorKUWqf+d5 X-Received: by 2002:a17:902:683:: with SMTP id 3-v6mr7483809plh.52.1534441926963; Thu, 16 Aug 2018 10:52:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534441926; cv=none; d=google.com; s=arc-20160816; b=n4r6JjqHdiy4gu5ZlY6z+pf1GsGITwdGrinv0BiDLPRdLrKesgDqzCSNnX3UodQePn wYI93RASDi1axrv7zD5XpOSvbpHDZJH5QZek8BcGn62bXgaWJ+OlIT31jvAwlPrAuHq1 HTbOcR6UBkklW/u1bQtKVKlagjZzXYFW+dnhVtHJGen9kY/KACNEyyuTjbfrSNnv0PqV jUCX7B6rRtrpzaQNXHUKhWVTLjeGct7lIUbAzdhLv/WVg/CFbKUx5cnRd2wWEMIVIZdf 8e8aEWYOCeC1fbDNIon9BZ8peFa7tXg4Kob5EI4j1ZJ8i5hwHzX+ZYTeDxHEDO3JhhRi HKUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Pr6KVZSCbL7Du4YeoGE2b6PCMpl6DCqiDOKt3gzpIPA=; b=GlVzp7t2XkTBbuaAlMAPBaZ/X7did66IiWqDwhY2/IqYah+/1IAHvYcDZKzli85bGy Zf5XF1SJCEjTkTDPRM5g/XkTlg24a26HqbBpFqjcLFMxtsuZABt3B+OzABvpLFt0uVVL ozg12L8s2DvgGgpsz9HsRdm1mdWmAdDFB5DnB/kyNwiG5jgl587szf5nVbaQqJIPRYdu C7eorjOhS3Ljdx2ELyovdJZYqoYHZW9Eo20QJa8/GILuqFoRD1RYxErH/MQ5pc187rZo ivPIkNL8yK28SiUXToa5geLVgeMIYHx6YT1c+GbU06dWnl469mSCb7RP+s72IIg3FdvE DctQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ogXoMJxR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x1-v6si21495608pln.336.2018.08.16.10.51.51; Thu, 16 Aug 2018 10:52:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ogXoMJxR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388174AbeHPNta (ORCPT + 99 others); Thu, 16 Aug 2018 09:49:30 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56106 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387896AbeHPNta (ORCPT ); Thu, 16 Aug 2018 09:49:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Pr6KVZSCbL7Du4YeoGE2b6PCMpl6DCqiDOKt3gzpIPA=; b=ogXoMJxROwk0Ev1p18MbFjmdm iinjgHAjQhOuP0dvBTcYXwC/7Ck7ppeNOnu2dzanwsqRdz3+fAYKbVdWM0AZ6wGLGV62n+UQpVQRK QqolSwoowp384FmzEfc9iY09m/eValIVkt0oqjWkjHIJeOHJsDwqKKy6Dw2o9CZRYCdSE=; Received: from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre.ee.mobilebroadband) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fqFsP-0002gY-24; Thu, 16 Aug 2018 10:51:37 +0000 Received: by finisterre.ee.mobilebroadband (Postfix, from userid 1000) id E84D6440078; Thu, 16 Aug 2018 11:51:35 +0100 (BST) Date: Thu, 16 Aug 2018 11:51:35 +0100 From: Mark Brown To: Jon Hunter Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [RFC PATCH] ASoC: core: Optimise suspend/resume of DAPM widgets Message-ID: <20180816105135.GZ2414@sirena.org.uk> References: <1533301025-19980-1-git-send-email-jonathanh@nvidia.com> <20180803163605.GD6591@sirena.org.uk> <7ba86328-5bb6-5280-df6f-9937173fb2ab@nvidia.com> <20180814144004.GD5810@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0786ZyFfTSxuegBe" Content-Disposition: inline In-Reply-To: X-Cookie: Many are called, few volunteer. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0786ZyFfTSxuegBe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 15, 2018 at 07:48:47PM +0100, Jon Hunter wrote: > So then I made the following change to avoid scheduling the function > calls unnecessarily (which I think should be fine) ... > Please note that I am just using ktime_get() to log the time on entry > and exit from dapm_power_widgets() and so yes the time may not be > purely the time take to execute this function if we are preempted, > but I am measuring in the same way in both cases and so it does seem > to show some improvement. That seems like a simple and useful optimization, will you send a patch? --0786ZyFfTSxuegBe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlt1VzQACgkQJNaLcl1U h9C++wf/QB19v9pWanJUtK3uJI3vVk9Y6HQxYhrr0b9X6aZ9IPlhxWlBssaSEY0O 1zygbrumfW9K8OLLANmo8Xb0oMb8YcXwG5UO2aIieuIwxvQo+hwUUI9QwH020JB7 +3bRvRumioLOfR+NeZTg7M5oGuuGK34o0j/pyCT0Ej3v2YKZUlai0ynwxGkfbuav RiPia8eACF76DkDRBcWMQYy45+kZIXdkBOJvZcnzWGUfhlNEugWo92oYQxSshySV TsUG1H3HGN1/JvAogds/wVAOXSA8dt8fc1KddCdPEtaCPAoGa8NooKZDlrJFHn1L FQhmW9eQB1nzC8venmJohqs7SiPvNA== =OMjY -----END PGP SIGNATURE----- --0786ZyFfTSxuegBe--