Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2570193imm; Thu, 16 Aug 2018 11:40:18 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwNFiZK+vlmEGMd5hHMm7iDlGf8Mmdg3NoOi7Up4pFC8kMUdJiq1tvYu+Y8mAheextekCCj X-Received: by 2002:a17:902:6ac3:: with SMTP id i3-v6mr30187486plt.252.1534444818807; Thu, 16 Aug 2018 11:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534444818; cv=none; d=google.com; s=arc-20160816; b=W3Xbcj84uhA+Eokln7PIZI8VZ+TaD0O8lh0Y+Ojt4AfAkCqoVsRl9yIUIm3wXjUI28 Jft7YErA+1efCzZ4N2XiUFXNMX+jH/sMbbeDXa6z2tX4xDejgtNtWb6I86UAiEOoJoAm 1UsZF+rr9hVr8ZKJDXZkv83G0vHTU8a5g1Z72bXfrJ2mLYK27WTqj3tbDvh5LS10sLaW FFPX8X1F8PI4ZdRfNhw5q5Y618/fFVWO/RHeXwKOog2LeTM4UK9u07wc/mDB9f1ww6JS ohA7cEs2kgYrEn7XqfRUykUePNnb93oJiUBJgiUXr0Jp5Tyel/7alC1u2wywblNDnncN u1sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=d3N4LzndG+wv3QQpqJEIyqTXngxfhGT5BNWkqdjW5Qs=; b=skwfW0g9Er97pNjJx7DieDwyVK1CDesKx/g5Q0/MJlrR0mVOg5qZe8bqtnMdcGIDAn KEp+o/8I6xArMtZk+n/hYZ/Lg8MyYewqjKkOp68L4EPjsKn5Lua42bB7HLPxRSBH1Ly5 qscBT/i420P/Zjdv+qlUQgUhmKEfPLS1HDd7oNba+eW5bAwfX1NUGM36eStN+SlE1xeM AGxxqNggjfblPm3XoCUPmvUUsmz+dhhXI3h4qs0CdYX0yXA2qJTs6gxLrvOmjLnf9AkF hcdexB1NtjP5X2JJQ2/1IORWPwmvKk2G98ECg7VHRkW9BlOvzIfgbT1tZVxkRTPjFcJ/ svVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z77-v6si38287pff.100.2018.08.16.11.40.04; Thu, 16 Aug 2018 11:40:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403989AbeHPR76 (ORCPT + 99 others); Thu, 16 Aug 2018 13:59:58 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:37550 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726022AbeHPR75 (ORCPT ); Thu, 16 Aug 2018 13:59:57 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FB8D7A9; Thu, 16 Aug 2018 08:00:56 -0700 (PDT) Received: from [0.0.0.0] (e107985-lin.emea.arm.com [10.4.12.239]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 710443F5D0; Thu, 16 Aug 2018 08:00:48 -0700 (PDT) Subject: Re: [PATCH v3 03/14] sched/core: uclamp: add CPU's clamp groups accounting To: Quentin Perret Cc: Patrick Bellasi , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-4-patrick.bellasi@arm.com> <20180814164905.GG2605@e110439-lin> <7c45c1a8-24cb-6798-5b6f-3b5dfc9b490d@arm.com> <20180815105428.GA7388@e110439-lin> <20180816133249.GA2964@e110439-lin> <20180816133737.xfwfoenbhb5wnndi@queper01-lin> <20180816142115.v7nybc4qfazdiz6n@queper01-lin> From: Dietmar Eggemann Message-ID: <434c550d-65da-1b41-b949-c91b9cfdd127@arm.com> Date: Thu, 16 Aug 2018 17:00:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180816142115.v7nybc4qfazdiz6n@queper01-lin> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2018 04:21 PM, Quentin Perret wrote: > On Thursday 16 Aug 2018 at 15:45:45 (+0200), Dietmar Eggemann wrote: >> On 08/16/2018 03:37 PM, Quentin Perret wrote: >>>>> IMHO, if this is something which should not happen at all, a BUG_ON() is the >>>>> right thing to do here. >>>> >>>> I don't agree on that. I agree it should not happen but since it's a >>>> recoverable error it think we should not panic. >>> >>> FWIW, if this is a recoverable error, I think Linus will agree with >>> Patrick on this one :-) >>> >>> https://lkml.org/lkml/2016/10/4/1 >> >> Yeah, not really agreeing here that this is a recoverable error. > > A non-recoverable scenario could be, for example, if you corrupt your > stack and there is absolutely _nothing_ you can do to keep the system up > and running, because it's just too broken. I don't feel like we're > talking about such an extreme case here ... Yeah, that's the extreme. But what about this lovely BUG_ON(busiest == env.dst_rq) in fair.c's load_balance()? We could recover by just bailing out ;-) I guess we know by now that there are different opinions here. > >> Besides, we >> only consider under-run here, what about over-run? Important thing is to also detect the over-run, i.e. add the first task and the task counter is already > 0. >> >> Currently this warning doesn't hit and if the code will be changed and it >> hits, I still find a BUG_ON more appealing here ... >> >> So this error scenario can happen over and over again and we always recover >> from ? The important thing is that we find the culprit for this behaviour as >> fast as possible ... > > Agreed, we want to debug that ASAP, but WARN should let us do that just > fine, I think. +1.