Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2572660imm; Thu, 16 Aug 2018 11:43:05 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwYkoLKQ2K4ZjqPnwEzYEezTewdN+LiSfX62faRokb4miJ2SxqBAEJ7WaR7/xeR2BEVdiu2 X-Received: by 2002:a65:6086:: with SMTP id t6-v6mr5192408pgu.424.1534444985498; Thu, 16 Aug 2018 11:43:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534444985; cv=none; d=google.com; s=arc-20160816; b=gXLZAcewL71vTErFgW6JftfGMtRDvYuGuZlp16DPlap2IoxKBoCPgT4beY1vNQS9Ho 6anDR5pWIDA9poZJJYJxRdQKwvJaZwz6PFV0jl35E5hYQhPOHVR9Lqh3Yjtc/RbS02RR 50ijgYix9RTf/0t4gLwg0i0RnV63T2knhujE4TVsQRUZztOeXUwRyXTlFiroPd4U2+K5 3AxUddi/1OocN5LA/4UGcb+wFmUsgdLJ1kJliEkoyb99X+WHAaemjuPS9kfxt6406yVN q4T5qqzQhZB7XNQmR3lZ0BXb55z3oWTlgHKlpoke5fdZwOWzUSzgvYdam5K3vHLeiXof /NJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=I/XGgzMpyW6GWcZ8QIC+7ABnKg73bBfAPrO35gAPGSM=; b=sYwWzZPYm7N3Dy4+Ot6iBq1WVc3YGaD+zbM4xxxReatD+/j8+GoDkpvIs4fFsaA0te ahLnP59IgEcOypvi/g46aSkhIg16vQwXpNbJJ2zr78xSk/ctjsztbiOCXnF2CJwiBKbb WTwONvF20eFmxBV/WpG5UFJbCJ2nxhyQnFXJK5zJIumSDlTNPNP62JUVmC9BIBgDes03 vOH9dv0i/ETBzEV6V/CfImthdlFq8qW3wgA4zoEaW8UHQ0NSDP7zyu7NMHhtZ9iud3A+ MypbyuXp5e1O8ow46q/i+rTENezybgO6ZMZqYObRhrSj8JjakwMKS45hy84xT7NQzIsb Q2fQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m9-v6si43639pgq.172.2018.08.16.11.42.50; Thu, 16 Aug 2018 11:43:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391968AbeHPSYd (ORCPT + 99 others); Thu, 16 Aug 2018 14:24:33 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1508 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387805AbeHPSYb (ORCPT ); Thu, 16 Aug 2018 14:24:31 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Thu, 16 Aug 2018 08:25:16 -0700 Received: from HQMAIL101.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 16 Aug 2018 08:25:11 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 16 Aug 2018 08:25:11 -0700 Received: from [10.2.160.104] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 16 Aug 2018 15:25:20 +0000 Subject: Re: [RFC PATCH] ASoC: core: Optimise suspend/resume of DAPM widgets To: Mark Brown CC: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , , , References: <1533301025-19980-1-git-send-email-jonathanh@nvidia.com> <20180803163605.GD6591@sirena.org.uk> <7ba86328-5bb6-5280-df6f-9937173fb2ab@nvidia.com> <20180814144004.GD5810@sirena.org.uk> <20180816105135.GZ2414@sirena.org.uk> From: Jon Hunter Message-ID: Date: Thu, 16 Aug 2018 16:25:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180816105135.GZ2414@sirena.org.uk> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/08/18 11:51, Mark Brown wrote: > On Wed, Aug 15, 2018 at 07:48:47PM +0100, Jon Hunter wrote: > >> So then I made the following change to avoid scheduling the function >> calls unnecessarily (which I think should be fine) ... > >> Please note that I am just using ktime_get() to log the time on entry >> and exit from dapm_power_widgets() and so yes the time may not be >> purely the time take to execute this function if we are preempted, >> but I am measuring in the same way in both cases and so it does seem >> to show some improvement. > > That seems like a simple and useful optimization, will you send a patch? Yes I will send a patch for this. Cheers Jon -- nvpublic