Received: by 2002:a4a:311b:0:0:0:0:0 with SMTP id k27-v6csp2471908ooa; Thu, 16 Aug 2018 12:18:45 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwjfw8K0aGT6gGpxk+icxKoqwO0gBZ5hdpEZPhv8ulGnpVE+9LgMpxuVacXRdUtHYVjSvbm X-Received: by 2002:a63:6ecf:: with SMTP id j198-v6mr30650407pgc.213.1534447125649; Thu, 16 Aug 2018 12:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534447125; cv=none; d=google.com; s=arc-20160816; b=P7iX1GMtz5c8biB6iTHfWmmdv0p2zHqEOy29SO8+PdhxRFWNy1AFoFny6/YJ/0GMa0 Jg7EzUFr8ah6HPKoAKfaZgit00cB8wI5lTh7r2Sb6Abhi3TtHc0WOPqb6VYBU3F7va79 4l9F72rq8vIRyrJ2DplnuqUuKZLcQxq9q/BHPv0T3c/TC1Tg6USYUNk17wOrKdCJykO3 ibUnqbGOuEqw2+P3kH/P0f9O10IN87oc08j+9i9nCuPu7xpFtOuQFWTuFo43K+Bc+ow1 yOpC/DVEv3H7zA46nPnjxBJ94753SRUm3iJ5vUSiDx1WgxByZZ+SwBI6gZHtsVc5gG0B PMfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=tefNIcjomOeApRcTMFQXZ+jZa0c1eZP6VCKbu/SeChI=; b=wq0PCXmGluHTuqKmdVaGOsf3u6ZkDMUHhqLAxJ57VzoxtsFwJKcszjF3sZU1xYWMSe eviJtGb/OleAiCzqNFNQ1QBfQpVQzRR4rtjVWU4s1TNi8N2eO+/UP3OuysLyw8aRInLr F8ZHn9DPxrI63qZWKauzTCO23E4lOf0adAAG+Y7Ec93+0wc4hCv04//qX/FzxP7ZoSVd NxR6OiccIfI/3L6n5MAZKgY7aoi01+142bv3Xu5QI2CCcAqYPmEXLGw0OBZs1Hz2J3rX 0K/LlGWGg+VwXNY29xcuPOxIU35HMtStSBVxudloX1U9D5tHNiFSflPmfsdvsrVgIS7W Fzxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w25-v6si111639pga.58.2018.08.16.12.18.30; Thu, 16 Aug 2018 12:18:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403897AbeHPQgY (ORCPT + 99 others); Thu, 16 Aug 2018 12:36:24 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:36858 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391636AbeHPQgY (ORCPT ); Thu, 16 Aug 2018 12:36:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7E18080D; Thu, 16 Aug 2018 06:37:44 -0700 (PDT) Received: from queper01-lin (queper01-lin.Emea.Arm.com [10.4.13.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AFF9F3F5BC; Thu, 16 Aug 2018 06:37:41 -0700 (PDT) Date: Thu, 16 Aug 2018 14:37:40 +0100 From: Quentin Perret To: Patrick Bellasi Cc: Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Viresh Kumar , Vincent Guittot , Paul Turner , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle , Suren Baghdasaryan Subject: Re: [PATCH v3 03/14] sched/core: uclamp: add CPU's clamp groups accounting Message-ID: <20180816133737.xfwfoenbhb5wnndi@queper01-lin> References: <20180806163946.28380-1-patrick.bellasi@arm.com> <20180806163946.28380-4-patrick.bellasi@arm.com> <20180814164905.GG2605@e110439-lin> <7c45c1a8-24cb-6798-5b6f-3b5dfc9b490d@arm.com> <20180815105428.GA7388@e110439-lin> <20180816133249.GA2964@e110439-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180816133249.GA2964@e110439-lin> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > IMHO, if this is something which should not happen at all, a BUG_ON() is the > > right thing to do here. > > I don't agree on that. I agree it should not happen but since it's a > recoverable error it think we should not panic. FWIW, if this is a recoverable error, I think Linus will agree with Patrick on this one :-) https://lkml.org/lkml/2016/10/4/1