Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2626102imm; Thu, 16 Aug 2018 12:41:07 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzMywqEmzBXT2C87kK/jAItbjWIXTDfDGNaibY3H4jPR9K1zymtbRHMfM5tzsHagoPuloDj X-Received: by 2002:a63:f54c:: with SMTP id e12-v6mr29809388pgk.286.1534448467666; Thu, 16 Aug 2018 12:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534448467; cv=none; d=google.com; s=arc-20160816; b=a0FP5UhboPGUbOq/DSDnfqdPcGcpvvvjGEMGx8UdFNzD2AX794guityRF4aX/8Z/XZ KasS0UnizzwTmz5rQpV9ejKCqIB3Rb4sfGoNLyO08V8qMldgv+5NKzwQr8oAAa5U97bV zWq338mZUEwxGWGjSYfVo7FCgAKGwNoXTCfffL1WOLq68KNWY3fdSYsAGUj5l0wGLsE3 RkIrVyCt8EkJNyzitNhLMbhPwqzyxLT1Fktmb3NAxdlrE31rAHLkrTPAnLQkSCaRo0N7 ro8pnO1HFQzoUTxR3Evaq171obux/PpP2pBBSoVowlM+Elpgkb763Vo7YXtwNKdshPlq tmmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=y2s3qWJ7AJZQpkDWKK763XfizOXHIwPJC3+H1b1KXDE=; b=xUpqHEd+lw/fco0ypc/2t7muv/Z52lLVo1z7S1JzGx5nXbLc9EwUWUtJQZQMLyHXrT 7cwMTY62lytzoLGuxVXDCB0+KQh0o7ma68SgzkMTnE8SxR8xbGsClKcVH4BQ3984kR98 fLU/frO7PX7LEji930suhK8+/Mk12dptPutu7m2zGCweHiv77iyp8J90znVuNYvBC0ZO XM0Zqw8c5FefE8vsQXBiMU5LFoi+jznv5WNxOfwsDwVZbUw5ZHNLwjUzM5t4DxN5tITM JS3VQwU5kIxC5xSthu2fr9x6xHZJzDQENgshiVuDSQvRCNGuqEDx6xgf+pcjA2Ggcfl+ 2MZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d3EwBUk+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 194-v6si35875pfz.101.2018.08.16.12.40.52; Thu, 16 Aug 2018 12:41:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=d3EwBUk+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726108AbeHPWjk (ORCPT + 99 others); Thu, 16 Aug 2018 18:39:40 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:51647 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbeHPWjk (ORCPT ); Thu, 16 Aug 2018 18:39:40 -0400 Received: by mail-it0-f67.google.com with SMTP id e14-v6so7883889itf.1; Thu, 16 Aug 2018 12:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=y2s3qWJ7AJZQpkDWKK763XfizOXHIwPJC3+H1b1KXDE=; b=d3EwBUk+WMWoXBhorzcx2UNmT5cbp7jhHh76HnOP3nsv8y+SIGyjJUPzKE8bM6h8in gwaGERn5+C5zwkrNRI39VB7Vu+3plnBhJZvs5ahZAZwLbYi8fOVFE0twsVqJXnXcB72+ hnzG8fX8wHQTqApF0m0oq6lcGwLgdPgQbK8yMpxIH3wzL4g+BHjxAmpYB70XKZ+wamM3 EF8e+L4/YvjTHanVehmLSSBJcyoc5nVB70T6sVbnLISqTQGv3Sbc9/E3+fHyVlpkyNoy IKYJ1osTv3r46v+lIMHOH8EdD710o/7znSTt0BN30Sn+rbE7TEDqkfvtcK5ElemUoCUq Hcsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=y2s3qWJ7AJZQpkDWKK763XfizOXHIwPJC3+H1b1KXDE=; b=HGA9679VpUrs3UA8Z37K6Pp6v1VVOYX9DU/tciY5V2QGDSAqE4QXd84BbxBhsGv2W9 5zOodyZIPXwU0G9vs/0E1Q0IflkTkfy30zw1EpYhC8sQQKFB+pEl+DVwa7wyvVUluV6m /RUxeSPnLUPiqgoVrnewptXXGYobL3RK2fPSLVoKLiNe0iw8GruzpJlJk4PIjywlRP88 wCv77r9yH1i1VUvBHboJ2KGiPIjwouGlGVZeRmyvdKSxpjmpIzsGSlIfzNm2ma6jMNVj yMhNhvz6mF9euOSoBJc1BEHH+Hx3Y+VnYq90B7U0XjvMrCBQeIe9XqfEgMEq5L8z+MsF +jCg== X-Gm-Message-State: AOUpUlHrGHFPc5VWmV0atQIp/v/B4mjr2Wry0W/cbKsk1VzdlnEznQam kQl4nwwoosU6r7j8Q/R3odqJHwZ7DTexrMwvkDU= X-Received: by 2002:a02:9a83:: with SMTP id m3-v6mr28848068jak.116.1534448357829; Thu, 16 Aug 2018 12:39:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:5a03:0:0:0:0:0 with HTTP; Thu, 16 Aug 2018 12:39:17 -0700 (PDT) In-Reply-To: References: <20180815114107.29797-1-mikhail.jin@gmail.com> From: Michael Jin Date: Thu, 16 Aug 2018 15:39:17 -0400 Message-ID: Subject: Re: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support. To: "Ghannam, Yazen" Cc: Borislav Petkov , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 16, 2018 at 2:17 PM, Ghannam, Yazen wrote: >> -----Original Message----- >> From: Michael Jin >> Sent: Wednesday, August 15, 2018 6:41 AM >> To: Borislav Petkov ; Ghannam, Yazen >> ; Mauro Carvalho Chehab >> >> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org; Michael Jin >> ; stable@vger.kernel.org >> Subject: [PATCH V2] EDAC, amd64: Add Family 17h Model 10h support. >> >> Add support for ECC error decoding on family 17h models 10h-2fh. >> > > Can you please make this more specific? Something like "Add PCI device IDs > for Fam17h Models 10h-2Fh so that amd64_edac_mod will load". I have submitted patch v3 with a commit message that is more specific. >> case 0x17: >> + /* Check if CPU model is in range 10h-2fh */ > > This comment is not needed because it's obvious from the code. The comment in patch v2 has been removed in patch v3. Thanks, Michael