Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <CAKMK7uHrCAQpUhd2D4PpiizascLwP1kYgMM6cZv3B8OGez66Sw@mail.gmail.com>
References: <CAPM=9txqtcX42eSYjkyJLL8mmzomXRRHi7iWmW=BYgk=CAagZg@mail.gmail.com>
 <CALAqxLXt3MOc=W_gnsR=D=Um5RPsK+6sTKDbSiqro_53ZbXfQQ@mail.gmail.com>
 <CAKMK7uFb0jXVm4gGr_TR07mhT924sTORGXZVNzx4rdTe3Pj94Q@mail.gmail.com>
 <CALAqxLWq-wgbc+aS0p45rvxmPj3KicsOV5ucCB-tcKWr74uqCQ@mail.gmail.com>
 <CAKMK7uEbfa24DaDbWjxgerzH69q-niHS5==z6NqJd3Yxi0q+7A@mail.gmail.com>
 <CALAqxLVrZXRT875-AxN=jt_kSD5=Nb9SuCW4PEsVL=pQkT_ugw@mail.gmail.com> <CAKMK7uHrCAQpUhd2D4PpiizascLwP1kYgMM6cZv3B8OGez66Sw@mail.gmail.com>
From:   John Stultz <john.stultz@linaro.org>
Date:   Thu, 16 Aug 2018 15:22:05 -0700
Message-ID: <CALAqxLUf33tfMNOJMnpwGpjG7MnKBhTRmZCSGyLrXxsgs1zDqA@mail.gmail.com>
Subject: Re: [git pull] drm for 4.19-rc1
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Dave Airlie <airlied@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 16, 2018 at 3:16 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Aug 16, 2018 at 11:21 PM, John Stultz <john.stultz@linaro.org> wrote:
>> On Thu, Aug 16, 2018 at 1:46 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
>>> You happen to have set drm_fb_overalloc respectively
>>> CONFIG_DRM_FBDEV_OVERALLOC? Was added so that mali blob can pageflip,
>>> would explain what's going on at least.
>>
>> Yep. CONFIG_DRM_FBDEV_OVERALLOC is set to 200.
>
> So ->max_height is indeed the limit (or should be, minus driver bugs)
> for framebuffers. That's enforced in drm_framebuffer_create_internal
> for everything (both ioctl and should also for all internal callers),
> except the cma helpers never made sure this is correct. So I'd call
> this a bugfix.

Sure.  I'm really not sure where the max_height=2048 comes from (and
if its the real limitation or a vendor guessed value - the hikey960
driver I have uses the same), but yea, the old code wasn't checking
it.

> Now the question is whether the fbdev page-flipping actually worked on
> older kernels for you or not ...

It sure seems to work ok with the changes reverted.   Any suggestion
on how to check this?

thanks
-john