Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5B763226.1040609@huawei.com>
Date:   Fri, 17 Aug 2018 10:25:42 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
CC:     <ezequiel@collabora.com>, <rui.zhang@intel.com>,
        <edubezval@gmail.com>, <jonathanh@nvidia.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/thermal/tegra: fix a doule free devce node
References: <1533822056-33930-1-git-send-email-zhongjiang@huawei.com> <d2987e9f-5cbf-9622-c6b9-b8bc66b3a5a2@linaro.org>
In-Reply-To: <d2987e9f-5cbf-9622-c6b9-b8bc66b3a5a2@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/8/14 14:39, Daniel Lezcano wrote:
> On 09/08/2018 15:40, zhong jiang wrote:
>> Device node iterators will get the return node. Meawhile, It is
>> also put the previous device node. An explicit put will cause
>> a double put.
> What about:
>
> Subject: drivers/thermal/tegra: Fix a double free on the device node
>
> "The function 'for_each_child_of_node' iterates over the node list by
> dropping the of_node reference of the previous node.
>
> Calling of_node_put() on the iterator is pointless and leads to an
> inconsistent refcounting in addition to a double free. Remove it."
 Hi, Daniel

 Have you picked up the patch or should I repost the patch with above commit
 message that you have suggested?

 Thanks,
 zhong jiang
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
>> ---
>>  drivers/thermal/tegra/soctherm.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
>> index ed28110..3aa55c9 100644
>> --- a/drivers/thermal/tegra/soctherm.c
>> +++ b/drivers/thermal/tegra/soctherm.c
>> @@ -980,7 +980,6 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
>>  		tcd = thermal_of_cooling_device_register(np_stcc,
>>  							 (char *)name, ts,
>>  							 &throt_cooling_ops);
>> -		of_node_put(np_stcc);
>>  		if (IS_ERR_OR_NULL(tcd)) {
>>  			dev_err(dev,
>>  				"throttle-cfg: %s: failed to register cooling device\n",
>>
>