Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp418659imm; Thu, 16 Aug 2018 23:43:36 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxRMm2RmiJuJ2OhyQ60xN34IQLD36OB/heKmmEtsBZydfs7WVq6DJXA/cwg125dfRCkbQBr X-Received: by 2002:a17:902:904c:: with SMTP id w12-v6mr32463994plz.95.1534488216106; Thu, 16 Aug 2018 23:43:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534488216; cv=none; d=google.com; s=arc-20160816; b=JBsb2+7aixRNsKMK2p5xajYH7orFMJ6jxh9vI6RAeaz874rxK3e0rYDVfrJd85g1fe skp7Aj5s66chU+jQpE4eOBr4l9tVawWkfmdiXdaypJmBoN2WX/AVWOhkfxjvfWcoG3vF JfyaUrg15bYwhIWUWFQs0MBbsIRkx3b4IGKzQNv5zCLQzHIzjrfmrCrCDAmKxMdBCFX6 Vk+P9pf07iJjSbMp68W1F0j8sErtv6qdb3yYfX1kHitGGgTP06s13/lf9Cj32s7J4urC OWTsTbuR73O3J0OD+4jZlna6vsLJ0QNWkeHRMWz5k2wJmSuUmNDQNNw8l+qlq/wycLHc FB3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=gYMlBXtQhoniS3gOswgxYqPu5uw1JVnt1j376Oo5qlo=; b=KZi5rjR8NYD/y7TGxnFzkvxQ7du2oP9w6ntviSDaMM2/N4S8gXmoVh/zzxjl6XAygm mATS5CKuUdIaFKcgEU6dLu9nw/tcuNZZ+58wVaDtGBUXpH4kNQUDvLVZdxvYLy40vbsd BaNpybpXAFD4FNfY1lPvA9P5GKKP6iets3UQd2+EGXE8gSE/t2qC7mhdrqR10VKhJV/i V2uEZN8aZRFr+1en9jZgk2SrIjJXsmSrONPqBnK19TAAe5jdPWwIYDsF6Mx3EOyhQPEe btPdSJScKr11LMFMTwnRcOoZB/M07kad0cXxzu8E/uFz7Ppgkzvgp5Che+t3/8zlGTe1 dRDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z89-v6si1396336pfd.357.2018.08.16.23.43.20; Thu, 16 Aug 2018 23:43:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbeHQJnb (ORCPT + 99 others); Fri, 17 Aug 2018 05:43:31 -0400 Received: from verein.lst.de ([213.95.11.211]:33882 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbeHQJnb (ORCPT ); Fri, 17 Aug 2018 05:43:31 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id E8F0668EEE; Fri, 17 Aug 2018 08:42:22 +0200 (CEST) Date: Fri, 17 Aug 2018 08:42:22 +0200 From: Christoph Hellwig To: Eugeniy Paltsev Cc: linux-snps-arc@lists.infradead.org, Lucas Stach , Christoph Hellwig , linux-kernel@vger.kernel.org, Vineet Gupta , Alexey Brodkin , Russell King , Christian Gmeiner , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC] etnaviv: missing dma_mask Message-ID: <20180817064222.GB10811@lst.de> References: <20180814141225.6123-1-Eugeniy.Paltsev@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180814141225.6123-1-Eugeniy.Paltsev@synopsys.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 14, 2018 at 05:12:25PM +0300, Eugeniy Paltsev wrote: > Hi Lucas, Christoph, > > After switching ARC to generic dma_noncoherent cache ops > etnaviv driver start failing on dma maping functions because of > dma_mask lack. > > So I'm wondering is it valid case to have device which is > DMA capable and doesn't have dma_mask set? > > If not, then I guess something like that should work > (at least it works for ARC): This looks ok is a minimal fix: Reviewed-by: Christoph Hellwig But why doesn't this device have a dma-range property in DT?