Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180817074747eucas1p1a70969aac4238b0c8db0d8e59f4af078~LnGev9y9l2871228712eucas1p1X@eucas1p1.samsung.com>
References: <CGME20180816161825eucas1p11be9cea5d622b905154590bae90a47a4@eucas1p1.samsung.com>
 <20180816161817.12267-1-andrzej.p@samsung.com> <CAEYzJUHghs+2p4n1TesL3=VkCJcvs1TevjeFhqiQHdX+cqfqiQ@mail.gmail.com>
 <20180817074747eucas1p1a70969aac4238b0c8db0d8e59f4af078~LnGev9y9l2871228712eucas1p1X@eucas1p1.samsung.com>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Fri, 17 Aug 2018 17:14:26 +0900
Message-ID: <CAK7LNASUsZB--DWMB4hpw74OnTiz+d2jrdp+CA9L=AOdkbEmhg@mail.gmail.com>
Subject: Re: [PATCH] Revert "kbuild: create deterministic initramfs directory listings"
To:     Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Cc:     =?UTF-8?Q?Bj=C3=B8rn_Forsman?= <bjorn.forsman@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, forney@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-08-17 16:47 GMT+09:00 Andrzej Pietrasiewicz <andrzej.p@samsung.com>:
> Hi Bj=C3=B8rn,
>
> W dniu 17.08.2018 o 01:34, Bj=C3=B8rn Forsman pisze:
>> On Thu, 16 Aug 2018 at 18:18, Andrzej Pietrasiewicz
>> <andrzej.p@samsung.com> wrote:
>>>
>>> This reverts commit 9e6e0d5f2a2713402cf9dce69b9f9b516e4185d2.
>>>
>>> The reverted commit introduces broken builds. Even though the cpio arch=
ive
>>> does contain all the specified files, it seems that the kernel, while
>>> populating rootfs, scans the cpio buffer linearly and fails to create
>>> files whose parent directories are nonexistent at the moment of this fa=
iled
>>> creation. As a result, such files are not accessible when kernel boots =
into
>>> initramfs.
>>>
>
> <snip>
>
>>
>> I'm unable to reproduce it. On my system the listing is sorted so that
>> it works (parent directories appear before files). I tried to run with
>> LANG=3DC and it also sorts correctly. What is your LANG=3D? I think we
>> better add a LANG=3DC somewhere in the kernel build system, because I
>> think you have a LANG=3D that makes it sort differently. A quick fix
>> would of course be to insert it right next to sort, but there may be
>> other places that may break due to LANG=3D settings.
>>
>
> Thanks for the tip. My LANG is pl_PL.UTF-8. Indeed, prefixing the "sort"
> invocation in question with LANG=3DC does solve the problem. I don't feel
> competent enough to say whether this is the correct place for the fix,
> or if the fix should be made elsewhere. Another option is that it is the
> "sort" itself that should be fixed (or the locale, or both).
>
> Would you be able (as the author of the patch in question) to check if
> there are other locales which cause the problem?
>
> Thanks,
>
> Andrzej


I cannot add LANG=3DC to the high-level of the build system at least
since it would break the localization.


--=20
Best Regards
Masahiro Yamada