Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp540182imm; Fri, 17 Aug 2018 02:20:16 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwn8vKossidXQ++xjzsqcb96FyQrFdSSxPT6hHp1kK4MZa2uUBhmQ1b6ifs3EEAnkfob9sJ X-Received: by 2002:a17:902:7247:: with SMTP id c7-v6mr32997049pll.79.1534497616940; Fri, 17 Aug 2018 02:20:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534497616; cv=none; d=google.com; s=arc-20160816; b=b4gHpuM1ytcqXLG+WiX8mqBgBhWQ+lWW3diP5wZ8ZM9gTyvTso+oWxPP0ZtAX9X6hs 0LOZAdfuL8KdHtBE6Ovp0oWCmeztWtmOG/k+QwKiePV8iccYA2Labj+gHbtT5xu12heC OebLkQzAJ5rPr0eWXBVMBGCHnPOiyWZJGJyr/jodafrNdmCsXTHvTsWHwbtxRu7hnVl5 Md/dMZabwtUZxiRRcIApExDKwF12zX77Ng+55CIBh9OjQUYMzUlDTnpSP4xZU3DnX4Qp Kthfpb0GXWNSRAnKLNv3TzNs/VRd1I88HyDgN3BWCw8XJKDKAnfdf+vP0enWAQc+4pT7 EXuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=cSKJv8K/TtflbHf8lnz1ge/+GE9csYS1qvvpIaEYMN4=; b=CDK5D2SYk121vMOfNsK7aFBQJHGjsPHAMpgEDtBLNtwLEnoElisGRseGne/NhSe/oT VxMw/QCzxbWgvAAl4X53lKtGvKoaAlWjgeTNbA+qCOw/DhGB7toUe1h1CPIRZp8mmYkj YfmwjX9smFzg4wkUEeX691fjaTxd4dvnRBKjdO/wjZwkg5ygVDwkhmFm4ITKozZtCZee gNCHkHDYRBCqpO49xydKuw9eeTC4/llbGGvVfQbNaxQAr6HhY8NPHFkURpOlQ18jUhni ATGBpxhOCm4GDD5Bjcbrzy3evbiBgqGrSy29vnkBtRshEzSa3xff5xvrhSB/5coA6Lmo 5NrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o16-v6si1539508pgv.402.2018.08.17.02.20.01; Fri, 17 Aug 2018 02:20:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726601AbeHQMU4 (ORCPT + 99 others); Fri, 17 Aug 2018 08:20:56 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44724 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726356AbeHQMU4 (ORCPT ); Fri, 17 Aug 2018 08:20:56 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3EB047A9; Fri, 17 Aug 2018 02:18:18 -0700 (PDT) Received: from big-swifty.lan (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EECAE3F5B3; Fri, 17 Aug 2018 02:18:16 -0700 (PDT) From: Marc Zyngier To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Lina Iyer , Sudeep Holla Subject: [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources Date: Fri, 17 Aug 2018 10:18:04 +0100 Message-Id: <20180817091804.993-1-marc.zyngier@arm.com> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Although GICv3 doesn't directly offers support for wake-up interrupts and relies on external HW for this, it shouldn't prevent the driver for such HW from doing it work. Let's set the required flags on the irq_chip structures. Reported-by: Lina Iyer Signed-off-by: Marc Zyngier --- Lina, please let me know how this goes. If that fixes your issues, I'll queue it as a fix for the current cycle. drivers/irqchip/irq-gic-v3.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c index 76ea56d779a1..2d71c79bc698 100644 --- a/drivers/irqchip/irq-gic-v3.c +++ b/drivers/irqchip/irq-gic-v3.c @@ -861,7 +861,9 @@ static struct irq_chip gic_chip = { .irq_set_affinity = gic_set_affinity, .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | + IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, }; static struct irq_chip gic_eoimode1_chip = { @@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = { .irq_get_irqchip_state = gic_irq_get_irqchip_state, .irq_set_irqchip_state = gic_irq_set_irqchip_state, .irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity, - .flags = IRQCHIP_SET_TYPE_MASKED, + .flags = IRQCHIP_SET_TYPE_MASKED | + IRQCHIP_SKIP_SET_WAKE | + IRQCHIP_MASK_ON_SUSPEND, }; #define GIC_ID_NR (1U << gic_data.rdists.id_bits) -- 2.18.0