Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp555991imm; Fri, 17 Aug 2018 02:40:55 -0700 (PDT) X-Google-Smtp-Source: AA+uWPx1JhAqbiRLqe4mDQZ1zDJUL+HwURWcmmSxk43XDr+UGRfZL/BOSkO/Cnx328iLp3ei1SEX X-Received: by 2002:a63:df04:: with SMTP id u4-v6mr32156461pgg.434.1534498855301; Fri, 17 Aug 2018 02:40:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534498855; cv=none; d=google.com; s=arc-20160816; b=HZT4OObzu4nChU+ocYU8ZBMxcMqtlGtb4kqfu8CdqEjKsJ7Wha/YMh+xVpvWTrUY7Y fPgGiRXVF1X/9OojElCCMjdjpWZJaH0LNWpdXgmnefVI2RsZSjhggZ63XsOUNf155a/n 9L8tMnaSFjYT47xdoBI4P1bXjWrKwFz8a9e8JM8mcKaC5FevUFqoaV36ED/4E42t8Z/Q hKW6xPmX9oUL51AB6gRRasm4MMmPG+DP9uknVxwwxClvlaKqsJPw711RboNdwxCB4Z7n n/NqSGF/7Qe1U4PsH6ISL/nhd4Myhn/HpKGH2UkJ1P+Zep8mNPt8hh34Z1ILKXGG5FSM 9/2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=hsxxz6Ksia2dYf1XZdTVMJ/P9Fr0hUVH3cG+nxaSZPE=; b=AudKTOTa0kN6NWW5dbNuQ/I9RC3OUV5Cd/Y/q+jZhtYRrCZw5mudiehu+AFyu4sh6b 66PP5bllGYDHuHHxwx1IK3srp3n2HbdWUv/BrZdQ7GU6wTmS1RT9p/OvEHK2i2S5incL CxSfHGePsgHQiK1jY/qT3sZ3sZgiqrkX3D+ZQqjBoGIKGHEkUyaM139pe+V7mxY1n2Os AKSITH8N0ZnTq7jmmd964423LvbtPZUAMZfq6Q8JT8lXE8xZGZ0p36unAdvtiYnX+7iH NXPh2u7t7B/Lp3bmed+MMGn04l3QQtkHFgCA1IDyInmpq3twfEZ5Fe6TdGLYAmHiIwCH XqAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u23-v6si1825791pgl.37.2018.08.17.02.40.40; Fri, 17 Aug 2018 02:40:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbeHQMlW (ORCPT + 99 others); Fri, 17 Aug 2018 08:41:22 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:60700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726370AbeHQMlW (ORCPT ); Fri, 17 Aug 2018 08:41:22 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 239FF26A40; Fri, 17 Aug 2018 09:38:39 +0000 (UTC) Received: from gondolin (dhcp-192-222.str.redhat.com [10.33.192.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3B7E2156712; Fri, 17 Aug 2018 09:38:33 +0000 (UTC) Date: Fri, 17 Aug 2018 11:38:30 +0200 From: Cornelia Huck To: Tony Krowiak Cc: Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com Subject: Re: [PATCH v9 18/22] s390: vfio-ap: implement VFIO_DEVICE_RESET ioctl Message-ID: <20180817113830.250a4285.cohuck@redhat.com> In-Reply-To: <4bcf1214-1978-aa11-ca22-7ab4352dacfb@linux.ibm.com> References: <1534196899-16987-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1534196899-16987-19-git-send-email-akrowiak@linux.vnet.ibm.com> <20180815183835.66470bc6.cohuck@redhat.com> <4bcf1214-1978-aa11-ca22-7ab4352dacfb@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 17 Aug 2018 09:38:39 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 17 Aug 2018 09:38:39 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Aug 2018 17:05:48 -0400 Tony Krowiak wrote: > On 08/15/2018 12:38 PM, Cornelia Huck wrote: > > On Mon, 13 Aug 2018 17:48:15 -0400 > > Tony Krowiak wrote: > >> + case VFIO_DEVICE_RESET: > >> + ret = vfio_ap_mdev_reset_queues(mdev, true); > > If I see it correctly, you call this function only ever with force == > > true (here and in the previous patch). Is that what you intended? > > That does seem to be the case now; however, I think at one time there were > additional calls to this function. For some reason of which I am not aware, > those were removed, so there is probably no need for it now. If you don't see a need for it anymore, I'd just remove the parameter. Even makes vfio_ap_mdev_reset_queues() a bit nicer :)