Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 33FE561C74
To:     Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>
From:   Mukesh Ojha <mojha@codeaurora.org>
Subject: Query on shrink list
Message-ID: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
Date:   Fri, 17 Aug 2018 15:39:22 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Al Viro,

Is there is reason we have kept data->found++, if the dentry already 
there in shrink list ?

static enum d_walk_ret select_collect(
...
         if (dentry->d_flags & DCACHE_SHRINK_LIST) {
                 data->found++;
         } else {
   ..

If the dentry is already there on shrink list, does it not mean that 
data->found is already non-zero ?
Can't we just go out from here directly?


Regards,
Mukesh