Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5B76BDD8.9040203@huawei.com>
Date:   Fri, 17 Aug 2018 20:21:44 +0800
From:   zhong jiang <zhongjiang@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     <mchehab@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: NULL check is meaningless before debugfs_remove_recursive
References: <1534477046-13795-1-git-send-email-zhongjiang@huawei.com> <1783681.noYBAFkPT2@avalon>
In-Reply-To: <1783681.noYBAFkPT2@avalon>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/8/17 17:18, Laurent Pinchart wrote:
> Hi Zhong,
>
> Thank you for the patch.
>
> On Friday, 17 August 2018 06:37:26 EEST zhong jiang wrote:
>> debugfs_remove_recursive has taken null pointer into account. so
>> remove the unneeded check.
>>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> I already have a similar patch in my tree (git://linuxtv.org/pinchartl/
> media.git uvc/next) and will include it in my pull request for v4.20.
  Thank you for let me know that. Maybe I miss that.

 Sincerely,
 zhong jiang
>> ---
>>  drivers/media/usb/uvc/uvc_debugfs.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/usb/uvc/uvc_debugfs.c
>> b/drivers/media/usb/uvc/uvc_debugfs.c index 368f8f8..6995aeb 100644
>> --- a/drivers/media/usb/uvc/uvc_debugfs.c
>> +++ b/drivers/media/usb/uvc/uvc_debugfs.c
>> @@ -128,6 +128,5 @@ void uvc_debugfs_init(void)
>>
>>  void uvc_debugfs_cleanup(void)
>>  {
>> -	if (uvc_debugfs_root_dir != NULL)
>> -		debugfs_remove_recursive(uvc_debugfs_root_dir);
>> +	debugfs_remove_recursive(uvc_debugfs_root_dir);
>>  }