Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org BF3A1622CE
Subject: Re: Query on shrink list
To:     Al Viro <viro@ZenIV.linux.org.uk>
Cc:     linux-fsdevel@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
References: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
 <20180817125812.GC6515@ZenIV.linux.org.uk>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <b638d027-023a-d455-f77e-d66c10b8d9e4@codeaurora.org>
Date:   Fri, 17 Aug 2018 20:07:59 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180817125812.GC6515@ZenIV.linux.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 8/17/2018 6:28 PM, Al Viro wrote:
> On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
>> Hi Al Viro,
>>
>> Is there is reason we have kept data->found++, if the dentry already there
>> in shrink list ?
>>
>> static enum d_walk_ret select_collect(
>> ...
>>          if (dentry->d_flags & DCACHE_SHRINK_LIST) {
>>                  data->found++;
>>          } else {
>>    ..
>>
>> If the dentry is already there on shrink list, does it not mean that
>> data->found is already non-zero ?
> Nope.  It can be on *another* shrink list - if two processes are doing
> that...

Ok, if we go out simply,  letting others to do the job will break 
`shrink_dcache_parent()`
and if someone touched that dentry made the refcount > 0 while it is on 
shrink list
  then owner will keep on looping in shrink_dentry_list() until refcount 
becomes 0 .

Am i making sense here ?

Thanks.
Mukesh

>
>> Can't we just go out from here directly?