Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp969854imm; Fri, 17 Aug 2018 09:34:36 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxqRdf07iL6ETVlgJzdOZyEW7I51YBhQnwOuZJx/qXy5tChnDopXhEKLu7bJm3gC7EOjAkE X-Received: by 2002:a63:e116:: with SMTP id z22-v6mr32494700pgh.89.1534523676761; Fri, 17 Aug 2018 09:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534523676; cv=none; d=google.com; s=arc-20160816; b=Y50OTDLdUaxZq8SOyCiL596Mnw7KyWfoxs9HXUMeXdmCbns1dufPdwEtJEk+OV+h2w 5GQViMM5LhwqU7I5ox//iyn+OVMFLXG+KQ9Y9iHBMvxxHoWbJd4rVbNt/dzIQD8igNy9 ZI0+Wwm1wNgH1dUHbRUe6hVfz4PEGbtMWuMokYDwx3ZSnYcqohqBCdEaN1L00OhgKUK9 v5cBz1Gd6JSrRxY+W12ewx4GOHWdNA2k/ZgY96cNTcnSxH1Xj0juUhnePv04HNkPEkrZ rqfsMREeljxYGZSkAlwBaoXoLvIimvENow0uGzENGR+x6DcUYhRrScG1SNCL/BTrXgg1 IMAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=fZw2X/38ghpsGK069mXTDTlh8k6bvpsaz6gPRmD2hm8=; b=cVLsnCq5lfuplKiwqorR3Ecf8TCih+A5qKNoMDsVgotAWarui4ttUnSAsaGY/iRu+3 1Q0H1t/8ngDnr7Pw2Y8CS4tdGuPehYvQTDlHcn5BhNvEUQuuxeRZY46uaPcxOusXcKgy zh/IKsY27uNZzeoT96LEby+5v16zbITnTKYpojx8o3r2r2RDyUKRqDFO/J2/WVhuciD4 GEtyjY3sbzGk/r0564mikwLsmatoQKmzxdTxdU+jqP25y21m4LtDU9vkENjUc7Gxm5Fm u91v91qaH9M5lcXglYoDzxoicmkyihAL42cMLjb+NqQUy9H71/bE+tgGrONm+15208Dz ZnbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ettus-com.20150623.gappssmtp.com header.s=20150623 header.b=cTV3QAfZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si2305945pgp.551.2018.08.17.09.34.21; Fri, 17 Aug 2018 09:34:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ettus-com.20150623.gappssmtp.com header.s=20150623 header.b=cTV3QAfZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727828AbeHQTf6 (ORCPT + 99 others); Fri, 17 Aug 2018 15:35:58 -0400 Received: from mail-yb0-f194.google.com ([209.85.213.194]:38204 "EHLO mail-yb0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727801AbeHQTf5 (ORCPT ); Fri, 17 Aug 2018 15:35:57 -0400 Received: by mail-yb0-f194.google.com with SMTP id c1-v6so482625ybq.5 for ; Fri, 17 Aug 2018 09:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ettus-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fZw2X/38ghpsGK069mXTDTlh8k6bvpsaz6gPRmD2hm8=; b=cTV3QAfZreykf6FPe9iXvfG/yGk05Q5TgLO2mPrSle/XsEjj8IRuYpt6YHc3C7kNTS dr2kCcPqztl20uP2JlEblsSce/is9J8e5or0n0cASBEFa/DMK5/mASx0aS15y1UH6W4S pUUdoQaIWcmTg9Mb5Fh4eXXVUoZ6l2VvTH7L87f3Q+tPJohbRUJoRhKnXahi0twY3V+t XlzRD6z76FUmBgA/CXjPX3b0b6pC3LXOQDI6cS9zwasgyEk3da48PjY75CtAml8FsAvk CKRiX6poqOMtW2fNroHpXgEfwdDmU08F/aTEoQYlmo0jbmcRmliheE1PbiZsZnTUHgty j0mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fZw2X/38ghpsGK069mXTDTlh8k6bvpsaz6gPRmD2hm8=; b=S+TjL9ySp09aeUXLcEvHTBLSuNoHgTNtAJRjBobue9M/fzjJxtwbdDf7MINVHZxM7w et+EuA2ijNTQSZ3BfNiKxCldhinhKzunhdcRyI9mys4CWtYMK0D/zpo7kjr7MHP5Ac91 cO3ZrZkiiiLX5NaOSqJ2e181Kiv9lda4xqymTJf9EMs/FLkwA4FJY7pLGQjotEDUUxLb b0WNlMS9VD+PNirqYKnj2oDLrbveGh0jBc62/OJo8mybVmcgkZI2Rg7cDO8NOw2As5mi vIUetoet9FXqBaO+qClw/rpeAwlY8OorsrVS3Q8GJhF7guu2gVXJCTbqE1mJADrE8VuR /RMA== X-Gm-Message-State: AOUpUlFWs5zR6yFNEZYcIcoNhUXcx462fK81RdoR8H8PPgzIvzzaBTlu i4zWqz3FJUMIljnlq67mXtCXGHGwh4tHMdR/pPJM9w== X-Received: by 2002:a25:2548:: with SMTP id l69-v6mr19296572ybl.230.1534523515821; Fri, 17 Aug 2018 09:31:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:3c0a:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 09:31:55 -0700 (PDT) In-Reply-To: <1534403190-28523-8-git-send-email-jliang@xilinx.com> References: <1534403190-28523-1-git-send-email-jliang@xilinx.com> <1534403190-28523-8-git-send-email-jliang@xilinx.com> From: Moritz Fischer Date: Fri, 17 Aug 2018 09:31:55 -0700 Message-ID: Subject: Re: [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding To: Wendy Liang Cc: ohad@wizery.com, bjorn.andersson@linaro.org, Michal Simek , Rob Herring , Mark Rutland , rajan.vaja@xilinx.com, jollys@xilinx.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel , Devicetree List , Linux Kernel Mailing List , Wendy Liang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wendy, couple of minor stuff inline. On Thu, Aug 16, 2018 at 12:06 AM, Wendy Liang wrote: > Add device tree binding for Xilinx Cortex-r5 remoteproc. > > Signed-off-by: Wendy Liang > --- > .../remoteproc/xlnx,zynqmp-r5-remoteproc.txt | 81 ++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt > > diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt > new file mode 100644 > index 0000000..3940019 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt > @@ -0,0 +1,81 @@ > +Xilinx ARM Cortex A53-R5 remoteproc driver > +========================================== > + > +ZynqMP family of devices use two Cortex R5 processors to help with various > +low power / real time tasks. The ZynqMP family [..] uses [..] > + > +This driver requires specific ZynqMP hardware design. *a* specific ZynqMP hardware design. What does that mean? > + > +ZynqMP R5 RemoteProc Device Node: > +================================= > +A zynqmp_r5_remoteproc device node is used to represent a R5 IP instance > +within ZynqMP SoC. > + > +Required properties: > +-------------------- > + - compatible : Should be "xlnx,zynqmp-r5-remoteproc-1.0" > + - reg : Address and length of the register set for the device. It > + contains in the same order as described reg-names ? > + - reg-names: Contain the register set names. Contains > + "tcm_a" and "tcm_b" for TCM memories. > + If the user uses the remoteproc driver with the RPMsg kernel > + driver,"ipi" for the IPI register used to communicate with RPU > + is also required. > + Otherwise, if user only uses the remoteproc driver to boot RPU > + firmware, "ipi" is not required. > + - tcm-pnode-id: TCM resources power nodes IDs which are used to request TCM > + resources for the remoteproc driver to access. > + - rpu-pnode-id : RPU power node id which is used by the remoteproc driver > + to start RPU or shut it down. > + > +Optional properties: > +-------------------- > + - core_conf : R5 core configuration (valid string - split0 or split1 or > + lock-step), default is lock-step. > + - memory-region: memories regions for RPU executable and DMA memory. > + - interrupts : Interrupt mapping for remoteproc IPI. It is required if the > + user uses the remoteproc driver with the RPMsg kernel driver. > + - interrupt-parent : Phandle for the interrupt controller. It is required if > + the user uses the remoteproc driver with the RPMsg kernel > + kernel driver. > + > +Example: > +-------- > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + rproc_0_fw_reserved: rproc@3ed000000 { > + compatible = "rproc-prog-memory"; > + no-map; > + reg = <0x0 0x3ed00000 0x0 0x40000>; > + }; > + rproc_0_dma_reserved: rproc@3ed400000 { > + compatible = "shared-dma-pool"; > + no-map; > + reg = <0x0 0x3ed40000 0x0 0x80000>; > + }; > + }; > + > + firmware { > + zynqmp_firmware: zynqmp-firmware { > + compatible = "xlnx,zynqmp-firmware"; > + method = "smc"; > + }; > + }; > + > + zynqmp-r5-remoteproc@0 { > + compatible = "xlnx,zynqmp-r5-remoteproc-1.0"; > + reg = <0x0 0xFFE00000 0x0 0x10000>, > + <0x0 0xFFE20000 0x0 0x10000>, > + <0x0 0xff340000 0x0 0x100>; > + reg-names = "tcm_a", "tcm_b", "ipi"; > + dma-ranges; > + core_conf = "split0"; > + memory-region = <&rproc_0_fw_reserved>, > + <&rproc_0_dma_reserved>; > + tcm-pnode-id = <0xf>, <0x10>; > + rpu-pnode-id = <0x7>; > + interrupt-parent = <&gic>; > + interrupts = <0 29 4>; > + } ; > -- > 2.7.4 > Cheers, Moritz