Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1152372imm; Fri, 17 Aug 2018 12:48:41 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw6cwrHx44ObeevG6qV1aytNACCuZLYV7MpoIILkC+hSHhHC+ErYr7vQBCLsQfgDYqtK2kN X-Received: by 2002:a63:6cc8:: with SMTP id h191-v6mr33962235pgc.359.1534535321391; Fri, 17 Aug 2018 12:48:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534535321; cv=none; d=google.com; s=arc-20160816; b=UYSLAV8mzQboA0xPJYNS/KSy55BzK8t8ot9cpv3//KYNUZOvBl4hpCPY9T9nZzyNlX xDWXQ8fuLevcfafPeQfT960OnXlqQZA2vIVfFcKlc/C0i0R1pR1zyW3kIdMXHXoalhoh rJGV07QqFRE2Ce/SSw20b6/LcR4iXT3MgXUDD9XdFKotdVs+NVnqXo5PnKkihvCMlXNV XnCYbizKrsR8EcDJhQwTFtDhIEZYp1mrXEPVp59PqargdASXs/db4vn8AQ4ft1zrD3n4 /VZkGcJ8axQJVrQiKwjtvGR2wkso3O6ehjdVyWMXPkSmeMSzpKMFTHzesKJSC/ZXVccQ LSOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=I3pTPwAky6Zixjl/K2wclkbevMBaqbcRehCgcFojhGE=; b=z64KTloUEzkrldaGqzAzYQhC2y0CKWj/Rvb8atFjvfRVeIge2aRW1otTg8WT2maaos BgW4zslO8jek5g+pHZ5Uld3hcn3WcvSL5ULEMl54hw7eYX/jsuz9DBWXqUMpmuSXgle5 /YdZqiBF03vQ916NkLuR2Mq0K5IKEffG2dhx27mLGIIWrDhCWMsT7UerhOTGYiw/pxhz Kl5bnuSllvEyIGasaQw+nZ/tCAcVwtvGa8ksfXAgUPTRV1pQzUcPhstm8h4kCDULKIVC 7FhR0fae2KPuuJLfE0yTwocBgEKk0jECRYcle/pDnZR1mJa9wwpL14I18EJDbtZXee4r GMLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MJCdAVxe; dkim=pass header.i=@codeaurora.org header.s=default header.b=MJCdAVxe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7-v6si2736791pgc.233.2018.08.17.12.48.25; Fri, 17 Aug 2018 12:48:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=MJCdAVxe; dkim=pass header.i=@codeaurora.org header.s=default header.b=MJCdAVxe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbeHQWwD (ORCPT + 99 others); Fri, 17 Aug 2018 18:52:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:52170 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725860AbeHQWwC (ORCPT ); Fri, 17 Aug 2018 18:52:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8DF8862439; Fri, 17 Aug 2018 19:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534535241; bh=SKrvxg4aeSoDcQlGWd/+NVapSJY6pEO72FC5QFRmp8E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MJCdAVxe98fxQpdKP6nnqsPrZ+QVbkOXwwGUlj2rYy1hzFez1it/HgtiRALgZ2yY+ 1MVvK46JIq2Fbx9gLUoZQsPXrkohPP6LH3wNViMjDXZ6bVB/uNq+WeXJ+ZSd042lGY pqOn+Yy5Fy8dmiNhHJe6/1g3CbIIJw4I5vVDHhqM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.86.119] (cpe-76-176-58-9.san.res.rr.com [76.176.58.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tsoni@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 359B362433; Fri, 17 Aug 2018 19:47:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534535241; bh=SKrvxg4aeSoDcQlGWd/+NVapSJY6pEO72FC5QFRmp8E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MJCdAVxe98fxQpdKP6nnqsPrZ+QVbkOXwwGUlj2rYy1hzFez1it/HgtiRALgZ2yY+ 1MVvK46JIq2Fbx9gLUoZQsPXrkohPP6LH3wNViMjDXZ6bVB/uNq+WeXJ+ZSd042lGY pqOn+Yy5Fy8dmiNhHJe6/1g3CbIIJw4I5vVDHhqM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 359B362433 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tsoni@codeaurora.org Subject: Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver To: Prakruthi Deepak Heragu , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, rnayak@codeaurora.org, Satya Durga Srinivasu Prabhala References: <1534464348-8227-1-git-send-email-pheragu@codeaurora.org> <1534464348-8227-3-git-send-email-pheragu@codeaurora.org> From: Trilok Soni Message-ID: <589f8341-580b-d1d0-5efd-261d8d4821b0@codeaurora.org> Date: Fri, 17 Aug 2018 12:47:18 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1534464348-8227-3-git-send-email-pheragu@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Prakruthi, On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote: > + > +#define EUD_INT_VBUS BIT(2) > +#define EUD_INT_CHGR BIT(3) > +#define EUD_INT_SAFE_MODE BIT(4) > + > +#define EUD_NR 1 I don't see any use of EUD_NR in the driver below. Do we need it?