Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1874303imm; Sat, 18 Aug 2018 06:18:12 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyR3F8WpcWKXb60ckE2oEJJaFhnakO0ppF8wgXg1EkyvoQ6xwoTj3CECp03wEdESnpryKxe X-Received: by 2002:a17:902:b609:: with SMTP id b9-v6mr14736758pls.321.1534598292822; Sat, 18 Aug 2018 06:18:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534598292; cv=none; d=google.com; s=arc-20160816; b=euGQ8X45PXActcU3W7wC8FC4EfdrPtO/fCL0HlEis/Ks7TLNALG+AdyEc5Sf9v/IaK FibBIQS0wAcN9lePh1ESh7mnn296mwe+N0U86LEYyGlGd7S5/dfeGPO+UmOU+FIBxtdk yXWWKQz9gLCkp7Sy63WaKC3ETpKVc+Wk8r8p75HoJ51qkeVfBZL9Xbyf8Uk21VS+5iQR o3+qfsVlH3mPefdpkp23P8SS0EGzG8VJFOSjIeODLxiKZiwY8NMy1hVwWrxsl6iIiZUO 5wsggB2nhbA1x2Ph+240vbMoFl0PrIxZ5LN0uE9Srl8LJ29YAU4UzfgYgVKdWVf1kzAw 6E6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=D7oXOxxmQ9KS+RC9cc76gsLhDweYQpKJU+2dWhr84Tk=; b=Gmk593uADBRc7A6HzXyA7IPW/kLuv/p+WCnMlSffqKIsmB/+Fh5Nsyj36TOu/W8znI d/SII9ldIbYjvQGKMpIOjy041nd8t1xyDfDcVRvfu1lgm/buEih8gm5T29CDNBc4oJXc M5OlbXWQacWGvJ/a+H1ELx/wVMo70WYx8/pkU63Filh8WYqL+nC3ZlfhL0MP/vQ5XfGb iW1QJ2ekqvz3nbNu2RnX0pJP3MnK1iFZUPpL3kQ40O+wbdpKh1BQwXzp+V7/DwhdMHy9 Df+ou/s0d0+FnwwGSqUjqH7M0LBLaeY6bJiypoB6Nw9oIKOu0Ys0aSMIDOWkwbMFU1MV +NdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=Xm0fv4r0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v12-v6si4848823plz.419.2018.08.18.06.17.57; Sat, 18 Aug 2018 06:18:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=Xm0fv4r0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726496AbeHRQYQ (ORCPT + 99 others); Sat, 18 Aug 2018 12:24:16 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:39255 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbeHRQYP (ORCPT ); Sat, 18 Aug 2018 12:24:15 -0400 Received: by mail-ed1-f68.google.com with SMTP id h4-v6so5975151edi.6 for ; Sat, 18 Aug 2018 06:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=D7oXOxxmQ9KS+RC9cc76gsLhDweYQpKJU+2dWhr84Tk=; b=Xm0fv4r0OjBDk4CDWcCcC4kadgGs0r/iPRUy3MzRjPpY3bfHqD4Ru17J+6FOWgtGAQ M4T2rveCoL9j8MlcnMvMXZB//Gus2ZH9z/5y9tOZEOx8XIe+A+rQgeQPx//MjIy2XY+O eUNYmk6sUBadB364CIy18D3PjvO2niTfQyKDk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=D7oXOxxmQ9KS+RC9cc76gsLhDweYQpKJU+2dWhr84Tk=; b=keoSvigJ7E0i3dz6YGaqz88GCFh7rGOZioVgFvNeYjVlruXItEb8Qhh9bFbTcaH45K mc407Ns0JwhVmppeuz8adKVqy9zu7IZaKzmBJ5GY38E7V4UHyxqoWThnamlY4kHbEJl5 wxzVBZrK14mzjf1eCE35sc600o6HOcgT6oZfrhB+Esvcv2Z5kPTrH8LZrBysev2LXkcN 0hKQkttcOErlGElZJK5MRKzrnxSLKMWNPvyLJlZ6zg1OSy6ZHPHPVOWgqExKgTlq7F8k xAV9k6oGPDuUL67UlsNkenmwyep58NCzC4gc/mYw3uljepNkjWurQC9lPOLANeoq+YlW VvLQ== X-Gm-Message-State: AOUpUlFoRh5QMBNLPtHJ6DFCSySoaKhbQDV7vw3a6mudIIV+P/du89mH GV3eRSQocBX3o/levKhNYqdl3w== X-Received: by 2002:a50:976d:: with SMTP id d42-v6mr47306928edb.153.1534598193256; Sat, 18 Aug 2018 06:16:33 -0700 (PDT) Received: from prevas-ravi.waoo.dk (dhcp-5-186-114-212.cgn.ip.fibianet.dk. [5.186.114.212]) by smtp.gmail.com with ESMTPSA id r11-v6sm2821403edp.60.2018.08.18.06.16.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Aug 2018 06:16:32 -0700 (PDT) From: Rasmus Villemoes To: Andrew Morton , Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 5/7] linux/bitmap.h: relax comment on compile-time constant nbits Date: Sat, 18 Aug 2018 15:16:21 +0200 Message-Id: <20180818131623.8755-6-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20180818131623.8755-1-linux@rasmusvillemoes.dk> References: <20180818131623.8755-1-linux@rasmusvillemoes.dk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's not clear what's so horrible about emitting a function call to handle a run-time sized bitmap. Moreover, gcc also emits a function call for a compile-time-constant-but-huge nbits, so the comment isn't even accurate. Signed-off-by: Rasmus Villemoes --- include/linux/bitmap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h index e34c361f4a92..3f0cac3aedca 100644 --- a/include/linux/bitmap.h +++ b/include/linux/bitmap.h @@ -28,8 +28,8 @@ * The available bitmap operations and their rough meaning in the * case that the bitmap is a single unsigned long are thus: * - * Note that nbits should be always a compile time evaluable constant. - * Otherwise many inlines will generate horrible code. + * The generated code is more efficient when nbits is known at + * compile-time and at most BITS_PER_LONG. * * :: * -- 2.16.4