Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     zhong jiang <zhongjiang@huawei.com>
Cc:     tomi.valkeinen@ti.com, airlied@linux.ie, sre@kernel.org,
        afd@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpu: Use ERR_CAST to replace ERR_PTR(PTR_ERR())
Date:   Sun, 19 Aug 2018 13:49:24 +0300
Message-ID: <1568006.WDkDHT9mlz@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <1534589832-65325-1-git-send-email-zhongjiang@huawei.com>
References: <1534589832-65325-1-git-send-email-zhongjiang@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Zhong Jiang,

Thank you for the patch.

On Saturday, 18 August 2018 13:57:12 EEST zhong jiang wrote:
> We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
> replace it.
> 
> The issue is detected with the help of Coccinelle
> 
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
> b/drivers/gpu/drm/omapdrm/dss/dss.c index cb80dda..1fc46b2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -956,7 +956,7 @@ struct dss_debugfs_entry *
>  				&dss_debug_fops);
>  	if (IS_ERR(d)) {
>  		kfree(entry);
> -		return ERR_PTR(PTR_ERR(d));
> +		return ERR_CAST(d);
>  	}
> 
>  	entry->dentry = d;

-- 
Regards,

Laurent Pinchart