Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3024224imm; Sun, 19 Aug 2018 10:17:08 -0700 (PDT) X-Google-Smtp-Source: AA+uWPxgHKBYZ+nYxKFv6w4ldvg0oHE9NjVwGSo2hBMxtKFkRoP/qSxz+3FLA1Z5nbow/Q2tP/dl X-Received: by 2002:a17:902:aa8f:: with SMTP id d15-v6mr42318107plr.64.1534699028783; Sun, 19 Aug 2018 10:17:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534699028; cv=none; d=google.com; s=arc-20160816; b=QJLcGGu5AOsWsqQhePQmBT8w6M0OXAl4yusUe+vn4l2e/BWnEAwiaYnIKwVYtWHtIT AbIPoHgvv7PO0BfoyGzfWgANkOtTzQ4JaHNO3rxhPzTDbl2/M1AzMIWPwpnbCC6xD0Nq dFYn2glidBogg0X0VfX/QTdo3b+ZnHbI+6KNVlezPRSkzZQext/kfyb3q83MMdYZwool zpu9MtB2KRO6FFAQfOo9R2VizxSpr5XjFhTsaX3KCrDPQOYg3z5r8wNcOBGDDEhHLqRP YrG4HThkCf6vHdqNvW6Cbf36gJQ0qAX2JuApsC9SfmZy5CpFR22YbwRs77e08FY/2TlX U98g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=VmrvWYiUFkMCzOJi7nQ/FQo6K9zp5CZ5wTSajE51i74=; b=x0oq2H/DsIxdC/XImWZNWL0QYERbVALdjluM9gkAdpPS1VdvOiSvO8y63DPYcJFYcn XZLxBACK/mzhXdkaRktbwuYJbbcFG1CTBL6YggIHbcSUaSwd0XjzyXog7ZCW4ObnQjCh YPj0LKuW4rO/A/uEfaW/cxqyuHzW3yn+sX06tEQarsjhGwgJ77MTCmGE9ALiOF+X7jXj IqhiSx9WksXQ+zo73jE63olk5foataxZQxz0bJ/+nq6gaD1PX6gqcHGEYxJkUGsVTqUf /5KmULN/5tXey+fKSHS7HJXlm8kMVU7QIPyiMBrX6PVWy/rev8jw2UP2mJy7tEtuxaeK +kdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Btig/yxz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 7-v6si3480239pgz.153.2018.08.19.10.16.53; Sun, 19 Aug 2018 10:17:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Btig/yxz"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbeHSUWa (ORCPT + 99 others); Sun, 19 Aug 2018 16:22:30 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:32916 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbeHSUWa (ORCPT ); Sun, 19 Aug 2018 16:22:30 -0400 Received: by mail-pg1-f195.google.com with SMTP id r64-v6so4472330pgr.0; Sun, 19 Aug 2018 10:10:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VmrvWYiUFkMCzOJi7nQ/FQo6K9zp5CZ5wTSajE51i74=; b=Btig/yxz1BPVHpDVoo9TK/dsJhHv49523olzNc6gBnipobpTvb1rbYtYRPsRsRXUfY 4ypUmr7++DeUMGJdGiz6b5x+3uz36NoCRO/BY+x/WKS4i2C21gAugW7Vl5f/cP2NRfSm PFsGdbK/ORvaL52xsJ/f5N0ayefsGvP5rZ33ysL7zrOvx7ANG/9/5GvbkyPe0WLzJ57n 2H4qBXe8JEhrqmwOLc7sI7yagxTo0oqEBCf/XOSpf/e9aTUt9UsPuixniWY2jzvLsu9k gqkHKMhIZ9gwPZEnkEF0arQ1JauzjXXWGnxPHd2P1g8wQzUCowUfnsxzrQY+bMPW1Bie 9g2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VmrvWYiUFkMCzOJi7nQ/FQo6K9zp5CZ5wTSajE51i74=; b=DQU1OEB0T0G6z0Z+Tjp7QNOt9v0OTrqZy9Gu29YUhhiLpuuop/6oE85fVmn30IlTcK 6FlAWgYscWz+uMk2bGhxXE1+1h5p3B47oiVijbG6vfRj/UuYoiVBBaL7+WUKI5uyNyFz uS9fBv1yi64Wp9v0jPyS+hQ/Khnk7F41+MW/ZW673l79N3SGPypXs0u4ch2NO2lfppPk 5zrMIQX+NOjcYh4Ga+Epwjyqvz8lTkTfWh+E0Bcd+u2oeEPyGo/kdSMfd95N/FqEcfaI bFdifnUxkEwZLxVZnj3fhyNlY4rNV2ROqqN7IKauuEOOFdV3vBl2b4UNAap+FxQvSfze 9tZQ== X-Gm-Message-State: AOUpUlHNDz3MZqMP/K4DC3fYkvFU0ms8rg5fK3iaIDxitdWqXEiyzQO2 THrIlHdH2pX/VJblfnLhH+NCOIBFAl8= X-Received: by 2002:a62:c218:: with SMTP id l24-v6mr44973303pfg.185.1534698622018; Sun, 19 Aug 2018 10:10:22 -0700 (PDT) Received: from himanshu-Vostro-3559 ([103.233.116.134]) by smtp.gmail.com with ESMTPSA id l84-v6sm13361705pfg.3.2018.08.19.10.10.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 Aug 2018 10:10:21 -0700 (PDT) Date: Sun, 19 Aug 2018 22:40:14 +0530 From: Himanshu Jha To: Jonathan Cameron Cc: dpfrey@gmail.com, daniel.baluta@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: chemical: bme680: Add check for val2 in the write_raw function Message-ID: <20180819171014.GA13175@himanshu-Vostro-3559> References: <20180811102636.6171-1-himanshujha199640@gmail.com> <20180819172514.370d34fb@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180819172514.370d34fb@archlinux> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 19, 2018 at 05:25:14PM +0100, Jonathan Cameron wrote: > On Sat, 11 Aug 2018 15:56:36 +0530 > Himanshu Jha wrote: > > > val2 is responsible for the floating part of the number to be > > written to the device. We don't need the floating part > > while writing the oversampling ratio for BME680 since the > > available oversampling ratios are pure natural numbers. > > > > So, add a sanity check to make sure val2 is 0. > > > > Signed-off-by: Himanshu Jha > > As discussed in David's patch series v3, I think this is still relevant > but now needs an update to cover the new code. I already had informed David to reabse his series on top of my patch and he rebased this patch series. So, it should apply cleanly without any further effort. If it doesn't, then ping me. -- Himanshu Jha Undergraduate Student Department of Electronics & Communication Guru Tegh Bahadur Institute of Technology