Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 19 Aug 2018 11:01:43 -0700 (PDT)
Message-Id: <20180819.110143.87031394726154238.davem@davemloft.net>
To:     jian-hong@endlessm.com
Cc:     hkallweit1@gmail.com, nic_swsd@realtek.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux@endlessm.com
Subject: Re: [PATCH v2 net] r8169: don't use MSI-X on RTL8106e
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20180817050735.3367-1-jian-hong@endlessm.com>
References: <20180815062110.16155-1-jian-hong@endlessm.com>
        <20180817050735.3367-1-jian-hong@endlessm.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jian-Hong Pan <jian-hong@endlessm.com>
Date: Fri, 17 Aug 2018 13:07:35 +0800

> Found the ethernet network on ASUS X441UAR doesn't come back on resume
> from suspend when using MSI-X.  The chip is RTL8106e - version 39.
 ...
> Here is the ethernet controller in detail:
 ...
> Falling back to MSI fixes the issue.
> 
> Fixes: 6c6aa15fdea5 ("r8169: improve interrupt handling")
> Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com>
> ---
> Changes in v2:
>   - Make the commit message shorter
>   - Add "Fixes" tag in the commit message

I'm going to apply this for now, and queue it up for -stable.

If we hear back from Realtek on something we can do to make MSI-X
work on these chips, we can deal with it as a follow-up.

Thanks.