Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3647555imm; Mon, 20 Aug 2018 02:15:36 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwSeSPUBjwPOaJCNbA0eDZehrHh+kwxy9UlIhePnJwwTtzEGYG/YpOTj++KR+pCq92Z/EKy X-Received: by 2002:a63:41c1:: with SMTP id o184-v6mr10458104pga.297.1534756536759; Mon, 20 Aug 2018 02:15:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534756536; cv=none; d=google.com; s=arc-20160816; b=0DPvRPLkjTqL2pq7gWKT/8vYfpLW9ObNhQOJkvWSkCr0DbvS5SSZmU81DAOTyIehrq SMciBKMxgN9dSim/HqsogwCuX6JZMRF9/3yxrlT0aR/KQEsMq8PlHLT33ttqz5g10YR/ D4ZqAMKgRXCiItELvwd4ZRxUxKNSkNfiJkxapq3hy7FfG9Xjc1w2BLJTsPsux2PTKRCE r38My/CMR2ic2dvSUf5XSvPUSSvaAklyG1HcE4kVS+JmPY/NVxg+5SjBZ5+LzHDrK90+ bpywZnrWEZGAIdcMpYMBhRcFakgHdT8yWcZH+2OVd0GcfcMn9nMWXWy4b/lSf+t/WS9Z p3oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=5zFzQHbE6V51/SWDvCWK1BQ6hzwftpkn2t9UjP4d07w=; b=Mn5PLWxlcyPpKpNrJ4F8Th15GynNEyOpSFlusJS/B2D1EDd9VBRVXxM0sQC4NURH1J dQJWij2PnzeFmBrN9BgQTT7P6tHtkD2dDI8Ygp4fLsTiMxfYfEYy4AJs0x0A6NbQ7nsD XhiQ0Y83B9yON28+cAWjF4cqbFTMi4pE0+MMI9fFJn2Dl1MJmoJOJAFLjR+tZNao+RQ+ KG5mS5Ygco2dXgJmw2HUW6NfJCRdSm8JjfOGJpk+PYdfEm0EepYzqtU2cR/UFkZqqWW2 I23y7vnuzpMpg/RN6+m+t6aiFQVMwb3Eq4uI0oTa8tPinspj5vAZIAktziNRQjSzdvWd HMSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10-v6si4172466pln.298.2018.08.20.02.15.21; Mon, 20 Aug 2018 02:15:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726641AbeHTM2a (ORCPT + 99 others); Mon, 20 Aug 2018 08:28:30 -0400 Received: from sauhun.de ([88.99.104.3]:57662 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbeHTM2a (ORCPT ); Mon, 20 Aug 2018 08:28:30 -0400 Received: from localhost (p54B33943.dip0.t-ipconnect.de [84.179.57.67]) by pokefinder.org (Postfix) with ESMTPSA id F0B752D4159; Mon, 20 Aug 2018 11:13:38 +0200 (CEST) Date: Mon, 20 Aug 2018 11:13:38 +0200 From: Wolfram Sang To: Esben Haabendal Cc: linux-i2c@vger.kernel.org, Esben Haabendal , Wolfram Sang , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Lucas Stach , Phil Reid , Fabio Estevam , Peter Rosin , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/3] i2c: imx: Fix race condition in dma read Message-ID: <20180820091338.x2nofnytf7z27omk@ninjato> References: <20180816084315.7857-1-esben.haabendal@gmail.com> <20180816084315.7857-2-esben.haabendal@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hvvcsehlikqqjmfp" Content-Disposition: inline In-Reply-To: <20180816084315.7857-2-esben.haabendal@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --hvvcsehlikqqjmfp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 16, 2018 at 10:43:12AM +0200, Esben Haabendal wrote: > From: Esben Haabendal >=20 > This fixes a race condition, where the DMAEN bit ends up being set after > I2C slave has transmitted a byte following the dummy read. When that > happens, an interrupt is generated instead, and no DMA request is generat= ed > to kickstart the DMA read, and a timeout happens after DMA_TIMEOUT (1 sec= ). >=20 > Fixed by setting the DMAEN bit before the dummy read. >=20 > Signed-off-by: Esben Haabendal > Acked-by: Uwe Kleine-K=C3=B6nig Applied to for-next and added stable, thanks! --hvvcsehlikqqjmfp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlt6hkIACgkQFA3kzBSg Kbbgzg/9HmVo7UbvwKyXyXtOJl92ABXip9+uOSHVXFSrklNmT1s7d/pR6GtWdNTY RnoyO/81TQ0RWRIIdsaaSr7QMYg/VZ6mg/xiNWEYPQrKuJivnaNvRoX72GDRHMfO 9J2SwseayGtoLxJWGOg/UZUrIQCS8ZW32XfhmEoOhNfXjcLXRf8moi/BGQJhVMfO jqwdyCqWzRMl5JOnOuQsY8OKjEH6A5kKcgH+D5D9oUEUN7xXty9sgDff98CnQbpe GeZkxxcVWNr2EWWn8fVv7opGRxul4m94mmUaNOm+qdOWnz5tQGRcdeK/nhKn7DPU CAU5+H9MQ4sfb9gVLVZJAI1mUQisl1uYI9fCHeQanCh21Lv9R478JRWd0E9TziDe avqYzLKFA9XQxdYqpMpCHtXFhIyXr9pDfNG3FaSrKlB3zoI+6QLb1AaXZ4/MKNjC N/NsqcqsLN8Sojwt0Aw6H9tfJHHoViGH2ZGYztKtRgmrNWUy3FoAkfGXtMwiAPmk oRv7tLKbpXMrUx1D5R43dmzNHc/1FtWJkydjzyseIzt9T1EcCZCA3O8pXE14VShE WIOLY1fEwOPgSPoZXHEaMuROe59oTRcjTzC0NgpNZ3S6wXjn7ov+TowUtIuazYkh WYbAjivh2qBNO8Pmr7ulQb8xYI6wDOFWPEyWTMbhT0/cckYFLXQ= =n16k -----END PGP SIGNATURE----- --hvvcsehlikqqjmfp--