Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Naga Sureshkumar Relli <nagasure@xilinx.com>
To:     Boris Brezillon <boris.brezillon@bootlin.com>
CC:     "richard@nod.at" <richard@nod.at>,
        "absahu@codeaurora.org" <absahu@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "kyungmin.park@samsung.com" <kyungmin.park@samsung.com>,
        "frieder.schrempf@exceet.de" <frieder.schrempf@exceet.de>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "nagasureshkumarrelli@gmail.com" <nagasureshkumarrelli@gmail.com>,
        Michal Simek <michals@xilinx.com>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "peterpandong@micron.com" <peterpandong@micron.com>
Subject: RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for
 Arasan NAND Flash Controller
Thread-Topic: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for
 Arasan NAND Flash Controller
Thread-Index: AQHUNiz7bKojXyawJ0eL/lrCUsemM6TEO52AgAC1gGCAA2kvgIAAHrEA
Date:   Mon, 20 Aug 2018 10:49:38 +0000
Message-ID: <MWHPR02MB2623218B2BD3D102B07AC862AF320@MWHPR02MB2623.namprd02.prod.outlook.com>
References: <1534511964-20342-1-git-send-email-naga.sureshkumar.relli@xilinx.com>
        <1534511964-20342-3-git-send-email-naga.sureshkumar.relli@xilinx.com>
        <20180817195903.49963b25@bbrezillon>
        <MWHPR02MB2623D48B5DBAFCE2B5D03747AF3C0@MWHPR02MB2623.namprd02.prod.outlook.com>
 <20180820105355.11bd50a8@bbrezillon>
In-Reply-To: <20180820105355.11bd50a8@bbrezillon>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: xilinx.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 945c3c71-f2cc-4298-32a1-08d6068aa092
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Aug 2018 10:49:38.7922
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB3198
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris,

> -----Original Message-----
> From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> Sent: Monday, August 20, 2018 2:24 PM
> To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> Cc: richard@nod.at; absahu@codeaurora.org; linux-kernel@vger.kernel.org;
> marek.vasut@gmail.com; kyungmin.park@samsung.com; frieder.schrempf@exceet=
.de; linux-
> mtd@lists.infradead.org; miquel.raynal@bootlin.com; nagasureshkumarrelli@=
gmail.com;
> Michal Simek <michals@xilinx.com>; computersforpeace@gmail.com; dwmw2@inf=
radead.org;
> peterpandong@micron.com
> Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for =
Arasan
> NAND Flash Controller
>=20
> On Sat, 18 Aug 2018 05:49:32 +0000
> Naga Sureshkumar Relli <nagasure@xilinx.com> wrote:
>=20
> > Hi Boris,
> >
> > Thanks for the review.
> >
> > > -----Original Message-----
> > > From: Boris Brezillon [mailto:boris.brezillon@bootlin.com]
> > > Sent: Friday, August 17, 2018 11:29 PM
> > > To: Naga Sureshkumar Relli <nagasure@xilinx.com>
> > > Cc: miquel.raynal@bootlin.com; richard@nod.at; dwmw2@infradead.org;
> > > computersforpeace@gmail.com; marek.vasut@gmail.com;
> > > kyungmin.park@samsung.com; absahu@codeaurora.org;
> > > peterpandong@micron.com; frieder.schrempf@exceet.de; linux-
> > > mtd@lists.infradead.org; linux-kernel@vger.kernel.org; Michal Simek
> > > <michals@xilinx.com>; nagasureshkumarrelli@gmail.com
> > > Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support
> > > for Arasan NAND Flash Controller
> > >
> > > Hi Naga,
> > >
> > > On Fri, 17 Aug 2018 18:49:24 +0530
> > > Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com> wrote:
> > >
> > > > +static int anfc_exec_op_cmd(struct nand_chip *chip,
> > > > +				   const struct nand_subop *subop) {
> > > > +	const struct nand_op_instr *instr;
> > > > +	struct anfc_op nfc_op =3D {};
> > > > +	struct anfc_nand_chip *achip =3D to_anfc_nand(chip);
> > > > +	struct anfc_nand_controller *nfc =3D to_anfc(chip->controller);
> > > > +	struct mtd_info *mtd =3D nand_to_mtd(chip);
> > > > +	u32 addrcycles;
> > > > +	unsigned int op_id, len =3D 0;
> > > > +	bool reading;
> > > > +
> > > > +	anfc_parse_instructions(chip, subop, &nfc_op);
> > > > +	instr =3D nfc_op.data_instr;
> > > > +	op_id =3D nfc_op.data_instr_idx;
> > > > +	if (nfc_op.data_instr)
> > > > +		len =3D nand_subop_get_data_len(subop, op_id);
> > > > +
> > > > +	/*
> > > > +	 * The switch case is to prepare a command and to set page/column
> > > > +	 * address. Arasan NAND controller has program register(Off: 0x10=
)),
> > > > +	 * which needs to be set for every command.
> > > > +	 * Ex: When NAND_CMD_RESET is issued, then we need to set reset b=
it
> > > > +	 * in program_register. etc..
> > > > +	 */
> > > > +	switch (nfc_op.cmnds[0]) {
> > > > +	case NAND_CMD_SEQIN:
> > > > +		addrcycles =3D achip->raddr_cycles + achip->caddr_cycles;
> > > > +
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0], NAND_CMD_PAGEPROG,
> 1,
> > > > +				 mtd->writesize, addrcycles);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		break;
> > > > +	case NAND_CMD_READOOB:
> > > > +		nfc_op.col +=3D mtd->writesize;
> > > > +	case NAND_CMD_READ0:
> > > > +	case NAND_CMD_READ1:
> > > > +		addrcycles =3D achip->raddr_cycles + achip->caddr_cycles;
> > > > +		anfc_prepare_cmd(nfc, NAND_CMD_READ0,
> NAND_CMD_READSTART,
> > > 1,
> > > > +				 mtd->writesize, addrcycles);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		if (!nfc_op.data_instr)
> > > > +			return 0;
> > > > +
> > > > +		anfc_read_data_op(mtd, instr->ctx.data.buf.in, len);
> > > > +		break;
> > > > +	case NAND_CMD_RNDOUT:
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0],
> NAND_CMD_RNDOUTSTART, 1,
> > > > +				 mtd->writesize, 2);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		nfc->prog =3D PROG_PGRD;
> > > > +		break;
> > > > +	case NAND_CMD_PARAM:
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0], 0, 0, 0, 1);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		nfc->prog =3D PROG_RDPARAM;
> > > > +		break;
> > > > +	case NAND_CMD_READID:
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0], 0, 0, 0, 1);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		nfc->prog =3D PROG_RDID;
> > > > +		break;
> > > > +	case NAND_CMD_GET_FEATURES:
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0], 0, 0, 0, 1);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		nfc->prog =3D PROG_GET_FEATURE;
> > > > +		break;
> > > > +	case NAND_CMD_SET_FEATURES:
> > > > +		anfc_prepare_cmd(nfc, nfc_op.cmnds[0], 0, 0, 0, 1);
> > > > +		anfc_setpagecoladdr(nfc, nfc_op.row, nfc_op.col);
> > > > +		nfc->prog =3D PROG_SET_FEATURE;
> > > > +		break;
> > > > +	case NAND_CMD_ERASE1:
> > > > +		anfc_erase_function(chip, nfc_op);
> > > > +		break;
> > > > +	default:
> > > > +		break;
> > > > +	}
> > >
> > > Looks like you have one of these smart controllers where everything
> > > is hardcoded and new commands (like vendor specific commands) can't
> > > be supported, and we're back to abusing -
> > > >exec_op(), just like ->cmdfunc() was abused.
> > Actually hardcoding commands with ->exec_op() interface in the driver i=
s really looking
> weird.
> > I agree with that.
> > But as per the spec, for every command, we need to set respective bit
> > in PROG_REG and because Of this, we need to track the commands for each=
 exec_op() call.
> > >
> > > Don't you have a way to send raw CMD/ADDR/DATA cycles? If not, then
> > > we'll have to consider other options, because I don't want to go
> > > back to the situation we are in with -
> > > >cmdfunc().
> > As I said above, for each command we need to set a bit in PROG_REG, to =
initiate the
> operation.
> > The only conflicting thing is that, setting a respective bit in
> > PROG_REG based on the command Needs command tracking.
> > >
> > > Maybe I already asked, but is there a public spec for this IP?
> > I didn't find any public spec for this IP, but you can find the
> > register data base at below link
> > https://www.xilinx.com/html_docs/registers/ug1087/ug1087-zynq-ultrasca
> > le-registers.html
> > and click on NAND.
> > There we have Command Reg(Off: 0x0C) and Program Reg(Off: 0x10), which =
describes the
> usage.
> >
> > Also not in depth but at least something is documented in TRM
> > https://www.xilinx.com/support/documentation/user_guides/ug1085-zynq-u
> > ltrascale-trm.pdf we can find the programming model in chapter 25.
> > Please let me know if I missed anything.
>=20
> I had a closer look at those documents (which I remember reading a while =
back BTW), and the
> PROG bits are indeed not described in detail.
>=20
> Still, I think it's close to what we have on Marvell SoC, where those 'mo=
des' actually encode a
> specific sequence of timing that is used for well-known commands (like ER=
ASE, RESET,
> READID) but could be used the same way with other opcodes assuming the se=
quence is the
> same.
>=20
> So, you should use the pattern approach, but not like you do: you should =
have a dedicated hook
> for each pattern which would set PROG bit, and then a generic helper to f=
ill all other
> information (opcode, address cycles, ...).

Thanks for your suggestion and are you saying something like Marvell parser=
 patterns for nfcv1 as below?

static const struct nand_op_parser marvell_nfcv1_op_parser =3D NAND_OP_PARS=
ER(
	/* Naked commands not supported, use a function for each pattern */
	NAND_OP_PARSER_PATTERN(
		marvell_nfc_read_id_type_exec,
		NAND_OP_PARSER_PAT_CMD_ELEM(false),
		NAND_OP_PARSER_PAT_ADDR_ELEM(false, MAX_ADDRESS_CYC_NFCV1),
		NAND_OP_PARSER_PAT_DATA_IN_ELEM(false, 8)),
	NAND_OP_PARSER_PATTERN(
		marvell_nfc_erase_cmd_type_exec,
		NAND_OP_PARSER_PAT_CMD_ELEM(false),
		NAND_OP_PARSER_PAT_ADDR_ELEM(false, MAX_ADDRESS_CYC_NFCV1),
		NAND_OP_PARSER_PAT_CMD_ELEM(false),
		NAND_OP_PARSER_PAT_WAITRDY_ELEM(false)),
	);
That means, a separate hook for each pattern, is that you are suggesting?

Thanks,
Naga Sureshkumar Relli.