Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of analog.com designates
 137.71.25.55 as permitted sender) receiver=protection.outlook.com;
 client-ip=137.71.25.55; helo=nwd2mta1.analog.com;
From:   "Caprioru, Mircea" <Mircea.Caprioru@analog.com>
To:     Peter Rosin <peda@axentia.se>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mux: adgs1408: use the correct SPDX license identifier
Thread-Topic: [PATCH] mux: adgs1408: use the correct SPDX license identifier
Thread-Index: AQHUOHH9YqD8n8fT5UGByPoy0/1tYKTIeqyA
Date:   Mon, 20 Aug 2018 11:14:27 +0000
Message-ID: <209EE0F380CD554C95B3E2532952872D29ABC21F@NWD2MBX7.ad.analog.com>
References: <209EE0F380CD554C95B3E2532952872D29ABC204@NWD2MBX7.ad.analog.com>
 <20180820103827.24639-1-peda@axentia.se>
In-Reply-To: <20180820103827.24639-1-peda@axentia.se>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2018 11:14:45.8785
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 970b5800-5da7-4e64-79da-08d6068e22fc
X-MS-Exchange-CrossTenant-Id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=eaa689b4-8f87-40e0-9c6f-7228de4d754a;Ip=[137.71.25.55];Helo=[nwd2mta1.analog.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB552
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ok now I understand.  We can go with GPL-2.0-or-later and MODULE_LICENSE("G=
PL").=20
We are pretty flexible regarding what license we should use upstream wise. =
If you feel we should change it in some other way we can do that too.=20

Regards,
Mircea

-----Original Message-----
From: Peter Rosin [mailto:peda@axentia.se]=20
Sent: Monday, August 20, 2018 1:38 PM
To: linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>; Caprioru, Mircea <Mircea.Caprioru@analog=
.com>
Subject: [PATCH] mux: adgs1408: use the correct SPDX license identifier

The file is GPL v2 only.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/mux/adgs1408.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

On 2018-08-20 12:16, Caprioru, Mircea wrote:
> Peter Rosin wrote:
>> I just noticed a discrepancy in the license annotations in your=20
>> driver. The SPDX license identifier says GPL-2.0-or-later, and I=20
>> assume that is correct and that MODULE_LICENSE("GPL") without the v2=20
>> specifier, as in this patch, is the correct thing to do?
>
> The file should be v2. It might of slipped from the final version.

Ok, so I read that as if it should be v2 *only* and not v2-or-later.
I.e. the reverse of the original patch. But since these things can be sensi=
tive, I'd like confirmation that this new patch is what is correct...

Note that MODULE_LICENSE("GPL") means GPL v2 *or later* (GPL v1 is not on t=
he table), while MODULE_LICENSE("GPL v2") means GPL v2 *only*.
See include/linux/module.h for details.

Cheers,
Peter

diff --git a/drivers/mux/adgs1408.c b/drivers/mux/adgs1408.c index 0f7cf54e=
3234..fe0377bb83eb 100644
--- a/drivers/mux/adgs1408.c
+++ b/drivers/mux/adgs1408.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
+// SPDX-License-Identifier: GPL-2.0
 /*
  * ADGS1408/ADGS1409 SPI MUX driver
  *
--
2.11.0