Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp3934031imm; Mon, 20 Aug 2018 07:09:59 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwR3qLMIMwkl6ClxptgbsGmFhUDTcR1qF4VsERdpTojdpo8qIK56BTtpJwiQLaNpZC8EmSX X-Received: by 2002:a63:2352:: with SMTP id u18-v6mr5224079pgm.202.1534774199048; Mon, 20 Aug 2018 07:09:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534774199; cv=none; d=google.com; s=arc-20160816; b=bK9Kx1HgpR20OgGcLqbvS1ude3jd8BNxOAki7B91qPvvCY5Vn2q3u/P0iXilNEAsxk 4u90dy9/q2KiY5aAUHXRNBvVIdddq2WoxdimYWp9Bg0C6ENZZ43ZypmR4Rf2roY+Si4j XlDanTLt7aqlN8pyK21n7nokFXZH5ySyKK2lzp5tTtxzkZ8XgYnqbRwUqUP9HDEU5e0E WpFWE/ri6Y5GbcpVRXq07GV8RXnuU4R69Q+NbZGE6Jfbjt5kfnESP/Fzl21NJ9afcPbg ws1HP7ix6rj6efesIJ4Bm4juzu6DghpTnsgnFi/fuwrsK8KV43iNKrMkeM+RUIMeRN3H 0hGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=KFEGRNXG6jGhkWzKu1wMnVtS4eIhncZB52VPNE7hPHg=; b=Z2sl7CxwWpx2So7lBWH6eCMFFYV2WBx5HvOY1AucirWfBRrIf9Um9oVIm+mTb+ODBi LrlUUstim4T8c3khraYDi0NNvQfo1OvFg6y1O5gpJR/TjlY0tJ/4tKgphvWHZ0y/DVTb MJq0RW4bAX7giDppPeq27QyYkvKKSMu86rob/jgHrvInzznALtoudIvKUNxb+BYRz+4p GZYmpQo+UGES2yq5LTMSTAvAWZW7skoEKCpFGB+FQ3xlu+4cOrsG8f313HpEaOM40eCN k9T6n+OiDvDwxQj8UBTbXlGYtuvWE3F1rgARRGJx1ANO4Tzn9ziURwpUV3qI0TmnJUAw s7YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b="tf/jAatw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb14-v6si2253813plb.178.2018.08.20.07.09.29; Mon, 20 Aug 2018 07:09:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b="tf/jAatw"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbeHTQPg (ORCPT + 99 others); Mon, 20 Aug 2018 12:15:36 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:45436 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbeHTQPf (ORCPT ); Mon, 20 Aug 2018 12:15:35 -0400 Received: by mail-lj1-f193.google.com with SMTP id w16-v6so11512225ljh.12 for ; Mon, 20 Aug 2018 06:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KFEGRNXG6jGhkWzKu1wMnVtS4eIhncZB52VPNE7hPHg=; b=tf/jAatwx0m5FsSFqhR25+PUkX2t3PP4xtCcm38GRHmos+trPhjTyVkToDIPVjzYZF inDYJK7JkpzMXQPVLKrhfzCTRSIdXAHykcXG/JGA7l8d7df2exDdlU8C55lmZvCZBC5w fAnQ5/w4CHNMZez7wHIMi/F4EwpsUZDNNV3fIZSbOd/bZDh3spu6AQUb4zke4DUtEoMD +jDVUZmxAkcpXlHJVlMM2yLpyYxgm4YbL51d5WhQo8OmJ14kj0nsEjqmfGqFQRQloyea eFBcE3eDDawoJY1Sf2+lWAv/ChXsRHYllbQg1PgM2aDKPsZsQGJkipSSwOJgIeP1dhU7 pDxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KFEGRNXG6jGhkWzKu1wMnVtS4eIhncZB52VPNE7hPHg=; b=jsHzBYoAsJ88K/YsvIqeporEPyuqIDnuXWEJK1b9IjaFBGJyLmHVze3G4O+sflabW1 VdPbi5smPzUsQC9+5Hs5cJnx9mZL2btkJDGT2tEPwqmIBLGlox00R3E1nbYTYbUVmQiZ R+cI9lGQ/NLNWGRY4m8vGO8QMCTwSVf4RVauQfWJUvsom1TKSQxyc7IdOJ/owtC12AnG kzoKkJEHrwMhxzAw4XIpiAxDc6Iz4ltdSQefw9bK03nOGSXPqVpU6PomId4sV2lXirlN 886lsNSWF/KK3CZNT9HsNWMCEXlGodRip6c8rjvVnIvQNbR9QpJSsOFSFYOS/fxqk+1c h8Ww== X-Gm-Message-State: AOUpUlHC0M7ivewMVhkQBAiPYt/dZjcW/vr+w1sc57is0C4EFDdoot/K LqkuY8siJ5M/tUF8Pa0QiqsctQ== X-Received: by 2002:a2e:9941:: with SMTP id r1-v6mr30054946ljj.53.1534770001004; Mon, 20 Aug 2018 06:00:01 -0700 (PDT) Received: from localhost.localdomain (95-166-82-66-cable.dk.customer.tdc.net. [95.166.82.66]) by smtp.gmail.com with ESMTPSA id a14-v6sm1609051ljb.49.2018.08.20.05.59.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Aug 2018 05:59:59 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: igor.j.konopko@intel.com, marcin.dziegielewski@intel.com, javier@cnexlabs.com, hans.holmberg@cnexlabs.com, hlitz@ucsc.edu, youngtack.jin@circuitblvd.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH] lightnvm: pblk: remove size and out of bounds read check Date: Mon, 20 Aug 2018 14:59:53 +0200 Message-Id: <20180820125953.15364-1-mb@lightnvm.io> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The I/O size and capacity check are already done by the block layer. Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-read.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c index f275c7e5abe4..d0fbd50ecc90 100644 --- a/drivers/lightnvm/pblk-read.c +++ b/drivers/lightnvm/pblk-read.c @@ -452,13 +452,6 @@ int pblk_submit_read(struct pblk *pblk, struct bio *bio) DECLARE_BITMAP(read_bitmap, NVM_MAX_VLBA); int ret = NVM_IO_ERR; - /* logic error: lba out-of-bounds. Ignore read request */ - if (blba >= pblk->rl.nr_secs || nr_secs > NVM_MAX_VLBA) { - WARN(1, "pblk: read lba out of bounds (lba:%llu, nr:%d)\n", - (unsigned long long)blba, nr_secs); - return NVM_IO_ERR; - } - generic_start_io_acct(q, READ, bio_sectors(bio), &pblk->disk->part0); bitmap_zero(read_bitmap, nr_secs); -- 2.11.0