Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAMGffEnzVo5VVSVBjCOBMhcoV1qXf0XXqJqr3C01xQn-aUiZFQ@mail.gmail.com>
 <20180816155126.GA18296@kroah.com> <CAMGffEmJR310NKHO1JpwE8yTg1Oeu_oaTaJ1D2_T_UHKCnHwKA@mail.gmail.com>
 <20180816163937.GA5105@kroah.com> <CAMGffEk2FqRn0av7T-aF-TKvRAKeinm96NYjJju_T4CmUrYPkQ@mail.gmail.com>
 <CAMGffEnKt0xcc6LhNdZQGRmckJ3qCFxCOnQ3owZmWWiaKYdYuw@mail.gmail.com>
 <20180817170129.GE24945@kroah.com> <alpine.DEB.2.21.1808181330380.2151@nanos.tec.linutronix.de>
 <CAMGffEk=6eVgB=A--FyooDoVPY4mEiOdf=yNnqdX4cF6Ud_NuA@mail.gmail.com> <alpine.DEB.2.21.1808201500590.1551@nanos.tec.linutronix.de>
In-Reply-To: <alpine.DEB.2.21.1808201500590.1551@nanos.tec.linutronix.de>
From:   Jinpu Wang <jinpu.wang@profitbricks.com>
Date:   Mon, 20 Aug 2018 15:20:33 +0200
Message-ID: <CAMGffEnmp3zOXYb2cpHdLgeb0LAUac5umhK3OMUBFiJ1+7ce6w@mail.gmail.com>
Subject: Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        stable <stable@vger.kernel.org>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>, konrad.wilk@oracle.com,
        Peter Zijlstra <peterz@infradead.org>,
        David Woodhouse <dwmw@amazon.co.uk>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Aug 20, 2018 at 3:02 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Mon, 20 Aug 2018, Jinpu Wang wrote:
>
> > On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner <tglx@linutronix.de> wr=
ote:
> > >
> > > On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote:
> > > > On Fri, Aug 17, 2018 at 02:39:00PM +0200, Jinpu Wang wrote:
> > > > >
> > > > > I found the problem, CONFIG_HOTPLUG_SMT is enable due to CONFIG_S=
MP,
> > > > > but I did explicitly enable CONFIG_HOTPLUG_CPU.
> > > > >
> > > > > That's why the smt dir is missing, and kernel panic when I boot w=
ith
> > > > > 'nosmt' or 'l1tf=3Dfull' probably also other combination.
> > > > >
> > > > > With CONFIG_HOTPLUG_CPU=3Dy, it works fine so far.
> > > >
> > > > So do we need a new configuration dependancy here to resolve this
> > > > problem?  Why is this not an issue in Linus's tree?
> > >
> > > That's probably the same problem on Linus tree. Have not tested it ye=
t
> > > though. I'll have a look.
> > >
> > > Thanks,
> > >
> > >         tglx
> > >
> > Yeah, it's the same problem on Linus tree.
> >
> > Probably makes sense to do the following, I can sent a formal patch if
> > you think it's right thing to do:
> >
> > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> > index b0312f8..8a52f0b 100644
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -188,7 +188,7 @@ config X86
> >         select HAVE_SYSCALL_TRACEPOINTS
> >         select HAVE_UNSTABLE_SCHED_CLOCK
> >         select HAVE_USER_RETURN_NOTIFIER
> > -       select HOTPLUG_SMT                      if SMP
> > +       select HOTPLUG_SMT                      if SMP && HOTPLUG_CPU
>
> That works, but we might as well force 'select HOTPLUG_CPU if SMP' so the
> L1TF mitigations are functional. Sigh....
>
> Thanks,
>
>         tglx
right, sth like?
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index b0312f8..5852948 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -188,7 +188,8 @@ config X86
        select HAVE_SYSCALL_TRACEPOINTS
        select HAVE_UNSTABLE_SCHED_CLOCK
        select HAVE_USER_RETURN_NOTIFIER
-       select HOTPLUG_SMT                      if SMP
+       select HOTPLUG_CPU                      if SMP
+       select HOTPLUG_SMT                      if SMP && HOTPLUG_CPU
        select IRQ_FORCED_THREADING
        select NEED_SG_DMA_LENGTH
        select PCI_LOCKLESS_CONFIG


--=20
Thanks,

Jack Wang
Linux Kernel Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Tel:       +49 30 577 008  042
Fax:      +49 30 577 008 299
Email:    jinpu.wang@profitbricks.com
URL:      https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Gesch=C3=A4ftsf=C3=BChrer: Achim Weiss, Matthias Steinberg, Christoph Steff=
ens