Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (1.0)
Subject: Re: [PATCH] x86/process: Export start_thread()
From:   Andy Lutomirski <luto@amacapital.net>
In-Reply-To: <alpine.DEB.2.21.1808200927550.2151@nanos.tec.linutronix.de>
Date:   Mon, 20 Aug 2018 07:27:11 -0700
Cc:     Rian Hunter <rian@alum.mit.edu>, linux-kernel@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Andy Lutomirski <luto@kernel.org>,
        Borislav Petkov <bpetkov@suse.de>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Joerg Roedel <jroedel@suse.de>,
        Dmitry Safonov <dima@arista.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <D2852E34-BC10-4161-A05D-981E3A3D4098@amacapital.net>
References: <20180819230854.7275-1-rian@alum.mit.edu> <53141AE9-7192-432B-8A27-25986CF442D4@amacapital.net> <alpine.DEB.2.21.1808200927550.2151@nanos.tec.linutronix.de>
To:     Thomas Gleixner <tglx@linutronix.de>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Aug 20, 2018, at 12:30 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>=20
> On Sun, 19 Aug 2018, Andy Lutomirski wrote:
>>> On Aug 19, 2018, at 4:08 PM, Rian Hunter <rian@alum.mit.edu> wrote:
>>>=20
>>> Commit e634d8fc792c ("x86-64: merge the standard and compat
>>> start_thread() functions") removed exporting for the start_thread()
>>> function in what seems like a typo. Add it back to
>>> arch/x86/kernel/process_64.c for parity with process_32.c and other
>>> arch.
>>=20
>> What for?  Perhaps 32-bit could remove it instead?
>=20
> No. start_thread() is called from various binfmt implementations which can=

> be built as modules.

Fair enough. I=E2=80=99m fine with the patch.

>=20
> Thanks,
>=20
>    tglx