Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180817120319.21002-1-andrzej.p@samsung.com>
References: <CGME20180817120447eucas1p1dde0176cf7d824e8a42e2d39ac5531f9@eucas1p1.samsung.com>
 <CAK7LNASUsZB--DWMB4hpw74OnTiz+d2jrdp+CA9L=AOdkbEmhg@mail.gmail.com> <20180817120319.21002-1-andrzej.p@samsung.com>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Tue, 21 Aug 2018 00:03:08 +0900
Message-ID: <CAK7LNAT3K3Z=R3=UdKh22LVLDKDfBReYWT1mtep=2DteonTnJw@mail.gmail.com>
Subject: Re: [PATCH] kbuild: make sorting initramfs contents independent of locale
To:     Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Bj=C3=B8rn_Forsman?= <bjorn.forsman@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-08-17 21:03 GMT+09:00 Andrzej Pietrasiewicz <andrzej.p@samsung.com>:
> Some LANG values (e.g. pl_PL.UTF-8) cause the sort command to output
> files before their parent directories, which makes them inaccessible for
> the kernel. In other words, when the kernel populates the rootfs, it is
> unable to create files whose parent directories have not been yet created.
>
> This patch makes sorting use the default (LANG=C) locale, which results in
> correctly laid out initramfs images (parent directories before files).
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> ---


Applied to linux-kbuild. Thanks!


>  scripts/gen_initramfs_list.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gen_initramfs_list.sh b/scripts/gen_initramfs_list.sh
> index 10e528b..0aad760 100755
> --- a/scripts/gen_initramfs_list.sh
> +++ b/scripts/gen_initramfs_list.sh
> @@ -174,7 +174,7 @@ dir_filelist() {
>         ${dep_list}header "$1"
>
>         srcdir=$(echo "$1" | sed -e 's://*:/:g')
> -       dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" | sort)
> +       dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" | LANG=C sort)
>
>         # If $dirlist is only one line, then the directory is empty
>         if [  "$(echo "${dirlist}" | wc -l)" -gt 1 ]; then
> --
> 2.7.4
>


-- 
Best Regards
Masahiro Yamada