Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4053248imm; Mon, 20 Aug 2018 09:02:27 -0700 (PDT) X-Google-Smtp-Source: AA+uWPw6wjC147MIXX4qfvMvzapgIh7WhWUyA8RTDPhRBoB9GJqX0g7GBByJ85r5WUum2C0DVyS6 X-Received: by 2002:a65:6292:: with SMTP id f18-v6mr43348646pgv.85.1534780947126; Mon, 20 Aug 2018 09:02:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534780947; cv=none; d=google.com; s=arc-20160816; b=vXVgyURFSWvGZEHD556+T9/b9c2+wOl416n0F6FnmZuPUv8dJnaUmfREPh1BKhM/sd rovq60vpY8FTrBOM3Q0Nts1i4qo8Nucgd5RlENud/ck16p80s/UBsHkDOf+jjtZ5Iwbq b1WJzeqwKkvGp1o3V+esmSrC885yKqAujRcBxAkrYORE3/vyhGnMT8RakUsalp3panr4 73qD7tRE4VFmF3ynEaBfrhsEABWoIXuGYX67nO9bTNIuXm3DrHlLmtp7d6jQxHtPnF1n ZCsvgmgFmQ0rcC1aIGWQ5sM+7EOXQ0kTzdxXDiY3ix3UvQKVjg2Wu93D2gyjBhzf0fOc 1iLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=hy6CnnAOo1+hrHTgixfT9vAKlJ0kifWYC+qtVlRhqxE=; b=i1bCcnm/zQ71p8R19udx3d/Fj7ndRxvYOC+nD21jObojwyUtIPJF1J6dWZO3aZQ8jS WRFle7/yebrqbco3UrFuvgDm3hpjfs9sp+J5ueNhxzbkR5Mo6I17PXx1RNZkVFXzyR4U STITeDjO9dkfni56pQDlYjNkW2Ceq0DEzcHnwq5VyKGgbKntkwHhQVvJtDhGfdcX5qSY jngSODzPD7bQretHnhc8O5Mzlj5nuVZxNAP2urwStSBt8DPrzC9ZYfq4Gv1mkZZLPPUF DTemlIXdoahGkylFw/nEj1GledBFRm8qhi7gDJsju+lPXuaaXs02TFDrIb1sPhzb5wnV 7Qcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="l2qHN/1a"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i14-v6si2980227pgm.245.2018.08.20.09.02.11; Mon, 20 Aug 2018 09:02:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b="l2qHN/1a"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727067AbeHTTRD (ORCPT + 99 others); Mon, 20 Aug 2018 15:17:03 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:45584 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbeHTTRD (ORCPT ); Mon, 20 Aug 2018 15:17:03 -0400 Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3986C116A; Mon, 20 Aug 2018 18:00:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1534780849; bh=F3Ui/QgyPjqf17UfOryZaYMNEGB/SZoBremLkx90vy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l2qHN/1ajFgr4kxfEswT2lpEittTJm6ij8tUuGr4hNeaC8QrU2O3Q+Jfs49SETXKC 6PhoHL9kmOX/17K18jnUf41ojzmLeUHVREYuXLgdDJWYjgx0sqBPWZJYCzgxSMMHBg F07ZTeyeKQFngjcRX5ppQOq2HvbnNX4vvykXXGZc= From: Kieran Bingham To: Laurent Pinchart , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham Subject: [PATCH 1/2] drm: rcar-du: Refactor Feature and Quirk definitions Date: Mon, 20 Aug 2018 17:00:43 +0100 Message-Id: <20180820160044.15783-2-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180820160044.15783-1-kieran.bingham+renesas@ideasonboard.com> References: <20180820160044.15783-1-kieran.bingham+renesas@ideasonboard.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These flags are represented by bit fields. To make this clear, utilise the BIT() macro. Signed-off-by: Kieran Bingham --- This patch fails checkpatch's 80-char limit, due to the line comments extending across the 80-char boundary on RCAR_DU_FEATURE_EXT_CTRL_REGS To preserve formatting - this warning has been ignored. drivers/gpu/drm/rcar-du/rcar_du_drv.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.h b/drivers/gpu/drm/rcar-du/rcar_du_drv.h index b3a25e8e07d0..78ea20abfb30 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.h +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.h @@ -27,11 +27,11 @@ struct drm_device; struct drm_fbdev_cma; struct rcar_du_device; -#define RCAR_DU_FEATURE_CRTC_IRQ_CLOCK (1 << 0) /* Per-CRTC IRQ and clock */ -#define RCAR_DU_FEATURE_EXT_CTRL_REGS (1 << 1) /* Has extended control registers */ -#define RCAR_DU_FEATURE_VSP1_SOURCE (1 << 2) /* Has inputs from VSP1 */ +#define RCAR_DU_FEATURE_CRTC_IRQ_CLOCK BIT(0) /* Per-CRTC IRQ and clock */ +#define RCAR_DU_FEATURE_EXT_CTRL_REGS BIT(1) /* Has extended control registers */ +#define RCAR_DU_FEATURE_VSP1_SOURCE BIT(2) /* Has inputs from VSP1 */ -#define RCAR_DU_QUIRK_ALIGN_128B (1 << 0) /* Align pitches to 128 bytes */ +#define RCAR_DU_QUIRK_ALIGN_128B BIT(0) /* Align pitches to 128 bytes */ /* * struct rcar_du_output_routing - Output routing specification -- 2.17.1