Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4111330imm; Mon, 20 Aug 2018 10:00:52 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyZnhD2pRMlgf4Fq9IxvPJZOS0pjMHNay21tYAKRdXHFAegY+Q0zGGEdGpepR3q4AmC/5lV X-Received: by 2002:a62:c182:: with SMTP id i124-v6mr48588505pfg.248.1534784452538; Mon, 20 Aug 2018 10:00:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534784452; cv=none; d=google.com; s=arc-20160816; b=IjIDIzMwWsCOtbftN/9zdVqzTFPl0r1ksXIi4X/obEJPkHKKroZr/M03TnbFlUUKd8 nl3BI4utJcErz6nGwf7nRF8QZUB02EVldQIWTOP2oxyuKt2sOzbpyfkGIi961q7fUtLQ mrT6QGrSfwoYz7VaDoKBAvtDByeCVM6vuhWiK2S/Ioadz7CPlOYJ8Y0PJqstZp1VJOHT 6gPpiBZnmCUWhOjW/WpvYkoyV1nPEO/0DXzdQ8J0nHxD1vd/re+KMo5O/hxI2sFrYcrg /paaz/O0lqCKRU6zUcoDcGmQK7ExCb73/htT3pxdx76s2PTxJo6041JVN7s05fD3GGV5 jyHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=a5BIQ2pWF2RmzTeXue1BXmxXRolTxVgkMVfm4evtPQ4=; b=05gzZfo+Jdv7SraF5wrq1+x3/hAzN16GSIIZEApWamGdftHrHK6kVQGkPf0+Azu4Xr twGAfI20VPZepM5s7ujhjqCjjgWrD33QjC9SUhp0yXBZgpe7FVG/9mJ7CtVya9OYKT2n a3YXqGnw6rmjkAC6/vm6jV/lqX/itXW2v4SwBU9+9AIlhV9GzIW62zKNnk8Qv5KIWSMg rcLiPFTSPO2gq2jSe9xPcXf5/REgDnM5D4LNjEP1Qsz6Q7q1sP8EGr1nxAIkf8M8jfwc RTLtY4FAMWK9AYBRJzn+/NTApK3+4ptU8l3h5b+el/gon1Om/hNjiueUHiMJqMiIkVlH eT/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XzllTMae; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17-v6si8397877pgl.35.2018.08.20.10.00.36; Mon, 20 Aug 2018 10:00:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=XzllTMae; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726816AbeHTTQw (ORCPT + 99 others); Mon, 20 Aug 2018 15:16:52 -0400 Received: from mail-yw1-f68.google.com ([209.85.161.68]:43449 "EHLO mail-yw1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbeHTTQw (ORCPT ); Mon, 20 Aug 2018 15:16:52 -0400 Received: by mail-yw1-f68.google.com with SMTP id l189-v6so6997656ywb.10 for ; Mon, 20 Aug 2018 09:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a5BIQ2pWF2RmzTeXue1BXmxXRolTxVgkMVfm4evtPQ4=; b=XzllTMaeGQWZq6mY6kTFriFRBtYVaPIfgGMMI7cux1sbw80jp7+jm7IG+/qMmRQrfG Tz7uEM1mSO9WuwHX9y0jO3kqcDazF8EIPKoMifI3x1gocP6dW2VdRLN85h2j1wrhgXtA Zit29xQbQhQH1xEsEqlbzx9XFbedftBuGu/sWgMD9NTbtCB0f50DRbrdGBD4ml+E4exQ fC0/iAsk1fQ2wi4Y8gwKlzEovo+snTrkBj1ad5eFfJx6CElOmb+9TUhfe45UkTr2E1Pw 1jE4A13h77WCTZTgnthyuOii2ZArxl31SiCreugGOIhSdCmeSsEEBjRxMCa7Yiqrary1 uH3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=a5BIQ2pWF2RmzTeXue1BXmxXRolTxVgkMVfm4evtPQ4=; b=RHBmnRnPUQAJzGafcw/wg78eQXbzf2/czW95EQGYfxzftb9J12EInPpz2qmU4Cm5ba mJZGos5erNr84/TttrL4iDJAuPf+ebPGWZCrkBT9ntEUSPpYVvg7g7P+1w/UCC33nvqH WCTEWdZiWb8h1jYzE2hZ04740/v+uzZTNzy0GAK9JoAUc/ZUNvODdRL8chR3QlZUTAUv tlDqflZtUJ5v6pfYjYtumAyd+G8j+Orjkls8iPC2uBu8CtbhntgOVE1eA/qbZETcz8fH hi1T7UerTgluvv8g1Fl3lbCNhkokiGfboVpIgDqzQJTltcV8Aiev0SJQ2DsYecbOjOhX M/rg== X-Gm-Message-State: AOUpUlE1TeK2aCJKveEl4b946XAe7oo6MBhr+yw/gsd2gd4Y2lTad9OW lOSBMufvHb7zP/+5PKnrjRk= X-Received: by 2002:a81:6d4:: with SMTP id 203-v6mr5676171ywg.42.1534780839229; Mon, 20 Aug 2018 09:00:39 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::1:9c5d]) by smtp.gmail.com with ESMTPSA id p126-v6sm4563205ywf.22.2018.08.20.09.00.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Aug 2018 09:00:38 -0700 (PDT) Date: Mon, 20 Aug 2018 09:00:36 -0700 From: Tejun Heo To: wang.yi59@zte.com.cn Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org, jiang.biao2@zte.com.cn, zhong.weidong@zte.com.cn Subject: Re: [PATCH] workqueue: fix memory leak in wq_numa_init() Message-ID: <20180820160036.GL3978217@devbig004.ftw2.facebook.com> References: <1533518439-3982-1-git-send-email-wang.yi59@zte.com.cn> <201808201205500126227@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201808201205500126227@zte.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 20, 2018 at 12:05:50PM +0800, wang.yi59@zte.com.cn wrote: > Gentle ping :) > > > The 'tbl' variable may leak when return in function > > wq_numa_init(), and this patch fixes this. > > > > Signed-off-by: Yi Wang > > Reviewed-by: Jiang Biao It's a kernel bug path where we might as well crash. Whether the tbl gets leaked or not doesn't matter. Thanks. -- tejun