Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4140769imm; Mon, 20 Aug 2018 10:29:34 -0700 (PDT) X-Google-Smtp-Source: AA+uWPwDya6UwVxmRJNC/nFHc2T2vBogD+uR1Z+d2HAArPQBH//1YdYhJe5/s+6gGXlOeMf33k0b X-Received: by 2002:a17:902:7202:: with SMTP id ba2-v6mr46404461plb.179.1534786173967; Mon, 20 Aug 2018 10:29:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534786173; cv=none; d=google.com; s=arc-20160816; b=yMwnn/tSGVv4yIrN6ndNbeuZGs/lHn7aJERGyHwU1uedru3nAk5elnn2zlRguUBFaN 0GX2tnbSTx7hC9rYNGK8ePGQSbj6cAGvfGPFmqkdX/4Fgp2dSadh3ZR9DAa50S0bEXYB Ny//KKAvX4ciJ51unNfdHkjdtFTGzE8RSW2DUL48v+LbdC+DOKwaFBaqbZF5uYeXlll1 hNmm7PTfICcQqNt+6JifEMD+S9vuMd+8pxLm8L00aNl0hsguzNPJu2s+KRDI5zzwuelR WPEAcUfGCUL0yVwleICkrgQ1M7+CitDDTH/tZQqFhOS6uBvHmjTQlKueIaP9iuE0EnvX 2VDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=qMtiE7Pb5CsAnAPXPazE6nSNiSB8vucoxWWcLv+zH50=; b=HrwansZs9xaCBxzFPd5Mmib/eO5xpdHcG3lnrZQZ3QbUdax96BYy26k1Uu27iAo9R7 tuiL846LaQ+E8QPhD420oeGEr7g7xaZdNS9qYecMFUFr4NisUqgZmrQXcKbHN9BPbODn XQuRkfcW3il1HHXf5EuPFJ780/AfCe9mZ3Jx7y1kHsJIjSVWKFJnoixOExXO/jOxgHS3 hQYY2oOUpIDdvalW1WfU7NOlaF/6Lu82DP3A3CT9YX1vAmJbEuEuUsDmOlIxVE8/5uty VKNHKK4xFYjoqLBJyVG9zp/QDfBiRgHENJc4SaD3PP2CGE+ROkTaWfogdB2PW+ofykZS R0iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EPGOWIyN; dkim=pass header.i=@codeaurora.org header.s=default header.b=EPGOWIyN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k140-v6si10803235pfd.122.2018.08.20.10.29.19; Mon, 20 Aug 2018 10:29:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EPGOWIyN; dkim=pass header.i=@codeaurora.org header.s=default header.b=EPGOWIyN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727507AbeHTUPh (ORCPT + 99 others); Mon, 20 Aug 2018 16:15:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44798 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726144AbeHTUPg (ORCPT ); Mon, 20 Aug 2018 16:15:36 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E58B46143B; Mon, 20 Aug 2018 16:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534784350; bh=3KP7yolDnZ54h2hcvzHp676CTvEP9jSqzVqiUmqBJyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EPGOWIyNakLp/4NS8yLOVM45SGnVRXxi5wHHfhA8UeOkuLBGilvcCj0QsrgmkKCeZ sR4eA1ccnKK73xUJefMFoRJpMCE2FJ7AUxSfZTf91ofoir7PBW7/7/+20Gw6aP1Tch C2y47TlijQYFY9vyjYvQTHcJvUht7oTdPjjkqb7Q= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 9577A61423; Mon, 20 Aug 2018 16:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1534784350; bh=3KP7yolDnZ54h2hcvzHp676CTvEP9jSqzVqiUmqBJyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EPGOWIyNakLp/4NS8yLOVM45SGnVRXxi5wHHfhA8UeOkuLBGilvcCj0QsrgmkKCeZ sR4eA1ccnKK73xUJefMFoRJpMCE2FJ7AUxSfZTf91ofoir7PBW7/7/+20Gw6aP1Tch C2y47TlijQYFY9vyjYvQTHcJvUht7oTdPjjkqb7Q= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 20 Aug 2018 09:59:10 -0700 From: pheragu@codeaurora.org To: Trilok Soni Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ckadabi@codeaurora.org, bryanh@codeaurora.org, psodagud@codeaurora.org, rnayak@codeaurora.org, Satya Durga Srinivasu Prabhala Subject: Re: [PATCH v1 2/2] Embedded USB Debugger (EUD) driver In-Reply-To: <589f8341-580b-d1d0-5efd-261d8d4821b0@codeaurora.org> References: <1534464348-8227-1-git-send-email-pheragu@codeaurora.org> <1534464348-8227-3-git-send-email-pheragu@codeaurora.org> <589f8341-580b-d1d0-5efd-261d8d4821b0@codeaurora.org> Message-ID: X-Sender: pheragu@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018-08-17 12:47, Trilok Soni wrote: > Hi Prakruthi, > > On 8/16/2018 5:05 PM, Prakruthi Deepak Heragu wrote: >> + >> +#define EUD_INT_VBUS BIT(2) >> +#define EUD_INT_CHGR BIT(3) >> +#define EUD_INT_SAFE_MODE BIT(4) >> + >> +#define EUD_NR 1 > > I don't see any use of EUD_NR in the driver below. Do we need it? Sorry about that. Will get rid of it.