Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Jeff Layton <jlayton@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Cleanup "fat: propagate 64-bit inode timestamps" patch
References: <87zhxkjyww.fsf@mail.parknet.co.jp>
        <CAK8P3a3SVi2odjavRy-ktzcU2sMREVc+8EKxmDq3cv2nGeTeCg@mail.gmail.com>
Date:   Tue, 21 Aug 2018 07:23:35 +0900
In-Reply-To: <CAK8P3a3SVi2odjavRy-ktzcU2sMREVc+8EKxmDq3cv2nGeTeCg@mail.gmail.com>
        (Arnd Bergmann's message of "Mon, 20 Aug 2018 14:39:09 +0200")
Message-ID: <87h8jo4qzc.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Arnd Bergmann <arnd@arndb.de> writes:

>>  /* Linear day numbers of the respective 1sts in non-leap years. */
>> -static time64_t days_in_year[] = {
>> +static long days_in_year[] = {
>>         /* Jan  Feb  Mar  Apr  May  Jun  Jul  Aug  Sep  Oct  Nov  Dec */
>>         0,   0,  31,  59,  90, 120, 151, 181, 212, 243, 273, 304, 334, 0, 0, 0,
>>  };
>
> While this is correct, changing it back to a signed 'long' type seems
> rather arbitrary. I tried to pick a type that would be the same on 32-bit
> and 64-bit architectures, the other choice would have been 'u16',
> which saves a few bytes.

Right. However, "long long" on 32bit arch is not same. In this implement
"long long" works though, Some calculation needs libgcc helper (in
kernel, div64 stuff).  I want to avoid it early than later, and I don't
care saving a few memory in here (I would not care if it was u16).

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>