Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4797454imm; Tue, 21 Aug 2018 00:51:00 -0700 (PDT) X-Google-Smtp-Source: AA+uWPy6hlhLKWEFq/1ungjyx7aNzxRUHtcTggA5BxiT0nJpqPqC+XY7tiqIg0gV69e7fbUHYqK7 X-Received: by 2002:a17:902:bcc6:: with SMTP id o6-v6mr48579657pls.117.1534837860520; Tue, 21 Aug 2018 00:51:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534837860; cv=none; d=google.com; s=arc-20160816; b=YJZaD/a9VyK/YUVUOfVTHJnGEN6oJtQufI1B09MIUWMl1EaqcwoMPIIwuPGMbtg2Up d1/PdZBdJMKqniywvZh46IUDIj9M9Vjw1I6EfvVguCCS5TvoJUlEJ6yn2fVYV9k6TgMa uBrkYsfbtqbya6/vitgBHx1ggvsG/LFgWSs0koPucSmeQzxfeYFqTflghVGrcbXjT/5Q WD2VRa46UuDXgeqxzIbeJl8Jz8S4U1/CVWe/bgQfS7gYTt4Jl/OB/vpuZi84R5zFEntY IJOkpPNeKQdXkTQC25UuvKDF8FOHmo2lHhmoUBZkbS0/j2he8Ps3CWFbRDZ06W73Qm7X 9CFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=0Li3f/2LTZ8whdy4Jc34rk7eH/mkgDrVvLujkSs+678=; b=BIdEdg/ZxoEkX8YQZosOce+s0hOIPjWycRA55u8JK6xvNxf1yg2NLyIgs080+Q+4xJ 9/FJIWx6gNPKhHpMkcQyTBc8PfuO+jLeGFM7kR4RntImNUBG5E+iTci8MGRyATEMEw/5 7hpnKT88agt0EvIY5jh3PGqB3iz4xZ1vg6if67UC5JVf22Y3kjI8Pl8+2YVAhJdrYS8U 2yT4MvGFyqgTFlu+TvS53DDxwXqaHHyIjv4M5NpI6tTynkOx7RgJ++WdSEiDc5Q8ZKfE HNZe0oKznhHj1+tF89tuLS/gu7QRG8krepJeq0Lk4CDghhp23OXMB5PdgbHQROe4W8Q+ +PuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="iltV4oQ/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u129-v6si12846758pfb.247.2018.08.21.00.50.45; Tue, 21 Aug 2018 00:51:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="iltV4oQ/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbeHULIO (ORCPT + 99 others); Tue, 21 Aug 2018 07:08:14 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42210 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726413AbeHULIO (ORCPT ); Tue, 21 Aug 2018 07:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0Li3f/2LTZ8whdy4Jc34rk7eH/mkgDrVvLujkSs+678=; b=iltV4oQ/kNegI0o6LcDJFA8HP kjbKvlfUJPOSdgY/4nHbeuj1OXFSWinpF9nSFpapwuChMQsvymKOVWwHADfXYmRH5Roenw2B2bCYe gW3Q5tGfdmKzEFuAvoikEoQZuChE21QIHQBZzUOMuwW96jGU+yfoas5S8u8wXhy4YvpW7H0bgxD28 E3aSCc3BE5bkTtCDpXyDz+BsPu/Bnyz8vRS0beU/FNtmI/3FehfoLyXBooKaoOF//JA+DlbXAyMn+ DJJP8Cjr33TzZ7CcWd3nyy+HaLhCIO+i34OKsoOwT1eLyv1noR1GclML+jX2TkgrOpbM03Jyngklp 19Osz79WA==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fs1PW-0000GU-UY; Tue, 21 Aug 2018 07:49:06 +0000 Date: Tue, 21 Aug 2018 00:49:06 -0700 From: Christoph Hellwig To: Atish Patra Cc: palmer@sifive.com, linux-riscv@lists.infradead.org, mark.rutland@arm.com, anup@brainfault.org, hch@infradead.org, tglx@linutronix.de, Damien.LeMoal@wdc.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/5] RISC-V: Move interrupt cause declarations to irq.h Message-ID: <20180821074906.GB28079@infradead.org> References: <1534377377-70108-1-git-send-email-atish.patra@wdc.com> <1534377377-70108-5-git-send-email-atish.patra@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1534377377-70108-5-git-send-email-atish.patra@wdc.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 04:56:16PM -0700, Atish Patra wrote: > CPU hotplug code in smpboot requires interrupt cause > to identify the cause of cpu wakeup. > > Move the IRQ cause declarations to appropriate header > file. asm/irq.h is a header indirectly included by just about every driver. This is a very bad place for such internal definitions.