Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp4894041imm; Tue, 21 Aug 2018 02:51:42 -0700 (PDT) X-Google-Smtp-Source: AA+uWPzi1pj6d2IrIAnK9OF6mY8c0cuH9yGhiaxzMufDpuFjoHIzZDVP9D12ELIvGnp55b0mWPbM X-Received: by 2002:a62:f0d:: with SMTP id x13-v6mr51804823pfi.123.1534845102834; Tue, 21 Aug 2018 02:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534845102; cv=none; d=google.com; s=arc-20160816; b=ORfLcR+cyJgXC7Jxs8awQWe+btdvIGY+6rm9DeumofOdFjhPrq+f0hwAi0SFOY/Ww/ CnFGfXbzTofVu/lsXI7yC60UZ6vOdAgxxWBrTvrUevd/k+Kwvx2fE9VJ8T2RzrnuO+gd vKScLfiSPqn0KPEgbYEmVr4ph05Hgwr6Ou+SxRlpV2wixU12Q8LdjEmGnuIvUv0j+t1u DuTf2aY4dkGilR5ljkLfiS0LuWzGiqzqqkkWDC51iYG2tc5AyY4znbjBzR8+w69A6yQA NSFjqHSw2CS54OkwBGfQXOftQCxDxb4vL/FDNXWVvoVL/h7+JLscl92XKonG6qUPRzcK RD8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=8vP5tQjueaKebpIG8lvKOk7rcE8hPPPF+Bwwq5gcPvA=; b=PGtjTlN39WdESiKSLzujaEhFoR8Xxb/LGp+jpBymTwYetnl3m7p6qph2gFHL9DuLEu 9hBhb/ac5BsimZCG+3CquiuMtSTlXupMQZaVf1k6EPrHyDFrKbBKIxZJ+cboMoGyo2FV MzmYcjaE+KDgc7gVaKoYSU13bD70eBO/vslZMzxZk/ZVLdPqcfVkdbwQrkUHIekJQssh IdqvIYVg/7SM7Ejs7441bXTKUzEF4CpZzdW6SPHTeKB9G6spD4CFqGzuHc1AvGO7Qe9u Oi7wzVW4P1KRmouB5LgMaH0Stm6rVpyIqA8/+cy2M49FwpK/ekfweJj/Fj+MucvIutcj AgGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="OJ4ek/S9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b62-v6si9081165pgc.491.2018.08.21.02.51.27; Tue, 21 Aug 2018 02:51:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="OJ4ek/S9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726684AbeHUNJj (ORCPT + 99 others); Tue, 21 Aug 2018 09:09:39 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35637 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726549AbeHUNJi (ORCPT ); Tue, 21 Aug 2018 09:09:38 -0400 Received: by mail-wr1-f68.google.com with SMTP id g1-v6so15319978wru.2 for ; Tue, 21 Aug 2018 02:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8vP5tQjueaKebpIG8lvKOk7rcE8hPPPF+Bwwq5gcPvA=; b=OJ4ek/S9uY4HWTlb42V92J7x5lvZeAJmKnAolKVf/jf0M34K4JAVMJiDBJO6PTi4Vi d4QyI/d/VhXnYvWyNPFlQdWLZF/cabYbMz+Nh1pltAoQ4+RYj9Ub9F3nEef7Bz++nYlZ UVT1uXjvbmUtjod0AKKK0nUTLih2Rmfzqsyfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8vP5tQjueaKebpIG8lvKOk7rcE8hPPPF+Bwwq5gcPvA=; b=XDJsKx0rUSjZh4xGleK/KCJdRTfohetla4ejYjGNik0iP+80MzEt4G1gVweemelYUL IfjfsMxhO76Ekv5wiylRkYt0ltbUm5EPcSVaaO22QeUxNZU1I/tW4L5ktNqSNa81LP8O UM6JbPlu2WHdRLBL3x85a1dYnA7H/BVndEE8m5DbBM0YZyY/Lea9LhBTBYlWrl5ycftT bl48f2vrngrMJ4xcopUiGFKEJc0eFdh2VyjQBrTgdKWnzw41ioxAONDmPSPCcmidGo06 gtAN3aq/hVytGO6Dd0SGbIph6wNsz6E4CuQ97Ytnu9wGa8OKNwvpiV4M11DKJMZE+Bgm 3wkA== X-Gm-Message-State: APzg51CEXyJco+0J+a+MYCAhoNXtbWDHXdPTu6/Tl4hifq8NG8Y5jeKe kYmftY3K4pjFHJuh0n6YTLoZbA== X-Received: by 2002:adf:a964:: with SMTP id u91-v6mr3430691wrc.140.1534845009128; Tue, 21 Aug 2018 02:50:09 -0700 (PDT) Received: from [192.168.0.18] (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.googlemail.com with ESMTPSA id m68-v6sm3857097wmb.10.2018.08.21.02.50.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 02:50:08 -0700 (PDT) Subject: Re: [PATCH v2 06/29] mtd: Add support for reading MTD devices via the nvmem API To: Boris Brezillon Cc: Alban , Bartosz Golaszewski , Jonathan Corbet , Sekhar Nori , Kevin Hilman , Russell King , Arnd Bergmann , Greg Kroah-Hartman , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Grygorii Strashko , "David S . Miller" , Naren , Mauro Carvalho Chehab , Andrew Morton , Lukas Wunner , Dan Carpenter , Florian Fainelli , Ivan Khoronzhuk , Sven Van Asbroeck , Paolo Abeni , Rob Herring , David Lechner , Andrew Lunn , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, netdev@vger.kernel.org, Bartosz Golaszewski References: <20180810080526.27207-1-brgl@bgdev.pl> <20180810080526.27207-7-brgl@bgdev.pl> <20180817182720.6a6e5e8e@bbrezillon> <20180819133106.0420df5f@tock> <20180819184609.6dcdbb9a@bbrezillon> <5b8c30b8-41e1-d59e-542b-fef6c6469ff0@linaro.org> <20180820202038.5d3dc195@bbrezillon> From: Srinivas Kandagatla Message-ID: Date: Tue, 21 Aug 2018 10:50:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180820202038.5d3dc195@bbrezillon> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/08/18 19:20, Boris Brezillon wrote: > On Mon, 20 Aug 2018 11:43:34 +0100 > Srinivas Kandagatla wrote: > >> >> Overall am still not able to clear visualize on how MTD bindings with >> nvmem cells would look in both partition and un-partition usecases? >> An example DT would be nice here!! > > Something along those lines: > This looks good to me. > mtdnode { > nvmem-cells { > #address-cells = <1>; > #size-cells = <1>; > > cell@0 { > reg = <0x0 0x14>; > }; > }; > > partitions { > compatible = "fixed-partitions"; > #address-cells = <1>; > #size-cells = <1>; > > partition@0 { > reg = <0x0 0x20000>; > > nvmem-cells { > #address-cells = <1>; > #size-cells = <1>; > > cell@0 { > reg = <0x0 0x10>; > }; > }; > }; > }; > }; > Just curious...Is there a reason why we can't do it like this?: Is this because of issue of #address-cells and #size-cells Or mtd bindings always prefer subnodes? mtdnode { reg = <0x0123000 0x40000>; #address-cells = <1>; #size-cells = <1>; cell@0 { compatible = "nvmem-cell"; reg = <0x0 0x14>; }; partitions { compatible = "fixed-partitions"; #address-cells = <1>; #size-cells = <1>; partition@0 { reg = <0x0 0x20000>; cell@0 { compatible = "nvmem-cell"; reg = <0x0 0x10>; }; }; }; }; Am okay either way! thanks, srini